diff mbox

[U-Boot,1/4] at91: add new gpio pin definitions

Message ID 1385723626-1586-2-git-send-email-andreas.devel@googlemail.com
State Accepted, archived
Delegated to: Andreas Bießmann
Headers show

Commit Message

Andreas Bießmann Nov. 29, 2013, 11:13 a.m. UTC
This patch define new names for GPIO pins on at91 devices. Follow up patches
will convert the whole infrastructure to use these new definitions.

Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
---
 arch/arm/include/asm/arch-at91/gpio.h |   24 +++++++++++++++++++++++-
 drivers/gpio/at91_gpio.c              |    4 +---
 2 files changed, 24 insertions(+), 4 deletions(-)

Comments

Bo Shen Dec. 2, 2013, 5:27 a.m. UTC | #1
Hi Andreas,

On 11/29/2013 07:13 PM, Andreas Bießmann wrote:
> This patch define new names for GPIO pins on at91 devices. Follow up patches
> will convert the whole infrastructure to use these new definitions.
>
> Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
> ---
>   arch/arm/include/asm/arch-at91/gpio.h |   24 +++++++++++++++++++++++-
>   drivers/gpio/at91_gpio.c              |    4 +---
>   2 files changed, 24 insertions(+), 4 deletions(-)

For this series, tested OK on at91sam9n12ek and at91sam9x5ek board.
Thanks.

Tested-by: Bo Shen <voice.shen@atmel.com>

Best Regards,
Bo Shen
Andreas Bießmann Dec. 9, 2013, 12:35 p.m. UTC | #2
Dear Andreas Devel,

Andreas Devel <andreas.devel@googlemail.com> writes:
>This patch define new names for GPIO pins on at91 devices. Follow up patches
>will convert the whole infrastructure to use these new definitions.
>
>Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>
>Tested-by: Bo Shen <voice.shen@atmel.com>
>
>---
>arch/arm/include/asm/arch-at91/gpio.h |   24 +++++++++++++++++++++++-
> drivers/gpio/at91_gpio.c              |    4 +---
> 2 files changed, 24 insertions(+), 4 deletions(-)

applied to u-boot-atmel/master, thanks!

Best regards,
Andreas Bießmann
diff mbox

Patch

diff --git a/arch/arm/include/asm/arch-at91/gpio.h b/arch/arm/include/asm/arch-at91/gpio.h
index 0700427..b340afe 100644
--- a/arch/arm/include/asm/arch-at91/gpio.h
+++ b/arch/arm/include/asm/arch-at91/gpio.h
@@ -231,4 +231,26 @@  static inline unsigned pin_to_mask(unsigned pin)
 #define at91_set_gpio_value(x, y)	at91_set_pio_value(x, y)
 #define at91_get_gpio_value(x)		at91_get_pio_value(x)
 #endif
-#endif
+
+#define GPIO_PIOA_BASE  (0)
+#define GPIO_PIOB_BASE  (GPIO_PIOA_BASE + 32)
+#define GPIO_PIOC_BASE  (GPIO_PIOB_BASE + 32)
+#define GPIO_PIOD_BASE  (GPIO_PIOC_BASE + 32)
+#define GPIO_PIOE_BASE  (GPIO_PIOD_BASE + 32)
+#define GPIO_PIN_PA(x)  (GPIO_PIOA_BASE + (x))
+#define GPIO_PIN_PB(x)  (GPIO_PIOB_BASE + (x))
+#define GPIO_PIN_PC(x)  (GPIO_PIOC_BASE + (x))
+#define GPIO_PIN_PD(x)  (GPIO_PIOD_BASE + (x))
+#define GPIO_PIN_PE(x)  (GPIO_PIOE_BASE + (x))
+
+static inline unsigned at91_gpio_to_port(unsigned gpio)
+{
+	return gpio / 32;
+}
+
+static inline unsigned at91_gpio_to_pin(unsigned gpio)
+{
+	return gpio % 32;
+}
+
+#endif /* __ASM_ARCH_AT91_GPIO_H */
diff --git a/drivers/gpio/at91_gpio.c b/drivers/gpio/at91_gpio.c
index af09786..8b76666 100644
--- a/drivers/gpio/at91_gpio.c
+++ b/drivers/gpio/at91_gpio.c
@@ -14,6 +14,7 @@ 
 #include <asm/sizes.h>
 #include <asm/arch/hardware.h>
 #include <asm/arch/at91_pio.h>
+#include <asm/arch/gpio.h>
 
 static struct at91_port *at91_pio_get_port(unsigned port)
 {
@@ -356,9 +357,6 @@  int at91_get_pio_value(unsigned port, unsigned pin)
 
 /* Common GPIO API */
 
-#define at91_gpio_to_port(gpio)		(gpio / 32)
-#define at91_gpio_to_pin(gpio)		(gpio % 32)
-
 int gpio_request(unsigned gpio, const char *label)
 {
 	return 0;