diff mbox series

[v1,3/9] board: hpe: gxp: add HPE GXP soc support

Message ID 20220526185548.14104-3-nick.hawkins@hpe.com
State Superseded
Delegated to: Tom Rini
Headers show
Series Introduce HPE GXP Architecture | expand

Commit Message

Hawkins, Nick May 26, 2022, 6:55 p.m. UTC
From: Nick Hawkins <nick.hawkins@hpe.com>

Add basic support for the HPE GXP SoC. Reset the EHCI controller at
boot.

Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
---
 board/hpe/gxp/Kconfig     | 47 +++++++++++++++++++++++++++++++++++++++
 board/hpe/gxp/Makefile    |  1 +
 board/hpe/gxp/gxp_board.c | 33 +++++++++++++++++++++++++++
 3 files changed, 81 insertions(+)
 create mode 100644 board/hpe/gxp/Kconfig
 create mode 100644 board/hpe/gxp/Makefile
 create mode 100644 board/hpe/gxp/gxp_board.c

Comments

Tom Rini June 1, 2022, 2:24 p.m. UTC | #1
On Thu, May 26, 2022 at 01:55:42PM -0500, nick.hawkins@hpe.com wrote:

> From: Nick Hawkins <nick.hawkins@hpe.com>
> 
> Add basic support for the HPE GXP SoC. Reset the EHCI controller at
> boot.
> 
> Signed-off-by: Nick Hawkins <nick.hawkins@hpe.com>
> ---
>  board/hpe/gxp/Kconfig     | 47 +++++++++++++++++++++++++++++++++++++++
>  board/hpe/gxp/Makefile    |  1 +
>  board/hpe/gxp/gxp_board.c | 33 +++++++++++++++++++++++++++
>  3 files changed, 81 insertions(+)
>  create mode 100644 board/hpe/gxp/Kconfig
>  create mode 100644 board/hpe/gxp/Makefile
>  create mode 100644 board/hpe/gxp/gxp_board.c
[snip]
> +config GXP_ECC
> +	default n
> +	bool "Enable memory ECC protected"

"n" is the normal default, so you don't need to add it here.

> +	help
> +		Use half of memory to enable ECC protected

The normal indentation is "<tab><space><space>".

> diff --git a/board/hpe/gxp/gxp_board.c b/board/hpe/gxp/gxp_board.c
> new file mode 100644
> index 0000000000..7fc1bf2fd6
> --- /dev/null
> +++ b/board/hpe/gxp/gxp_board.c
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * GXP timer driver
> + *
> + * (C) Copyright 2022 Hewlett Packard Enterprise Development LP.
> + * Author: Nick Hawkins <nick.hawkins@hpe.com>
> + * Author: Jean-Marie Verdun <verdun@hpe.com>
> + */
> +
> +#include <asm/io.h>
> +#include <common.h>

Here and elsewhere, <common.h> really just grabs a few other header
files.  Don't use it, and include what you need directly instead.
diff mbox series

Patch

diff --git a/board/hpe/gxp/Kconfig b/board/hpe/gxp/Kconfig
new file mode 100644
index 0000000000..5fea1a6a0d
--- /dev/null
+++ b/board/hpe/gxp/Kconfig
@@ -0,0 +1,47 @@ 
+choice
+	prompt "SoC select"
+
+config TARGET_GXP
+	bool "GXP"
+	select DM
+	select SOC_GXP
+	imply CMD_DM
+
+config TARGET_GXP2
+	bool "GXP2"
+	select DM
+	select SOC_GXP
+	select GXP_ECC
+	imply CMD_DM
+
+endchoice
+
+choice
+	prompt "GXP VROM size"
+	default GXP_VROM_64MB
+	optional
+
+config GXP_VROM_64MB
+	bool "64MB"
+
+config GXP_VROM_32MB
+	bool "32MB"
+endchoice
+
+config GXP_ECC
+	default n
+	bool "Enable memory ECC protected"
+	help
+		Use half of memory to enable ECC protected
+
+config SYS_BOARD
+	default "gxp"
+
+config SYS_VENDOR
+	default "hpe"
+
+config SYS_CONFIG_NAME
+	default "gxp"
+
+config SYS_TEXT_BASE
+	default 0x50000000
diff --git a/board/hpe/gxp/Makefile b/board/hpe/gxp/Makefile
new file mode 100644
index 0000000000..775d6bf849
--- /dev/null
+++ b/board/hpe/gxp/Makefile
@@ -0,0 +1 @@ 
+obj-y += gxp_board.o
diff --git a/board/hpe/gxp/gxp_board.c b/board/hpe/gxp/gxp_board.c
new file mode 100644
index 0000000000..7fc1bf2fd6
--- /dev/null
+++ b/board/hpe/gxp/gxp_board.c
@@ -0,0 +1,33 @@ 
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * GXP timer driver
+ *
+ * (C) Copyright 2022 Hewlett Packard Enterprise Development LP.
+ * Author: Nick Hawkins <nick.hawkins@hpe.com>
+ * Author: Jean-Marie Verdun <verdun@hpe.com>
+ */
+
+#include <asm/io.h>
+#include <common.h>
+#include <dm.h>
+#include <dm/uclass.h>
+#include <ram.h>
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define ECHI_CMD 0xcefe0010
+
+int board_init(void)
+{
+	writel(0x00080002, ECHI_CMD);
+
+	return 0;
+}
+
+int dram_init(void)
+{
+	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
+
+	return 0;
+}
+