| Message ID | 20220215142723.45242-1-fb@ltec.ch |
|---|---|
| State | Accepted |
| Commit | 286f94803ee446a3ef730626f2219a0a28a82b8e |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | arm: pdu001: Fix early debugging UART | expand |
On Tue, Feb 15, 2022 at 03:27:23PM +0100, Felix Brack wrote: > The changes from commit 0dba45864b2a ("arm: Init the debug UART") > prevent the early debug UART from being initialized correctly. > To fix this we not just configure the pin multiplexer but add setting up > early clocks. > > Signed-off-by: Felix Brack <fb@ltec.ch> Reviewed-by: Tom Rini <trini@konsulko.com>
On Tue, 15 Feb 2022 at 07:27, Felix Brack <fb@ltec.ch> wrote: > > The changes from commit 0dba45864b2a ("arm: Init the debug UART") > prevent the early debug UART from being initialized correctly. > To fix this we not just configure the pin multiplexer but add setting up > early clocks. > > Signed-off-by: Felix Brack <fb@ltec.ch> > --- > > board/eets/pdu001/Makefile | 6 +----- > board/eets/pdu001/board.c | 2 ++ > 2 files changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Tue, Feb 15, 2022 at 03:27:23PM +0100, Felix Brack wrote: > The changes from commit 0dba45864b2a ("arm: Init the debug UART") > prevent the early debug UART from being initialized correctly. > To fix this we not just configure the pin multiplexer but add setting up > early clocks. > > Signed-off-by: Felix Brack <fb@ltec.ch> > Reviewed-by: Tom Rini <trini@konsulko.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/board/eets/pdu001/Makefile b/board/eets/pdu001/Makefile index a5990ce3ad..35ea3978fe 100644 --- a/board/eets/pdu001/Makefile +++ b/board/eets/pdu001/Makefile @@ -6,8 +6,4 @@ # SPDX-License-Identifier: GPL-2.0+ # -ifeq ($(CONFIG_$(SPL_)SKIP_LOWLEVEL_INIT),) -obj-y := mux.o -endif - -obj-y += board.o +obj-y := board.o mux.o diff --git a/board/eets/pdu001/board.c b/board/eets/pdu001/board.c index 9f3cfd4f84..8612c09d40 100644 --- a/board/eets/pdu001/board.c +++ b/board/eets/pdu001/board.c @@ -240,6 +240,8 @@ void sdram_init(void) #ifdef CONFIG_DEBUG_UART void board_debug_uart_init(void) { + setup_early_clocks(); + /* done by pin controller driver if not debugging */ enable_uart_pin_mux(CONFIG_DEBUG_UART_BASE); }
The changes from commit 0dba45864b2a ("arm: Init the debug UART") prevent the early debug UART from being initialized correctly. To fix this we not just configure the pin multiplexer but add setting up early clocks. Signed-off-by: Felix Brack <fb@ltec.ch> --- board/eets/pdu001/Makefile | 6 +----- board/eets/pdu001/board.c | 2 ++ 2 files changed, 3 insertions(+), 5 deletions(-)