| Message ID | 1633330133-29617-3-git-send-email-pillair@codeaurora.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add support for sc7280 WPSS PIL loading | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | fail | build log |
On Mon, 04 Oct 2021 12:18:52 +0530, Rakesh Pillai wrote: > Add WPSS PIL loading support for SC7280 SoCs. > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > --- > .../bindings/remoteproc/qcom,sc7280-wpss-pil.yaml | 196 +++++++++++++++++++++ > 1 file changed, 196 insertions(+) > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml: properties:interrupts: 'oneOf' conditional failed, one must be fixed: [{'description': 'Watchdog interrupt'}, {'description': 'Fatal interrupt'}, {'description': 'Ready interrupt'}, {'description': 'Handover interrupt'}, {'description': 'Stop acknowledge interrupt'}, {'description': 'Shutdown acknowledge interrupt'}] is too long [{'description': 'Watchdog interrupt'}, {'description': 'Fatal interrupt'}, {'description': 'Ready interrupt'}, {'description': 'Handover interrupt'}, {'description': 'Stop acknowledge interrupt'}, {'description': 'Shutdown acknowledge interrupt'}] is too short False schema does not allow 6 1 was expected 6 is greater than the maximum of 2 6 is greater than the maximum of 3 6 is greater than the maximum of 4 6 is greater than the maximum of 5 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml: properties:interrupt-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'wdog'}, {'const': 'fatal'}, {'const': 'ready'}, {'const': 'handover'}, {'const': 'stop-ack'}, {'const': 'shutdown-ack'}] is too long [{'const': 'wdog'}, {'const': 'fatal'}, {'const': 'ready'}, {'const': 'handover'}, {'const': 'stop-ack'}, {'const': 'shutdown-ack'}] is too short False schema does not allow 6 1 was expected 6 is greater than the maximum of 2 6 is greater than the maximum of 3 6 is greater than the maximum of 4 6 is greater than the maximum of 5 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml: properties:clocks: 'oneOf' conditional failed, one must be fixed: [{'description': 'GCC WPSS AHB BDG Master clock'}, {'description': 'GCC WPSS AHB clock'}, {'description': 'GCC WPSS RSCP clock'}, {'description': 'XO clock'}] is too long [{'description': 'GCC WPSS AHB BDG Master clock'}, {'description': 'GCC WPSS AHB clock'}, {'description': 'GCC WPSS RSCP clock'}, {'description': 'XO clock'}] is too short False schema does not allow 4 1 was expected 4 is greater than the maximum of 2 4 is greater than the maximum of 3 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml: properties:clock-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'ahb_bdg'}, {'const': 'ahb'}, {'const': 'rscp'}, {'const': 'xo'}] is too long [{'const': 'ahb_bdg'}, {'const': 'ahb'}, {'const': 'rscp'}, {'const': 'xo'}] is too short False schema does not allow 4 1 was expected 4 is greater than the maximum of 2 4 is greater than the maximum of 3 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml: properties:power-domains: 'oneOf' conditional failed, one must be fixed: [{'description': 'CX power domain'}, {'description': 'MX power domain'}] is too long [{'description': 'CX power domain'}, {'description': 'MX power domain'}] is too short False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml: properties:power-domain-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'cx'}, {'const': 'mx'}] is too long [{'const': 'cx'}, {'const': 'mx'}] is too short False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml: properties:resets: 'oneOf' conditional failed, one must be fixed: [{'description': 'AOSS restart'}, {'description': 'PDC SYNC'}] is too long [{'description': 'AOSS restart'}, {'description': 'PDC SYNC'}] is too short False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml: properties:reset-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'restart'}, {'const': 'pdc_sync'}] is too long [{'const': 'restart'}, {'const': 'pdc_sync'}] is too short False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml: ignoring, error in schema: properties: interrupts warning: no schema found in file: ./Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.example.dt.yaml:0:0: /example-0/remoteproc@8a00000: failed to match any schema with compatible: ['qcom,sc7280-wpss-pil'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1535950 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
> -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Monday, October 4, 2021 5:51 PM > To: Rakesh Pillai <pillair@codeaurora.org> > Cc: mathieu.poirier@linaro.org; swboyd@chromium.org; > p.zabel@pengutronix.de; devicetree@vger.kernel.org; > bjorn.andersson@linaro.org; linux-kernel@vger.kernel.org; > robh+dt@kernel.org; sibis@codeaurora.org; kuabhs@chromium.org; > agross@kernel.org; ohad@wizery.com; linux-arm-msm@vger.kernel.org; > mpubbise@codeaurora.org > Subject: Re: [PATCH v6 2/3] dt-bindings: remoteproc: qcom: Add SC7280 > WPSS support > > On Mon, 04 Oct 2021 12:18:52 +0530, Rakesh Pillai wrote: > > Add WPSS PIL loading support for SC7280 SoCs. > > > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > > --- > > .../bindings/remoteproc/qcom,sc7280-wpss-pil.yaml | 196 > > +++++++++++++++++++++ > > 1 file changed, 196 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss- > pil.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- > wpss-pil.yaml: properties:interrupts: 'oneOf' conditional failed, one must be > fixed: > [{'description': 'Watchdog interrupt'}, {'description': 'Fatal interrupt'}, > {'description': 'Ready interrupt'}, {'description': 'Handover interrupt'}, > {'description': 'Stop acknowledge interrupt'}, {'description': 'Shutdown > acknowledge interrupt'}] is too long > [{'description': 'Watchdog interrupt'}, {'description': 'Fatal interrupt'}, > {'description': 'Ready interrupt'}, {'description': 'Handover interrupt'}, > {'description': 'Stop acknowledge interrupt'}, {'description': 'Shutdown > acknowledge interrupt'}] is too short > False schema does not allow 6 > 1 was expected > 6 is greater than the maximum of 2 > 6 is greater than the maximum of 3 > 6 is greater than the maximum of 4 > 6 is greater than the maximum of 5 > hint: "minItems" is only needed if less than the "items" list length > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- > wpss-pil.yaml: properties:interrupt-names: 'oneOf' conditional failed, one > must be fixed: > [{'const': 'wdog'}, {'const': 'fatal'}, {'const': 'ready'}, {'const': > 'handover'}, {'const': 'stop-ack'}, {'const': 'shutdown-ack'}] is too long > [{'const': 'wdog'}, {'const': 'fatal'}, {'const': 'ready'}, {'const': > 'handover'}, {'const': 'stop-ack'}, {'const': 'shutdown-ack'}] is too short > False schema does not allow 6 > 1 was expected > 6 is greater than the maximum of 2 > 6 is greater than the maximum of 3 > 6 is greater than the maximum of 4 > 6 is greater than the maximum of 5 > hint: "minItems" is only needed if less than the "items" list length > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- > wpss-pil.yaml: properties:clocks: 'oneOf' conditional failed, one must be > fixed: > [{'description': 'GCC WPSS AHB BDG Master clock'}, {'description': > 'GCC WPSS AHB clock'}, {'description': 'GCC WPSS RSCP clock'}, {'description': > 'XO clock'}] is too long > [{'description': 'GCC WPSS AHB BDG Master clock'}, {'description': > 'GCC WPSS AHB clock'}, {'description': 'GCC WPSS RSCP clock'}, {'description': > 'XO clock'}] is too short > False schema does not allow 4 > 1 was expected > 4 is greater than the maximum of 2 > 4 is greater than the maximum of 3 > hint: "minItems" is only needed if less than the "items" list length > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- > wpss-pil.yaml: properties:clock-names: 'oneOf' conditional failed, one must > be fixed: > [{'const': 'ahb_bdg'}, {'const': 'ahb'}, {'const': 'rscp'}, {'const': 'xo'}] is > too long > [{'const': 'ahb_bdg'}, {'const': 'ahb'}, {'const': 'rscp'}, {'const': 'xo'}] is > too short > False schema does not allow 4 > 1 was expected > 4 is greater than the maximum of 2 > 4 is greater than the maximum of 3 > hint: "minItems" is only needed if less than the "items" list length > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- > wpss-pil.yaml: properties:power-domains: 'oneOf' conditional failed, one > must be fixed: > [{'description': 'CX power domain'}, {'description': 'MX power > domain'}] is too long > [{'description': 'CX power domain'}, {'description': 'MX power > domain'}] is too short > False schema does not allow 2 > 1 was expected > hint: "minItems" is only needed if less than the "items" list length > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- > wpss-pil.yaml: properties:power-domain-names: 'oneOf' conditional failed, > one must be fixed: > [{'const': 'cx'}, {'const': 'mx'}] is too long > [{'const': 'cx'}, {'const': 'mx'}] is too short > False schema does not allow 2 > 1 was expected > hint: "minItems" is only needed if less than the "items" list length > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- > wpss-pil.yaml: properties:resets: 'oneOf' conditional failed, one must be > fixed: > [{'description': 'AOSS restart'}, {'description': 'PDC SYNC'}] is too long > [{'description': 'AOSS restart'}, {'description': 'PDC SYNC'}] is too short > False schema does not allow 2 > 1 was expected > hint: "minItems" is only needed if less than the "items" list length > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- > wpss-pil.yaml: properties:reset-names: 'oneOf' conditional failed, one must > be fixed: > [{'const': 'restart'}, {'const': 'pdc_sync'}] is too long > [{'const': 'restart'}, {'const': 'pdc_sync'}] is too short > False schema does not allow 2 > 1 was expected > hint: "minItems" is only needed if less than the "items" list length > from schema $id: http://devicetree.org/meta-schemas/items.yaml# > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/remoteproc/qcom,sc7280- > wpss-pil.yaml: ignoring, error in schema: properties: interrupts > warning: no schema found in file: > ./Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss- > pil.yaml > Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss- > pil.example.dt.yaml:0:0: /example-0/remoteproc@8a00000: failed to match > any schema with compatible: ['qcom,sc7280-wpss-pil'] > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1535950 > > This check can fail if there are any dependencies. The base for a patch series > is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. I have updated the dtschema (2021.7) and still not seeing these errors. I will fix the errors mentioned in this log though. Is there any other flag/setting, which is to be enabled ? Thanks, Rakesh Pillai.
Quoting pillair@codeaurora.org (2021-10-05 22:09:18) > > > > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), > > then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > > I have updated the dtschema (2021.7) and still not seeing these errors. I > will fix the errors mentioned in this log though. > Is there any other flag/setting, which is to be enabled ? > I have dtschema-2021.10 installed.
> -----Original Message----- > From: Stephen Boyd <swboyd@chromium.org> > Sent: Wednesday, October 6, 2021 12:40 PM > To: Rob Herring <robh@kernel.org>; pillair@codeaurora.org > Cc: mathieu.poirier@linaro.org; p.zabel@pengutronix.de; > devicetree@vger.kernel.org; bjorn.andersson@linaro.org; linux- > kernel@vger.kernel.org; robh+dt@kernel.org; sibis@codeaurora.org; > kuabhs@chromium.org; agross@kernel.org; ohad@wizery.com; linux-arm- > msm@vger.kernel.org; mpubbise@codeaurora.org > Subject: RE: [PATCH v6 2/3] dt-bindings: remoteproc: qcom: Add SC7280 > WPSS support > > Quoting pillair@codeaurora.org (2021-10-05 22:09:18) > > > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), > > > then make sure 'yamllint' is installed and dt-schema is up to > > > date: > > > > > > pip3 install dtschema --upgrade > > > > > > Please check and re-submit. > > > > > > I have updated the dtschema (2021.7) and still not seeing these > > errors. I will fix the errors mentioned in this log though. > > Is there any other flag/setting, which is to be enabled ? > > > > I have dtschema-2021.10 installed. Thanks Stephen. Yes, my dtschema, for some reason, was not getting updated. After upgrading it to 2021.10, I was able to see the same errors. I will send out the next patchset with these errors fixed. Thanks, Rakesh Pillai.
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml new file mode 100644 index 0000000..bb62760 --- /dev/null +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml @@ -0,0 +1,196 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/remoteproc/qcom,sc7280-wpss-pil.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm SC7280 WPSS Peripheral Image Loader + +maintainers: + - Bjorn Andersson <bjorn.andersson@linaro.org> + +description: + This document defines the binding for a component that loads and boots firmware + on the Qualcomm Technology Inc. WPSS. + +properties: + compatible: + enum: + - qcom,sc7280-wpss-pil + + reg: + maxItems: 1 + description: + The base address and size of the qdsp6ss register + + interrupts: + minItems: 6 + items: + - description: Watchdog interrupt + - description: Fatal interrupt + - description: Ready interrupt + - description: Handover interrupt + - description: Stop acknowledge interrupt + - description: Shutdown acknowledge interrupt + + interrupt-names: + minItems: 6 + items: + - const: wdog + - const: fatal + - const: ready + - const: handover + - const: stop-ack + - const: shutdown-ack + + clocks: + minItems: 4 + items: + - description: GCC WPSS AHB BDG Master clock + - description: GCC WPSS AHB clock + - description: GCC WPSS RSCP clock + - description: XO clock + + clock-names: + minItems: 4 + items: + - const: ahb_bdg + - const: ahb + - const: rscp + - const: xo + + power-domains: + minItems: 2 + items: + - description: CX power domain + - description: MX power domain + + power-domain-names: + minItems: 2 + items: + - const: cx + - const: mx + + resets: + minItems: 2 + items: + - description: AOSS restart + - description: PDC SYNC + + reset-names: + minItems: 2 + items: + - const: restart + - const: pdc_sync + + memory-region: + maxItems: 1 + description: Reference to the reserved-memory for the Hexagon core + + qcom,halt-regs: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: + Phandle reference to a syscon representing TCSR followed by the + three offsets within syscon for q6, modem and nc halt registers. + + qcom,qmp: + $ref: /schemas/types.yaml#/definitions/phandle + description: Reference to the AOSS side-channel message RAM. + + qcom,smem-states: + $ref: /schemas/types.yaml#/definitions/phandle-array + description: States used by the AP to signal the Hexagon core + items: + - description: Stop the modem + + qcom,smem-state-names: + $ref: /schemas/types.yaml#/definitions/string-array + description: The names of the state bits used for SMP2P output + items: + - const: stop + + glink-edge: + type: object + description: + Qualcomm G-Link subnode which represents communication edge, channels + and devices related to the ADSP. + +required: + - compatible + - reg + - interrupts-extended + - interrupt-names + - clocks + - clock-names + - power-domains + - power-domain-names + - reset + - reset-names + - qcom,halt-regs + - memory-region + - qcom,qmp + - qcom,smem-states + - qcom,smem-state-names + - glink-edge + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/qcom,gcc-sc7280.h> + #include <dt-bindings/clock/qcom,rpmh.h> + #include <dt-bindings/power/qcom-rpmpd.h> + #include <dt-bindings/reset/qcom,sdm845-aoss.h> + #include <dt-bindings/reset/qcom,sdm845-pdc.h> + #include <dt-bindings/mailbox/qcom-ipcc.h> + remoteproc@8a00000 { + compatible = "qcom,sc7280-wpss-pil"; + reg = <0x08a00000 0x10000>; + + interrupts-extended = <&intc GIC_SPI 587 IRQ_TYPE_EDGE_RISING>, + <&wpss_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, + <&wpss_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, + <&wpss_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, + <&wpss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>, + <&wpss_smp2p_in 7 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "wdog", "fatal", "ready", "handover", + "stop-ack", "shutdown-ack"; + + clocks = <&gcc GCC_WPSS_AHB_BDG_MST_CLK>, + <&gcc GCC_WPSS_AHB_CLK>, + <&gcc GCC_WPSS_RSCP_CLK>, + <&rpmhcc RPMH_CXO_CLK>; + clock-names = "ahb_bdg", "ahb", + "rscp", "xo"; + + power-domains = <&rpmhpd SC7280_CX>, + <&rpmhpd SC7280_MX>; + power-domain-names = "cx", "mx"; + + memory-region = <&wpss_mem>; + + qcom,qmp = <&aoss_qmp>; + + qcom,smem-states = <&wpss_smp2p_out 0>; + qcom,smem-state-names = "stop"; + + resets = <&aoss_reset AOSS_CC_WCSS_RESTART>, + <&pdc_reset PDC_WPSS_SYNC_RESET>; + reset-names = "restart", "pdc_sync"; + + qcom,halt-regs = <&tcsr_mutex 0x37000>; + + status = "disabled"; + + glink-edge { + interrupts-extended = <&ipcc IPCC_CLIENT_WPSS + IPCC_MPROC_SIGNAL_GLINK_QMP + IRQ_TYPE_EDGE_RISING>; + mboxes = <&ipcc IPCC_CLIENT_WPSS + IPCC_MPROC_SIGNAL_GLINK_QMP>; + + label = "wpss"; + qcom,remote-pid = <13>; + }; + };
Add WPSS PIL loading support for SC7280 SoCs. Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> --- .../bindings/remoteproc/qcom,sc7280-wpss-pil.yaml | 196 +++++++++++++++++++++ 1 file changed, 196 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sc7280-wpss-pil.yaml