| Message ID | 1633330133-29617-1-git-send-email-pillair@codeaurora.org |
|---|---|
| Headers | show |
| Series | Add support for sc7280 WPSS PIL loading | expand |
Quoting Rakesh Pillai (2021-10-03 23:48:53) > Add support for PIL loading of WPSS processor for SC7280 > - WPSS boot will be requested by the wifi driver and hence > disable auto-boot for WPSS. > - Add a separate shutdown sequence handler for WPSS. > - Add multiple power-domain voting support > > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> This changed? Please don't keep reviewed-by if things changed significantly. > diff --git a/drivers/remoteproc/qcom_q6v5_adsp.c b/drivers/remoteproc/qcom_q6v5_adsp.c > index 098362e6..b6d3c3d 100644 > --- a/drivers/remoteproc/qcom_q6v5_adsp.c > +++ b/drivers/remoteproc/qcom_q6v5_adsp.c > @@ -531,15 +685,40 @@ static const struct adsp_pil_data cdsp_resource_init = { > .ssr_name = "cdsp", > .sysmon_name = "cdsp", > .ssctl_id = 0x17, > + .is_wpss = false, > + .auto_boot = true, > .clk_ids = (const char*[]) { > "sway", "tbu", "bimc", "ahb_aon", "q6ss_slave", "q6ss_master", > "q6_axim", NULL > }, > .num_clks = 7, > + .proxy_pd_names = (const char*[]) { > + "cx", NULL > + }, > +}; > + > +static const struct adsp_pil_data wpss_resource_init = { > + .crash_reason_smem = 626, > + .firmware_name = "wpss.mdt", > + .ssr_name = "wpss", > + .sysmon_name = "wpss", > + .ssctl_id = 0x19, > + .is_wpss = true, > + .auto_boot = false, > + .load_state = "wpss", > + .clk_ids = (const char*[]) { > + "gcc_wpss_ahb_bdg_mst_clk", "gcc_wpss_ahb_clk", > + "gcc_wpss_rscp_clk", NULL Please remove "gcc_wpss_" prefix and "_clk" postfix. Does that make this match the binding? > + }, > + .num_clks = 3, > + .proxy_pd_names = (const char*[]) { > + "cx", "mx", NULL > + }, > }; >
Quoting Rakesh Pillai (2021-10-03 23:48:50) > Add support for PIL loading of WPSS co-processor for SC7280 SOCs. > > Changes from v4/v5: > - Add yaml conversion for adsp/cdsp dt-bindings > - Change clock names in wpss dt-bindings > - Correct mistake in signed-off enail ID Can you keep a running tally here of the full progression of the series? That helps to look back and make sure we don't make a comment that has already been made before. One more request. Can you add support for 'firmware-name' like there is in Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt so that we can install firmware into some namespaced/versioned place instead of having to put wpss files into /lib/firmware? It would also be nice to load a single firmware file instead of having to split the file into many pieces. > > Rakesh Pillai (3): > dt-bindings: remoteproc: qcom: adsp: Convert binding to YAML > dt-bindings: remoteproc: qcom: Add SC7280 WPSS support > remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS >
> -----Original Message----- > From: Stephen Boyd <swboyd@chromium.org> > Sent: Friday, October 8, 2021 12:05 AM > To: Rakesh Pillai <pillair@codeaurora.org>; agross@kernel.org; > bjorn.andersson@linaro.org; mathieu.poirier@linaro.org; ohad@wizery.com; > p.zabel@pengutronix.de; robh+dt@kernel.org > Cc: linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; sibis@codeaurora.org; mpubbise@codeaurora.org; > kuabhs@chromium.org > Subject: Re: [PATCH v6 0/3] Add support for sc7280 WPSS PIL loading > > Quoting Rakesh Pillai (2021-10-03 23:48:50) > > Add support for PIL loading of WPSS co-processor for SC7280 SOCs. > > > > Changes from v4/v5: > > - Add yaml conversion for adsp/cdsp dt-bindings > > - Change clock names in wpss dt-bindings > > - Correct mistake in signed-off enail ID > > Can you keep a running tally here of the full progression of the series? > That helps to look back and make sure we don't make a comment that has > already been made before. > > One more request. Can you add support for 'firmware-name' like there is in > Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt so that we > can install firmware into some namespaced/versioned place instead of > having to put wpss files into /lib/firmware? Hi Stephen, I have posted v7 with the support for firmware-name to be provided in the DT entry. > It would also be nice to load a > single firmware file instead of having to split the file into many pieces. This would require lot of changes and lot of code duplication from request firmware. Also the base ath11k firmware files have been posted as split files. Thanks, Rakesh Pillai
Quoting pillair@codeaurora.org (2021-10-28 06:08:39) > > > > -----Original Message----- > > From: Stephen Boyd <swboyd@chromium.org> > > Sent: Friday, October 8, 2021 12:05 AM > > To: Rakesh Pillai <pillair@codeaurora.org>; agross@kernel.org; > > bjorn.andersson@linaro.org; mathieu.poirier@linaro.org; ohad@wizery.com; > > p.zabel@pengutronix.de; robh+dt@kernel.org > > Cc: linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; linux- > > kernel@vger.kernel.org; sibis@codeaurora.org; mpubbise@codeaurora.org; > > kuabhs@chromium.org > > Subject: Re: [PATCH v6 0/3] Add support for sc7280 WPSS PIL loading > > > > Quoting Rakesh Pillai (2021-10-03 23:48:50) > > > Add support for PIL loading of WPSS co-processor for SC7280 SOCs. > > > > > > Changes from v4/v5: > > > - Add yaml conversion for adsp/cdsp dt-bindings > > > - Change clock names in wpss dt-bindings > > > - Correct mistake in signed-off enail ID > > > > Can you keep a running tally here of the full progression of the series? > > That helps to look back and make sure we don't make a comment that has > > already been made before. > > > > One more request. Can you add support for 'firmware-name' like there is in > > Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt so that we > > can install firmware into some namespaced/versioned place instead of > > having to put wpss files into /lib/firmware? > > Hi Stephen, > I have posted v7 with the support for firmware-name to be provided in the DT entry. Thanks. I didn't see it in my inbox. No Cc for me? > > > It would also be nice to load a > > single firmware file instead of having to split the file into many pieces. > > This would require lot of changes and lot of code duplication from request firmware. > Also the base ath11k firmware files have been posted as split files. > Other firmwares have done it so it seems technically possible. So nothing is preventing it?
> -----Original Message----- > From: Stephen Boyd <swboyd@chromium.org> > Sent: Friday, October 29, 2021 3:32 AM > To: agross@kernel.org; bjorn.andersson@linaro.org; > mathieu.poirier@linaro.org; ohad@wizery.com; p.zabel@pengutronix.de; > pillair@codeaurora.org; robh+dt@kernel.org > Cc: linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; sibis@codeaurora.org; mpubbise@codeaurora.org; > kuabhs@chromium.org > Subject: RE: [PATCH v6 0/3] Add support for sc7280 WPSS PIL loading > > Quoting pillair@codeaurora.org (2021-10-28 06:08:39) > > > > > > > -----Original Message----- > > > From: Stephen Boyd <swboyd@chromium.org> > > > Sent: Friday, October 8, 2021 12:05 AM > > > To: Rakesh Pillai <pillair@codeaurora.org>; agross@kernel.org; > > > bjorn.andersson@linaro.org; mathieu.poirier@linaro.org; > > > ohad@wizery.com; p.zabel@pengutronix.de; robh+dt@kernel.org > > > Cc: linux-arm-msm@vger.kernel.org; devicetree@vger.kernel.org; > > > linux- kernel@vger.kernel.org; sibis@codeaurora.org; > > > mpubbise@codeaurora.org; kuabhs@chromium.org > > > Subject: Re: [PATCH v6 0/3] Add support for sc7280 WPSS PIL loading > > > > > > Quoting Rakesh Pillai (2021-10-03 23:48:50) > > > > Add support for PIL loading of WPSS co-processor for SC7280 SOCs. > > > > > > > > Changes from v4/v5: > > > > - Add yaml conversion for adsp/cdsp dt-bindings > > > > - Change clock names in wpss dt-bindings > > > > - Correct mistake in signed-off enail ID > > > > > > Can you keep a running tally here of the full progression of the series? > > > That helps to look back and make sure we don't make a comment that > > > has already been made before. > > > > > > One more request. Can you add support for 'firmware-name' like there > > > is in Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt so > > > that we can install firmware into some namespaced/versioned place > > > instead of having to put wpss files into /lib/firmware? > > > > Hi Stephen, > > I have posted v7 with the support for firmware-name to be provided in the > DT entry. > > Thanks. I didn't see it in my inbox. No Cc for me? > > > > > > It would also be nice to load a > > > single firmware file instead of having to split the file into many pieces. > > > > This would require lot of changes and lot of code duplication from request > firmware. > > Also the base ath11k firmware files have been posted as split files. > > > > Other firmwares have done it so it seems technically possible. So nothing is > preventing it? Yes it should be possible. I can probably add that support and post it as a different patch series, so as to not club it with the current patch series. Does that sound okay ? Thanks, Rakesh Pillai.
Quoting pillair@codeaurora.org (2021-10-28 23:21:49) > > > > Other firmwares have done it so it seems technically possible. So nothing is > > preventing it? > > Yes it should be possible. > I can probably add that support and post it as a different patch series, so as to > not club it with the current patch series. Does that sound okay ? > Yes