| Message ID | 20210705154849.2083972-6-sjg@chromium.org |
|---|---|
| State | Superseded |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | tpm: Enhance sandbox tpm2 emulation | expand |
On Mon, Jul 05, 2021 at 09:48:45AM -0600, Simon Glass wrote: > Tidy up the missing comments for this struct. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > drivers/tpm/tpm2_tis_sandbox.c | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/drivers/tpm/tpm2_tis_sandbox.c b/drivers/tpm/tpm2_tis_sandbox.c > index 24c804a5645..5e0bd304699 100644 > --- a/drivers/tpm/tpm2_tis_sandbox.c > +++ b/drivers/tpm/tpm2_tis_sandbox.c > @@ -45,19 +45,31 @@ static const u8 sandbox_extended_once_pcr[] = { > 0xea, 0x98, 0x31, 0xa9, 0x27, 0x59, 0xfb, 0x4b, > }; > > +/* > + * Information about our TPM emulation. This is preserved in the sandbox > + * state file if enabled. > + * > + * @init_done: true if open() has been called > + * @startup_done: true if TPM2_CC_STARTUP has been processed > + * @tests_done: true if TPM2_CC_SELF_TEST has be processed > + * @pw: TPM password per hierarchy > + * @pw_sz: Size of each password in bytes > + * @properties: TPM properties > + * @pcr: TPM Platform Configuration Registers. Each of these holds a hash and > + * can be 'extended' a number of times, meaning another hash is added into > + * its value (initial value all zeroes) > + * @pcr_extensions: Number of times each PCR has been extended (starts at 0) > + * @nvdata: non-volatile data, used to store important things for the platform > + */ > struct sandbox_tpm2 { > /* TPM internal states */ > bool init_done; > bool startup_done; > bool tests_done; > - /* TPM password per hierarchy */ > char pw[TPM2_HIERARCHY_NB][TPM2_DIGEST_LEN + 1]; > int pw_sz[TPM2_HIERARCHY_NB]; > - /* TPM properties */ > u32 properties[TPM2_PROPERTY_NB]; > - /* TPM PCRs */ > u8 pcr[SANDBOX_TPM_PCR_NB][TPM2_DIGEST_LEN]; > - /* TPM PCR extensions */ > u32 pcr_extensions[SANDBOX_TPM_PCR_NB]; > }; > > -- > 2.32.0.93.g670b81a890-goog > Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff --git a/drivers/tpm/tpm2_tis_sandbox.c b/drivers/tpm/tpm2_tis_sandbox.c index 24c804a5645..5e0bd304699 100644 --- a/drivers/tpm/tpm2_tis_sandbox.c +++ b/drivers/tpm/tpm2_tis_sandbox.c @@ -45,19 +45,31 @@ static const u8 sandbox_extended_once_pcr[] = { 0xea, 0x98, 0x31, 0xa9, 0x27, 0x59, 0xfb, 0x4b, }; +/* + * Information about our TPM emulation. This is preserved in the sandbox + * state file if enabled. + * + * @init_done: true if open() has been called + * @startup_done: true if TPM2_CC_STARTUP has been processed + * @tests_done: true if TPM2_CC_SELF_TEST has be processed + * @pw: TPM password per hierarchy + * @pw_sz: Size of each password in bytes + * @properties: TPM properties + * @pcr: TPM Platform Configuration Registers. Each of these holds a hash and + * can be 'extended' a number of times, meaning another hash is added into + * its value (initial value all zeroes) + * @pcr_extensions: Number of times each PCR has been extended (starts at 0) + * @nvdata: non-volatile data, used to store important things for the platform + */ struct sandbox_tpm2 { /* TPM internal states */ bool init_done; bool startup_done; bool tests_done; - /* TPM password per hierarchy */ char pw[TPM2_HIERARCHY_NB][TPM2_DIGEST_LEN + 1]; int pw_sz[TPM2_HIERARCHY_NB]; - /* TPM properties */ u32 properties[TPM2_PROPERTY_NB]; - /* TPM PCRs */ u8 pcr[SANDBOX_TPM_PCR_NB][TPM2_DIGEST_LEN]; - /* TPM PCR extensions */ u32 pcr_extensions[SANDBOX_TPM_PCR_NB]; };
Tidy up the missing comments for this struct. Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/tpm/tpm2_tis_sandbox.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-)