| Message ID | 20210204022415.20589-6-trini@konsulko.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [01/13] arm: nanopi2: Remove unused code | expand |
Hi Tom, On 2/4/21 11:24 AM, Tom Rini wrote: > Rather than provide an empty revision tag here, remove the code to > generate an empty one and disable the feature. > > Cc: Robert Baldyga <r.baldyga@samsung.com> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > I do not know if this platform ever had to support an ATAG-based Linux > kernel and if not, there is more cleanup that could be done here. Sorry for late because of holidays. I will check whether it's ATAG-based Linux kernel or not. Best Regards, Jaehoon Chung > --- > board/samsung/goni/goni.c | 5 ----- > include/configs/s5p_goni.h | 1 - > 2 files changed, 6 deletions(-) > > diff --git a/board/samsung/goni/goni.c b/board/samsung/goni/goni.c > index 2f0ef22c4171..d13347c93ff5 100644 > --- a/board/samsung/goni/goni.c > +++ b/board/samsung/goni/goni.c > @@ -23,11 +23,6 @@ > > DECLARE_GLOBAL_DATA_PTR; > > -u32 get_board_rev(void) > -{ > - return 0; > -} > - > int board_init(void) > { > /* Set Initial global variables */ > diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h > index 9688bdc4c035..ca9edaa43855 100644 > --- a/include/configs/s5p_goni.h > +++ b/include/configs/s5p_goni.h > @@ -28,7 +28,6 @@ > > #define CONFIG_SETUP_MEMORY_TAGS > #define CONFIG_CMDLINE_TAG > -#define CONFIG_REVISION_TAG > #define CONFIG_INITRD_TAG > > /* Size of malloc() pool before and after relocation */ >
diff --git a/board/samsung/goni/goni.c b/board/samsung/goni/goni.c index 2f0ef22c4171..d13347c93ff5 100644 --- a/board/samsung/goni/goni.c +++ b/board/samsung/goni/goni.c @@ -23,11 +23,6 @@ DECLARE_GLOBAL_DATA_PTR; -u32 get_board_rev(void) -{ - return 0; -} - int board_init(void) { /* Set Initial global variables */ diff --git a/include/configs/s5p_goni.h b/include/configs/s5p_goni.h index 9688bdc4c035..ca9edaa43855 100644 --- a/include/configs/s5p_goni.h +++ b/include/configs/s5p_goni.h @@ -28,7 +28,6 @@ #define CONFIG_SETUP_MEMORY_TAGS #define CONFIG_CMDLINE_TAG -#define CONFIG_REVISION_TAG #define CONFIG_INITRD_TAG /* Size of malloc() pool before and after relocation */
Rather than provide an empty revision tag here, remove the code to generate an empty one and disable the feature. Cc: Robert Baldyga <r.baldyga@samsung.com> Signed-off-by: Tom Rini <trini@konsulko.com> --- I do not know if this platform ever had to support an ATAG-based Linux kernel and if not, there is more cleanup that could be done here. --- board/samsung/goni/goni.c | 5 ----- include/configs/s5p_goni.h | 1 - 2 files changed, 6 deletions(-)