diff mbox series

[3/6] riscv: load addresses for Sipeed MAIX

Message ID 20200729154235.90766-4-xypron.glpk@gmx.de
State Superseded, archived
Headers show
Series efi_selftest: allow UEFI testing on MAIX | expand

Commit Message

Heinrich Schuchardt July 29, 2020, 3:42 p.m. UTC
Define default load addresses and the device tree name for the Sipeed MAIX.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 include/configs/sipeed-maix.h | 9 +++++++++
 1 file changed, 9 insertions(+)

--
2.27.0

Comments

Heinrich Schuchardt Aug. 1, 2020, 10:04 a.m. UTC | #1
On 7/29/20 5:42 PM, Heinrich Schuchardt wrote:
> Define default load addresses and the device tree name for the Sipeed MAIX.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  include/configs/sipeed-maix.h | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/include/configs/sipeed-maix.h b/include/configs/sipeed-maix.h
> index a46473fc78..978db6fb00 100644
> --- a/include/configs/sipeed-maix.h
> +++ b/include/configs/sipeed-maix.h
> @@ -21,4 +21,13 @@
>  /* For early init */
>  #define K210_SYSCTL_BASE 0x50440000
>
> +#ifndef CONFIG_EXTRA_ENV_SETTINGS
> +#define CONFIG_EXTRA_ENV_SETTINGS \
> +	"loadaddr=0x80040000\0" \
> +	"fdt_addr_r=0x80010000\0" \
> +	"scriptaddr=0x80008000\0" \
> +	"kernel_addr_r=0x80040000\0" \
> +	"fdtfile=kendryte/" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0"
> +#endif
> +
>  #endif /* CONFIGS_SIPEED_MAIX_H */
> --
> 2.27.0
>

Probably we should choose the addresses here higher to allow for
OpenSBI. I am still trying to make OpenSBI load U-Boot on the board.

Best regards

Heinrich
Rick Chen Aug. 6, 2020, 7:07 a.m. UTC | #2
> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Heinrich Schuchardt
> Sent: Wednesday, July 29, 2020 11:43 PM
> To: Sean Anderson
> Cc: Michal Simek; Tom Rini; Simon Glass; Bin Meng; Alexander Graf; u-boot@lists.denx.de; Heinrich Schuchardt
> Subject: [PATCH 3/6] riscv: load addresses for Sipeed MAIX
>
> Define default load addresses and the device tree name for the Sipeed MAIX.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  include/configs/sipeed-maix.h | 9 +++++++++
>  1 file changed, 9 insertions(+)

Acked-by: Rick Chen <rick@andestech.com>
Heinrich Schuchardt Aug. 7, 2020, 5:50 p.m. UTC | #3
On 8/6/20 9:07 AM, Rick Chen wrote:
>> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Heinrich Schuchardt
>> Sent: Wednesday, July 29, 2020 11:43 PM
>> To: Sean Anderson
>> Cc: Michal Simek; Tom Rini; Simon Glass; Bin Meng; Alexander Graf; u-boot@lists.denx.de; Heinrich Schuchardt
>> Subject: [PATCH 3/6] riscv: load addresses for Sipeed MAIX
>>
>> Define default load addresses and the device tree name for the Sipeed MAIX.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>>  include/configs/sipeed-maix.h | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>
> Acked-by: Rick Chen <rick@andestech.com>
>

Thanks for reviewing.

I have reassigned the patch to you in patchwork. The rest of the series
was already merged via the last EFI pull request.

Best regards

Heinrich
Rick Chen Aug. 12, 2020, 7:09 a.m. UTC | #4
Hi Heinrich

> On 8/6/20 9:07 AM, Rick Chen wrote:
> >> From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Heinrich Schuchardt
> >> Sent: Wednesday, July 29, 2020 11:43 PM
> >> To: Sean Anderson
> >> Cc: Michal Simek; Tom Rini; Simon Glass; Bin Meng; Alexander Graf; u-boot@lists.denx.de; Heinrich Schuchardt
> >> Subject: [PATCH 3/6] riscv: load addresses for Sipeed MAIX
> >>
> >> Define default load addresses and the device tree name for the Sipeed MAIX.
> >>
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >> ---
> >>  include/configs/sipeed-maix.h | 9 +++++++++
> >>  1 file changed, 9 insertions(+)
> >
> > Acked-by: Rick Chen <rick@andestech.com>
> >
>
> Thanks for reviewing.
>
> I have reassigned the patch to you in patchwork. The rest of the series
> was already merged via the last EFI pull request.

It is better to be pulled with the whole patch series together via EFI tree.
Because the title of this patch sets is [PATCH 0/6] efi_selftest:
allow UEFI testing on MAIX.

And you said that you still try the address for OpenSBI in previous mail.

Thanks,
Rick

>
> Best regards
>
> Heinrich
diff mbox series

Patch

diff --git a/include/configs/sipeed-maix.h b/include/configs/sipeed-maix.h
index a46473fc78..978db6fb00 100644
--- a/include/configs/sipeed-maix.h
+++ b/include/configs/sipeed-maix.h
@@ -21,4 +21,13 @@ 
 /* For early init */
 #define K210_SYSCTL_BASE 0x50440000

+#ifndef CONFIG_EXTRA_ENV_SETTINGS
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	"loadaddr=0x80040000\0" \
+	"fdt_addr_r=0x80010000\0" \
+	"scriptaddr=0x80008000\0" \
+	"kernel_addr_r=0x80040000\0" \
+	"fdtfile=kendryte/" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0"
+#endif
+
 #endif /* CONFIGS_SIPEED_MAIX_H */