| Message ID | 20200727094543.28484-13-lokeshvutla@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Lokesh Vutla |
| Headers | show |
| Series | arm: mach-k3: Initial support for Texas Instrument's J7200 Platform | expand |
Hi On 27/07/20 3:15 pm, Lokesh Vutla wrote: > j7200-evm has minor differences with j721e-evm based on the IPs > available in the SoC. Introduce separate build targets for j7200-evm > to incorporate the differences. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > --- > board/ti/j721e/Kconfig | 53 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/board/ti/j721e/Kconfig b/board/ti/j721e/Kconfig > index e56dc53bfa..2cbe2b2481 100644 > --- a/board/ti/j721e/Kconfig > +++ b/board/ti/j721e/Kconfig > @@ -27,6 +27,26 @@ config TARGET_J721E_R5_EVM > imply SYS_K3_SPL_ATF > imply TI_I2C_BOARD_DETECT > > +config TARGET_J7200_A72_EVM > + bool "TI K3 based J7200 EVM running on A72" > + select ARM64 > + select SOC_K3_J721E > + select BOARD_LATE_INIT > + imply TI_I2C_BOARD_DETECT > + select SYS_DISABLE_DCACHE_OPS > + I don't see update to: include/configs/j721e_evm.h 23 #ifdef CONFIG_TARGET_J721E_A72_EVM include/configs/j721e_evm.h 130 #ifdef CONFIG_TARGET_J721E_A72_EVM Don't we need to update j721e_evm.h with TARGET_J7200_A72_EVM? Regards Vignesh > +config TARGET_J7200_R5_EVM > + bool "TI K3 based J7200 EVM running on R5" > + select CPU_V7R > + select SYS_THUMB_BUILD > + select SOC_K3_J721E > + select K3_LOAD_SYSFW > + select RAM > + select SPL_RAM > + select K3_J721E_DDRSS > + imply SYS_K3_SPL_ATF > + imply TI_I2C_BOARD_DETECT > + > endchoice > > if TARGET_J721E_A72_EVM > @@ -61,3 +81,36 @@ config SPL_LDSCRIPT > source "board/ti/common/Kconfig" > > endif > + > +if TARGET_J7200_A72_EVM > + > +config SYS_BOARD > + default "j721e" > + > +config SYS_VENDOR > + default "ti" > + > +config SYS_CONFIG_NAME > + default "j721e_evm" > + > +source "board/ti/common/Kconfig" > + > +endif > + > +if TARGET_J7200_R5_EVM > + > +config SYS_BOARD > + default "j721e" > + > +config SYS_VENDOR > + default "ti" > + > +config SYS_CONFIG_NAME > + default "j721e_evm" > + > +config SPL_LDSCRIPT > + default "arch/arm/mach-omap2/u-boot-spl.lds" > + > +source "board/ti/common/Kconfig" > + > +endif >
On 05/08/20 2:20 pm, Vignesh Raghavendra wrote: > Hi > > On 27/07/20 3:15 pm, Lokesh Vutla wrote: >> j7200-evm has minor differences with j721e-evm based on the IPs >> available in the SoC. Introduce separate build targets for j7200-evm >> to incorporate the differences. >> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> >> --- >> board/ti/j721e/Kconfig | 53 ++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 53 insertions(+) >> >> diff --git a/board/ti/j721e/Kconfig b/board/ti/j721e/Kconfig >> index e56dc53bfa..2cbe2b2481 100644 >> --- a/board/ti/j721e/Kconfig >> +++ b/board/ti/j721e/Kconfig >> @@ -27,6 +27,26 @@ config TARGET_J721E_R5_EVM >> imply SYS_K3_SPL_ATF >> imply TI_I2C_BOARD_DETECT >> >> +config TARGET_J7200_A72_EVM >> + bool "TI K3 based J7200 EVM running on A72" >> + select ARM64 >> + select SOC_K3_J721E >> + select BOARD_LATE_INIT >> + imply TI_I2C_BOARD_DETECT >> + select SYS_DISABLE_DCACHE_OPS >> + > > I don't see update to: > > include/configs/j721e_evm.h 23 #ifdef CONFIG_TARGET_J721E_A72_EVM > include/configs/j721e_evm.h 130 #ifdef CONFIG_TARGET_J721E_A72_EVM > > Don't we need to update j721e_evm.h with TARGET_J7200_A72_EVM? You are right. Will fix in v2. Thanks and regards, Lokesh
diff --git a/board/ti/j721e/Kconfig b/board/ti/j721e/Kconfig index e56dc53bfa..2cbe2b2481 100644 --- a/board/ti/j721e/Kconfig +++ b/board/ti/j721e/Kconfig @@ -27,6 +27,26 @@ config TARGET_J721E_R5_EVM imply SYS_K3_SPL_ATF imply TI_I2C_BOARD_DETECT +config TARGET_J7200_A72_EVM + bool "TI K3 based J7200 EVM running on A72" + select ARM64 + select SOC_K3_J721E + select BOARD_LATE_INIT + imply TI_I2C_BOARD_DETECT + select SYS_DISABLE_DCACHE_OPS + +config TARGET_J7200_R5_EVM + bool "TI K3 based J7200 EVM running on R5" + select CPU_V7R + select SYS_THUMB_BUILD + select SOC_K3_J721E + select K3_LOAD_SYSFW + select RAM + select SPL_RAM + select K3_J721E_DDRSS + imply SYS_K3_SPL_ATF + imply TI_I2C_BOARD_DETECT + endchoice if TARGET_J721E_A72_EVM @@ -61,3 +81,36 @@ config SPL_LDSCRIPT source "board/ti/common/Kconfig" endif + +if TARGET_J7200_A72_EVM + +config SYS_BOARD + default "j721e" + +config SYS_VENDOR + default "ti" + +config SYS_CONFIG_NAME + default "j721e_evm" + +source "board/ti/common/Kconfig" + +endif + +if TARGET_J7200_R5_EVM + +config SYS_BOARD + default "j721e" + +config SYS_VENDOR + default "ti" + +config SYS_CONFIG_NAME + default "j721e_evm" + +config SPL_LDSCRIPT + default "arch/arm/mach-omap2/u-boot-spl.lds" + +source "board/ti/common/Kconfig" + +endif
j7200-evm has minor differences with j721e-evm based on the IPs available in the SoC. Introduce separate build targets for j7200-evm to incorporate the differences. Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> --- board/ti/j721e/Kconfig | 53 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+)