| Message ID | 20191204235430.6517-1-trini@konsulko.com |
|---|---|
| State | Accepted |
| Commit | fb013eee68d08403572ef3c579f6688bbe33fd47 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Makefile: Ensure tools directory exists in output prior to use | expand |
On Thu, Dec 5, 2019 at 7:54 AM Tom Rini <trini@konsulko.com> wrote: > > With the change to make tools/version.h a file we need to make sure that > the output directory exists first otherwise we will get a build failure. > > Reported-by: Peter Robinson <pbrobinson@gmail.com> > Tested-by: Peter Robinson <pbrobinson@gmail.com> > Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for tools/version.h") > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > Makefile | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Wed, 4 Dec 2019 at 16:54, Tom Rini <trini@konsulko.com> wrote: > > With the change to make tools/version.h a file we need to make sure that > the output directory exists first otherwise we will get a build failure. > > Reported-by: Peter Robinson <pbrobinson@gmail.com> > Tested-by: Peter Robinson <pbrobinson@gmail.com> > Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for tools/version.h") > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > Makefile | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass <sjg@chromium.org>
On Wed, Dec 04, 2019 at 06:54:30PM -0500, Tom Rini wrote: > With the change to make tools/version.h a file we need to make sure that > the output directory exists first otherwise we will get a build failure. > > Reported-by: Peter Robinson <pbrobinson@gmail.com> > Tested-by: Peter Robinson <pbrobinson@gmail.com> > Fixes: 4d90f6cd9813 ("tools: Avoid creating symbolic links for tools/version.h") > Signed-off-by: Tom Rini <trini@konsulko.com> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/Makefile b/Makefile index 0ee0c701022a..960926caad45 100644 --- a/Makefile +++ b/Makefile @@ -1889,6 +1889,7 @@ checkarmreloc: u-boot fi tools/version.h: include/version.h + $(Q)mkdir -p $(dir $@) $(call if_changed,copy) envtools: scripts_basic $(version_h) $(timestamp_h) tools/version.h