| Message ID | 1436109227-10790-2-git-send-email-albert.u.boot@aribaud.net |
|---|---|
| State | Accepted |
| Delegated to: | Albert ARIBAUD |
| Headers | show |
On Sun, 5 Jul 2015 17:13:44 +0200, Albert ARIBAUD
<albert.u.boot@aribaud.net> wrote:
> This target is ARMv7
Argh! This target is *ARMv7-R* -- will fix when applying.
Amicalement,
2015-07-05 18:33 GMT+02:00 Albert ARIBAUD <albert.u.boot@aribaud.net>: > On Sun, 5 Jul 2015 17:13:44 +0200, Albert ARIBAUD > <albert.u.boot@aribaud.net> wrote: >> This target is ARMv7 > > Argh! This target is *ARMv7-R* -- will fix when applying. > > Amicalement, > -- > Albert. > Albert, Just to make sure - for STM32F429 Discovery the target is ARMv7-M :) /Kamil
Hello Kamil, On Mon, 6 Jul 2015 08:58:36 +0200, Kamil Lulko <rev13@wp.pl> wrote: > 2015-07-05 18:33 GMT+02:00 Albert ARIBAUD <albert.u.boot@aribaud.net>: > > On Sun, 5 Jul 2015 17:13:44 +0200, Albert ARIBAUD > > <albert.u.boot@aribaud.net> wrote: > >> This target is ARMv7 > > > > Argh! This target is *ARMv7-R* -- will fix when applying. > > > > Amicalement, > > -- > > Albert. > > > > Albert, > > Just to make sure - for STM32F429 Discovery the target is ARMv7-M :) Indeed, and that's what I actually meant, but I seem to suffer a curse whereby when I correct my own mistakes, it just gets worse. :) Thanks! > /Kamil Amicalement,
On Sun, 5 Jul 2015 17:13:44 +0200, Albert ARIBAUD <albert.u.boot@aribaud.net> wrote: > This target is ARMv7 therefore can only build for Thumb, > but it did not #define CONFIG_SYS_THUMB_BUILD, so the U-Boot > code did not know it had to build for Thumb(2), not ARM. > > This patch is binary-invariant: builds of stm32f429-discovery > with and without this patch were compared and found to differ > only by their U-Boot version strings. > > Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net> > --- > > Changes in v4: > - Made stm32f429-discovery explicitly state that it builds > for Thumb > > Changes in v3: None > Changes in v2: None > > include/configs/stm32f429-discovery.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/stm32f429-discovery.h b/include/configs/stm32f429-discovery.h > index 46869dd..e2583f0 100644 > --- a/include/configs/stm32f429-discovery.h > +++ b/include/configs/stm32f429-discovery.h > @@ -9,6 +9,7 @@ > #define __CONFIG_H > > #define CONFIG_STM32F4 > +#define CONFIG_SYS_THUMB_BUILD > #define CONFIG_STM32F4DISCOVERY > #define CONFIG_SYS_GENERIC_BOARD > > -- > 2.1.0 > Applied to u-boot-arm/master. Amicalement,
diff --git a/include/configs/stm32f429-discovery.h b/include/configs/stm32f429-discovery.h index 46869dd..e2583f0 100644 --- a/include/configs/stm32f429-discovery.h +++ b/include/configs/stm32f429-discovery.h @@ -9,6 +9,7 @@ #define __CONFIG_H #define CONFIG_STM32F4 +#define CONFIG_SYS_THUMB_BUILD #define CONFIG_STM32F4DISCOVERY #define CONFIG_SYS_GENERIC_BOARD
This target is ARMv7 therefore can only build for Thumb, but it did not #define CONFIG_SYS_THUMB_BUILD, so the U-Boot code did not know it had to build for Thumb(2), not ARM. This patch is binary-invariant: builds of stm32f429-discovery with and without this patch were compared and found to differ only by their U-Boot version strings. Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net> --- Changes in v4: - Made stm32f429-discovery explicitly state that it builds for Thumb Changes in v3: None Changes in v2: None include/configs/stm32f429-discovery.h | 1 + 1 file changed, 1 insertion(+)