| Message ID | 20240408033310.1188408-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Avoid creating non-working backlight sysfs knob from ASUS board | expand |
On Mon, Apr 08, 2024 at 11:33:09AM +0800, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/2060422 > > [Impact] > Backlight sysfs knobs created by asus-wmi don't really work, hence > systemd-backlight services are in failed state. > > [Fix] > Ensure the backlight device are really present > > [Test] > With the fix applied, the backlight sysfs knobs are not longer present > under /sys/class/backlight, so there's no more failed systemd-backlight > service. > > [Where problems could occur] > Though highly unlikely, but if there's working device that is created > even when the WMI read is 0xffffffff, the device will be missing. > > Kai-Heng Feng (1): > platform/x86: asus-wmi: Consider device is absent when the read is ~0 > > drivers/platform/x86/asus-wmi.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > -- > 2.34.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Signed-off-by: Thibault Ferrante <thibault.ferrante@canonical.com> On 08-04-2024 05:33, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/2060422 > > [Impact] > Backlight sysfs knobs created by asus-wmi don't really work, hence > systemd-backlight services are in failed state. > > [Fix] > Ensure the backlight device are really present > > [Test] > With the fix applied, the backlight sysfs knobs are not longer present > under /sys/class/backlight, so there's no more failed systemd-backlight > service. > > [Where problems could occur] > Though highly unlikely, but if there's working device that is created > even when the WMI read is 0xffffffff, the device will be missing. > > Kai-Heng Feng (1): > platform/x86: asus-wmi: Consider device is absent when the read is ~0 > > drivers/platform/x86/asus-wmi.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) >
On 08/04/2024 05:33, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/2060422 > > [Impact] > Backlight sysfs knobs created by asus-wmi don't really work, hence > systemd-backlight services are in failed state. > > [Fix] > Ensure the backlight device are really present > > [Test] > With the fix applied, the backlight sysfs knobs are not longer present > under /sys/class/backlight, so there's no more failed systemd-backlight > service. > > [Where problems could occur] > Though highly unlikely, but if there's working device that is created > even when the WMI read is 0xffffffff, the device will be missing. > > Kai-Heng Feng (1): > platform/x86: asus-wmi: Consider device is absent when the read is ~0 > > drivers/platform/x86/asus-wmi.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > Applied to mantic, jammy master-next branches. Thanks!
On 08/04/2024 05:33, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/2060422 > > [Impact] > Backlight sysfs knobs created by asus-wmi don't really work, hence > systemd-backlight services are in failed state. > > [Fix] > Ensure the backlight device are really present > > [Test] > With the fix applied, the backlight sysfs knobs are not longer present > under /sys/class/backlight, so there's no more failed systemd-backlight > service. > > [Where problems could occur] > Though highly unlikely, but if there's working device that is created > even when the WMI read is 0xffffffff, the device will be missing. > > Kai-Heng Feng (1): > platform/x86: asus-wmi: Consider device is absent when the read is ~0 > > drivers/platform/x86/asus-wmi.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > Applied to noble master-next branch. Thanks!