From patchwork Mon Apr 8 03:33:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kai-Heng Feng X-Patchwork-Id: 1920647 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VCZT021nRz1yYf for ; Mon, 8 Apr 2024 13:34:11 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rtfld-0004wy-3l; Mon, 08 Apr 2024 03:33:57 +0000 Received: from smtp-relay-canonical-1.internal ([10.131.114.174] helo=smtp-relay-canonical-1.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rtflb-0004wp-Gh for kernel-team@lists.ubuntu.com; Mon, 08 Apr 2024 03:33:55 +0000 Received: from localhost.localdomain (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id 565483F139 for ; Mon, 8 Apr 2024 03:33:54 +0000 (UTC) From: Kai-Heng Feng To: kernel-team@lists.ubuntu.com Subject: [SRU] [J/M/N] [PATCH 0/1] Avoid creating non-working backlight sysfs knob from ASUS board Date: Mon, 8 Apr 2024 11:33:09 +0800 Message-Id: <20240408033310.1188408-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2060422 [Impact] Backlight sysfs knobs created by asus-wmi don't really work, hence systemd-backlight services are in failed state. [Fix] Ensure the backlight device are really present [Test] With the fix applied, the backlight sysfs knobs are not longer present under /sys/class/backlight, so there's no more failed systemd-backlight service. [Where problems could occur] Though highly unlikely, but if there's working device that is created even when the WMI read is 0xffffffff, the device will be missing. Kai-Heng Feng (1): platform/x86: asus-wmi: Consider device is absent when the read is ~0 drivers/platform/x86/asus-wmi.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) Acked-by: Manuel Diewald Signed-off-by: Thibault Ferrante