| Message ID | 20230524024803.14253-1-witu@nvidia.com |
|---|---|
| Headers | show |
| Series | net: openvswitch: fix race on port output | expand |
On 23/05/24 05:48AM, William Tu wrote: > BugLink: https://bugs.launchpad.net/bugs/2020606 > > fix race on port output > > * Explain the bug(s) > > there is a race condition on port output > > * brief explanation of fixes > > We found that upstream linux has the same issue and fix > commit 066b86787fa3d97b7aefb5ac0a99a22dad2d15f8 > net: openvswitch: fix race on port output > > * How to test > After configuring QoS on BF-3: > Disable all priorities > Set priorities [0, 0, 0, 0, 0, 0, 0, 0] > Remove all policies > Remove all traffic classes > Add policy (policy_name=ND_traffic, traffic_type=RDMA, priority=5, port=20000, dscp=None) > Add policy (policy_name=TCP_traffic, traffic_type=TCP, priority=4, port=26000, dscp=None) > Add traffic class two prio TC with prio_list=[5, 4], min_bw=76, algorithm=ETS > Enable QOS on adapter SLOT 5 Port 1 > Restart driver (detach VFs -> restart with devcon -> attach VFs) > > BF-3 sometimes stops responding. need to run it multiple times! > > > Felix Huettner (1): > net: openvswitch: fix race on port output > > net/core/dev.c | 1 + > net/openvswitch/actions.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > -- > 2.34.1 Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
On 5/23/23 8:48 PM, William Tu wrote: > BugLink: https://bugs.launchpad.net/bugs/2020606 > > fix race on port output > > * Explain the bug(s) > > there is a race condition on port output > > * brief explanation of fixes > > We found that upstream linux has the same issue and fix > commit 066b86787fa3d97b7aefb5ac0a99a22dad2d15f8 > net: openvswitch: fix race on port output > > * How to test > After configuring QoS on BF-3: > Disable all priorities > Set priorities [0, 0, 0, 0, 0, 0, 0, 0] > Remove all policies > Remove all traffic classes > Add policy (policy_name=ND_traffic, traffic_type=RDMA, priority=5, port=20000, dscp=None) > Add policy (policy_name=TCP_traffic, traffic_type=TCP, priority=4, port=26000, dscp=None) > Add traffic class two prio TC with prio_list=[5, 4], min_bw=76, algorithm=ETS > Enable QOS on adapter SLOT 5 Port 1 > Restart driver (detach VFs -> restart with devcon -> attach VFs) > > BF-3 sometimes stops responding. need to run it multiple times! > > > Felix Huettner (1): > net: openvswitch: fix race on port output > > net/core/dev.c | 1 + > net/openvswitch/actions.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
Please ignore this version. Focal and Jammy have different DEBUG_NET_WARN_ON_ONCE. I will send v2. From: Tim Gardner <tim.gardner@canonical.com> Date: Wednesday, May 24, 2023 at 5:39 AM To: William Tu <witu@nvidia.com>, kernel-team@lists.ubuntu.com <kernel-team@lists.ubuntu.com> Cc: dann.frazier@canonical.com <dann.frazier@canonical.com>, Paul Blakey <paulb@nvidia.com>, Vladimir Sokolovsky <vlad@nvidia.com>, Bodong Wang <bodong@nvidia.com>, Chris Mi <cmi@nvidia.com> Subject: ACK: [SRU][F, J:linux-bluefield][PATCH 0/1] net: openvswitch: fix race on port output External email: Use caution opening links or attachments On 5/23/23 8:48 PM, William Tu wrote: > BugLink: https://bugs.launchpad.net/bugs/2020606 > > fix race on port output > > * Explain the bug(s) > > there is a race condition on port output > > * brief explanation of fixes > > We found that upstream linux has the same issue and fix > commit 066b86787fa3d97b7aefb5ac0a99a22dad2d15f8 > net: openvswitch: fix race on port output > > * How to test > After configuring QoS on BF-3: > Disable all priorities > Set priorities [0, 0, 0, 0, 0, 0, 0, 0] > Remove all policies > Remove all traffic classes > Add policy (policy_name=ND_traffic, traffic_type=RDMA, priority=5, port=20000, dscp=None) > Add policy (policy_name=TCP_traffic, traffic_type=TCP, priority=4, port=26000, dscp=None) > Add traffic class two prio TC with prio_list=[5, 4], min_bw=76, algorithm=ETS > Enable QOS on adapter SLOT 5 Port 1 > Restart driver (detach VFs -> restart with devcon -> attach VFs) > > BF-3 sometimes stops responding. need to run it multiple times! > > > Felix Huettner (1): > net: openvswitch: fix race on port output > > net/core/dev.c | 1 + > net/openvswitch/actions.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com> -- ----------- Tim Gardner Canonical, Inc
On 5/24/23 9:06 AM, William Tu wrote: > Please ignore this version. Focal and Jammy have different > DEBUG_NET_WARN_ON_ONCE. > > I will send v2. > > *From: *Tim Gardner <tim.gardner@canonical.com> > *Date: *Wednesday, May 24, 2023 at 5:39 AM > *To: *William Tu <witu@nvidia.com>, kernel-team@lists.ubuntu.com > <kernel-team@lists.ubuntu.com> > *Cc: *dann.frazier@canonical.com <dann.frazier@canonical.com>, Paul > Blakey <paulb@nvidia.com>, Vladimir Sokolovsky <vlad@nvidia.com>, Bodong > Wang <bodong@nvidia.com>, Chris Mi <cmi@nvidia.com> > *Subject: *ACK: [SRU][F, J:linux-bluefield][PATCH 0/1] net: openvswitch: > fix race on port output > > External email: Use caution opening links or attachments > > > On 5/23/23 8:48 PM, William Tu wrote: >> BugLink: https://bugs.launchpad.net/bugs/2020606 > <https://bugs.launchpad.net/bugs/2020606> >> >> fix race on port output >> >> * Explain the bug(s) >> >> there is a race condition on port output >> >> * brief explanation of fixes >> >> We found that upstream linux has the same issue and fix >> commit 066b86787fa3d97b7aefb5ac0a99a22dad2d15f8 >> net: openvswitch: fix race on port output >> >> * How to test >> After configuring QoS on BF-3: >> Disable all priorities >> Set priorities [0, 0, 0, 0, 0, 0, 0, 0] >> Remove all policies >> Remove all traffic classes >> Add policy (policy_name=ND_traffic, traffic_type=RDMA, priority=5, port=20000, dscp=None) >> Add policy (policy_name=TCP_traffic, traffic_type=TCP, priority=4, port=26000, dscp=None) >> Add traffic class two prio TC with prio_list=[5, 4], min_bw=76, algorithm=ETS >> Enable QOS on adapter SLOT 5 Port 1 >> Restart driver (detach VFs -> restart with devcon -> attach VFs) >> >> BF-3 sometimes stops responding. need to run it multiple times! >> >> >> Felix Huettner (1): >> net: openvswitch: fix race on port output >> >> net/core/dev.c | 1 + >> net/openvswitch/actions.c | 2 +- >> 2 files changed, 2 insertions(+), 1 deletion(-) >> > Acked-by: Tim Gardner <tim.gardner@canonical.com> > -- > ----------- > Tim Gardner > Canonical, Inc > Tying off this thread.
BugLink: https://bugs.launchpad.net/bugs/2020606 fix race on port output * Explain the bug(s) there is a race condition on port output * brief explanation of fixes We found that upstream linux has the same issue and fix commit 066b86787fa3d97b7aefb5ac0a99a22dad2d15f8 net: openvswitch: fix race on port output * How to test After configuring QoS on BF-3: Disable all priorities Set priorities [0, 0, 0, 0, 0, 0, 0, 0] Remove all policies Remove all traffic classes Add policy (policy_name=ND_traffic, traffic_type=RDMA, priority=5, port=20000, dscp=None) Add policy (policy_name=TCP_traffic, traffic_type=TCP, priority=4, port=26000, dscp=None) Add traffic class two prio TC with prio_list=[5, 4], min_bw=76, algorithm=ETS Enable QOS on adapter SLOT 5 Port 1 Restart driver (detach VFs -> restart with devcon -> attach VFs) BF-3 sometimes stops responding. need to run it multiple times! Felix Huettner (1): net: openvswitch: fix race on port output net/core/dev.c | 1 + net/openvswitch/actions.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)