Message ID | 20230524024803.14253-2-witu@nvidia.com |
---|---|
State | New |
Headers | show
Return-Path: <kernel-team-bounces@lists.ubuntu.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=VZfzXYDt; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4QQwc85CW9z20PY for <incoming@patchwork.ozlabs.org>; Wed, 24 May 2023 12:48:40 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from <kernel-team-bounces@lists.ubuntu.com>) id 1q1eYC-0006Sj-On; Wed, 24 May 2023 02:48:32 +0000 Received: from mail-dm3nam02on2087.outbound.protection.outlook.com ([40.107.95.87] helo=NAM02-DM3-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from <witu@nvidia.com>) id 1q1eYA-0006RU-5i for kernel-team@lists.ubuntu.com; Wed, 24 May 2023 02:48:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nhq0bB1iYkdwHbKInwOz7Izt1O3xOYgTnhFA0nc8SGo+YhXqHfK6O0o5nMGO8prGM+sh9YBHmV8QdtEAlbHDsLh+085HZTyyp+1hibTfROqGBsGXPah0cKWkWSdTZpGRwNxvchbYDy0cXgOL9pQLc99tabQpoLNhsxipStl3fvIZbFZ2PWKcY7PQi3mO1e6VDK4Ljjx8LSgzTK1MrAYOE+ssvJgPqTzt+qQOrubBztlibpjBZ+EwRhQEed4sfWsXEh86b9hluDqdDAWd52is5dOayZkxtnl60urtqdo/o0HCHQdfxoIrHit0SeW/1Xp1wyeA4c8hfr6haqOVNf27KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dEHgSI7TCnRtgfr1vy9gdvUJxapjJUzfJYzj1RnCRHA=; b=KmJ0zoZ9lDo/F8RQApNJ3XiqI8Fju+yGd/cKvySrdHxv6gJO3Rky84ewf1cf681W86KRjIViO8kK81T74TOQ6oAwH9Aslukp0C2qkC1o2zqFmczWCYwSgJqMWvPW434AfTvaycDce3W/04Hp1mhKZnIooRO/dDpHAT0NVtLaM7iRxiKb0ytpgizvkgd8nzHpwclTaiwOe4BPBHbtD+67rW1AO9kpz5CGy6njiAZMjOMkNBlCij3ayfmpLcoJ5W7CLFzCzZTTrB0Hxy186Ltj5U5RDlw6D11k+yAFuz3E/yCCLPVlSsJmAWtZViUiL/HYSmHqy++w3smjzNa8EuPoWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dEHgSI7TCnRtgfr1vy9gdvUJxapjJUzfJYzj1RnCRHA=; b=VZfzXYDt5QN/F0zoFJQB38Hjc4yIARnd30lQjxs+Af5y/P0nypRIY9ctBy7mJ56dyaMh/w00mfyCst/quXXXDJDC5DkqxIrw4Nrq2GslZzwVRRhunkl0FmAFRTWtnA46GwFGgFtxEgN4BLTq2XUE5Lo0N5OY9j4DZR2h36zEtL2Vt5itYGoW+J2hcTuPr0e7viocGWf7jqrk7hvWTrnelje6u4R7JGjb8cJGDKi133CQh8SQ+f2Hfsyh5JynjfAiKuEePgO+ID/oMuVs49GS0QncZyh9DJc+mSGuHLV9VUVxPFoXF3Bb5sv/u0ulM0C7yZVziT31GrQ8mz/HoCCFcw== Received: from BN1PR10CA0028.namprd10.prod.outlook.com (2603:10b6:408:e0::33) by PH7PR12MB9224.namprd12.prod.outlook.com (2603:10b6:510:2e7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Wed, 24 May 2023 02:48:24 +0000 Received: from BN8NAM11FT115.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e0:cafe::d6) by BN1PR10CA0028.outlook.office365.com (2603:10b6:408:e0::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Wed, 24 May 2023 02:48:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT115.mail.protection.outlook.com (10.13.177.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.30 via Frontend Transport; Wed, 24 May 2023 02:48:23 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 23 May 2023 19:48:10 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 23 May 2023 19:48:10 -0700 Received: from mtl123.mtl.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Tue, 23 May 2023 19:48:09 -0700 Received: from sw-mtx-002.mtx.labs.mlnx (sw-mtx-002.mtx.labs.mlnx [10.9.151.106]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 34O2m4O3020163; Wed, 24 May 2023 05:48:06 +0300 From: William Tu <witu@nvidia.com> To: <kernel-team@lists.ubuntu.com> Subject: [SRU][F, J:linux-bluefield][PATCH 1/1] net: openvswitch: fix race on port output Date: Wed, 24 May 2023 05:48:03 +0300 Message-ID: <20230524024803.14253-2-witu@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230524024803.14253-1-witu@nvidia.com> References: <20230524024803.14253-1-witu@nvidia.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT115:EE_|PH7PR12MB9224:EE_ X-MS-Office365-Filtering-Correlation-Id: 67b08fae-893a-4f08-27aa-08db5c0157c1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: By0zD7hr7u2xHM0PUA3IKWIZoJj//cIdjJAauk6dPH1G6dYdNxQ4DddAlK2qaB51yfhyWhwcRNd3bsq4H3osUFEOez8piuy9UAx1z2kLwoIzNI1+ehb+tPowevOxEwaYYlnh+ildhiPyYwxBTSHdbZLP1G3IA3k1TONCZsLk3gFDO0qnx7tNPnB19cUVFKZ6I+NOQ2EBT9EjdH0rd/Sfx/59ZQJg5pdK8ky+td21ddkKPF4wvq2DLdo8fMXhLIf6AoyYr+hDj3nWP9+kVyLGHDqGhOPkjc7WrED/NrXSuddwRWDOl6E/FX4aHbpqf5ZDD1tLWVKl09IOW6SpWvlhH0TCyD7cJzwyd+Twt0lk+smUk49YBy3m6IYt6uz++KeAPkono9FS9rMXiTaqA0IApZx1LZMn5XH7UIlQAxpq9skuUiOnWFwcH0jVdAJbHMvJ522GnL50UXBg3np8sIeTR31sf0+wMXP7LpGNZ/RbPnBeDg7U7eYC2DPrjwVTfo+TUZMa4OsNUaUTvUV3DfzhERv39Eyr1buI+Ai2go5s8wt1FpUxs38mrvjUCAsoMRne41NLwZ4Fs7V7u5S4pJuvXuwWFNdb1RMEfi7N/lwYmngmShryMCjCPuMrO1pL4nc0BYliSUQbvM1LnrkacYDX4vEsnpbqd8cGqrco/ryroeVUv10p/izmPvESvCinskCF2prsZD1V2byYCxfyyyts6xapoy5GQBh5k5xjKUD9TUX4UT2DKuc6eEpXqAYBEuYKF98l/HM88sT2laf045IoMCKafrHBMI78ILa+yXXCCU6yZhgv+PBQZw21RWgGECdJ X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(136003)(39860400002)(376002)(396003)(346002)(451199021)(46966006)(40470700004)(36840700001)(45080400002)(47076005)(86362001)(82740400003)(36860700001)(30864003)(2906002)(2616005)(336012)(478600001)(8676002)(8936002)(6916009)(36756003)(1076003)(4326008)(316002)(5660300002)(40480700001)(54906003)(107886003)(356005)(966005)(6666004)(83380400001)(7636003)(26005)(40460700003)(82310400005)(186003)(70586007)(70206006)(41300700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 02:48:23.8181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 67b08fae-893a-4f08-27aa-08db5c0157c1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT115.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9224 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions <kernel-team.lists.ubuntu.com> List-Unsubscribe: <https://lists.ubuntu.com/mailman/options/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe> List-Archive: <https://lists.ubuntu.com/archives/kernel-team> List-Post: <mailto:kernel-team@lists.ubuntu.com> List-Help: <mailto:kernel-team-request@lists.ubuntu.com?subject=help> List-Subscribe: <https://lists.ubuntu.com/mailman/listinfo/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe> Cc: dann.frazier@canonical.com, paulb@nvidia.com, vlad@nvidia.com, bodong@nvidia.com, cmi@nvidia.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" <kernel-team-bounces@lists.ubuntu.com> |
Series |
net: openvswitch: fix race on port output
|
expand
|
diff --git a/net/core/dev.c b/net/core/dev.c index 88a5b3cc8861..97f7ace43f80 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3176,6 +3176,7 @@ static u16 skb_tx_hash(const struct net_device *dev, } if (skb_rx_queue_recorded(skb)) { + DEBUG_NET_WARN_ON_ONCE(qcount == 0); hash = skb_get_rx_queue(skb); if (hash >= qoffset) hash -= qoffset; diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index aca6e2b599c8..ba0acc171418 100644 --- a/net/openvswitch/actions.c +++ b/net/openvswitch/actions.c @@ -913,7 +913,7 @@ static void do_output(struct datapath *dp, struct sk_buff *skb, int out_port, { struct vport *vport = ovs_vport_rcu(dp, out_port); - if (likely(vport)) { + if (likely(vport && netif_carrier_ok(vport->dev))) { u16 mru = OVS_CB(skb)->mru; u32 cutlen = OVS_CB(skb)->cutlen;