| Message ID | 20210726075608.43981-1-po-hsu.lin@canonical.com |
|---|---|
| Headers | show |
| Series | selftests: timers: rtcpie: skip test if default RTC device does not exist | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 7/26/21 1:56 AM, Po-Hsu Lin wrote: > [Impact] > This test will require /dev/rtc0, the default RTC device, or one > specified by user to run. Since this default RTC is not guaranteed to > exist on all of the devices, so check its existence first, otherwise > skip this test with the kselftest skip code 4. > > Without this patch this test will fail like this on a s390x zVM: > $ selftests: timers: rtcpie > $ /dev/rtc0: No such file or directory > not ok 1 selftests: timers: rtcpie # exit=22 > > We have this test disabled in our test suite with an if check [1], > thus we're not seeing this failure recently. With this patch > applied we can remove that code block later. > > [1] https://kernel.ubuntu.com/git/ubuntu/autotest-client-tests.git/tree/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py#n133 > > [Fix] > * 0d3e5a057992bd selftests: timers: rtcpie: skip test if default RTC > device does not exist > > [Test] > Run this test with patched source tree on a s390x zVM and it will be > skipped correctly: > $ selftests: timers: rtcpie > $ Default RTC /dev/rtc0 does not exist. Test Skipped! > not ok 9 selftests: timers: rtcpie # SKIP > > [Where problems could occur] > If this fix is incorrect we might see it failing again on systems that > without /dev/rtc0 (after removing our local hacks in autotest-client-tests) > > Po-Hsu Lin (1): > selftests: timers: rtcpie: skip test if default RTC device does not > exist > > tools/testing/selftests/timers/rtcpie.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) >
On Mon, Jul 26, 2021 at 03:56:07PM +0800, Po-Hsu Lin wrote: > [Impact] > This test will require /dev/rtc0, the default RTC device, or one > specified by user to run. Since this default RTC is not guaranteed to > exist on all of the devices, so check its existence first, otherwise > skip this test with the kselftest skip code 4. > > Without this patch this test will fail like this on a s390x zVM: > $ selftests: timers: rtcpie > $ /dev/rtc0: No such file or directory > not ok 1 selftests: timers: rtcpie # exit=22 > > We have this test disabled in our test suite with an if check [1], > thus we're not seeing this failure recently. With this patch > applied we can remove that code block later. > > [1] https://kernel.ubuntu.com/git/ubuntu/autotest-client-tests.git/tree/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py#n133 > > [Fix] > * 0d3e5a057992bd selftests: timers: rtcpie: skip test if default RTC > device does not exist > > [Test] > Run this test with patched source tree on a s390x zVM and it will be > skipped correctly: > $ selftests: timers: rtcpie > $ Default RTC /dev/rtc0 does not exist. Test Skipped! > not ok 9 selftests: timers: rtcpie # SKIP > > [Where problems could occur] > If this fix is incorrect we might see it failing again on systems that > without /dev/rtc0 (after removing our local hacks in autotest-client-tests) > > Po-Hsu Lin (1): > selftests: timers: rtcpie: skip test if default RTC device does not > exist Applied to impish/5.13. Thanks, -Andrea
On 26.7.2021 10.56, Po-Hsu Lin wrote: > [Impact] > This test will require /dev/rtc0, the default RTC device, or one > specified by user to run. Since this default RTC is not guaranteed to > exist on all of the devices, so check its existence first, otherwise > skip this test with the kselftest skip code 4. > > Without this patch this test will fail like this on a s390x zVM: > $ selftests: timers: rtcpie > $ /dev/rtc0: No such file or directory > not ok 1 selftests: timers: rtcpie # exit=22 > > We have this test disabled in our test suite with an if check [1], > thus we're not seeing this failure recently. With this patch > applied we can remove that code block later. > > [1] https://kernel.ubuntu.com/git/ubuntu/autotest-client-tests.git/tree/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py#n133 > > [Fix] > * 0d3e5a057992bd selftests: timers: rtcpie: skip test if default RTC > device does not exist > > [Test] > Run this test with patched source tree on a s390x zVM and it will be > skipped correctly: > $ selftests: timers: rtcpie > $ Default RTC /dev/rtc0 does not exist. Test Skipped! > not ok 9 selftests: timers: rtcpie # SKIP > > [Where problems could occur] > If this fix is incorrect we might see it failing again on systems that > without /dev/rtc0 (after removing our local hacks in autotest-client-tests) > > Po-Hsu Lin (1): > selftests: timers: rtcpie: skip test if default RTC device does not > exist > > tools/testing/selftests/timers/rtcpie.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > applied to oem-5.13, thanks
OEM-5.10 includes this fix from 5.10.52 stable update.
Applied to Hirsute and Focal master-next. thank you! -Kelsey On 2021-07-26 15:56:07 , Po-Hsu Lin wrote: > [Impact] > This test will require /dev/rtc0, the default RTC device, or one > specified by user to run. Since this default RTC is not guaranteed to > exist on all of the devices, so check its existence first, otherwise > skip this test with the kselftest skip code 4. > > Without this patch this test will fail like this on a s390x zVM: > $ selftests: timers: rtcpie > $ /dev/rtc0: No such file or directory > not ok 1 selftests: timers: rtcpie # exit=22 > > We have this test disabled in our test suite with an if check [1], > thus we're not seeing this failure recently. With this patch > applied we can remove that code block later. > > [1] https://kernel.ubuntu.com/git/ubuntu/autotest-client-tests.git/tree/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py#n133 > > [Fix] > * 0d3e5a057992bd selftests: timers: rtcpie: skip test if default RTC > device does not exist > > [Test] > Run this test with patched source tree on a s390x zVM and it will be > skipped correctly: > $ selftests: timers: rtcpie > $ Default RTC /dev/rtc0 does not exist. Test Skipped! > not ok 9 selftests: timers: rtcpie # SKIP > > [Where problems could occur] > If this fix is incorrect we might see it failing again on systems that > without /dev/rtc0 (after removing our local hacks in autotest-client-tests) > > Po-Hsu Lin (1): > selftests: timers: rtcpie: skip test if default RTC device does not > exist > > tools/testing/selftests/timers/rtcpie.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > -- > 2.7.4 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
[Impact] This test will require /dev/rtc0, the default RTC device, or one specified by user to run. Since this default RTC is not guaranteed to exist on all of the devices, so check its existence first, otherwise skip this test with the kselftest skip code 4. Without this patch this test will fail like this on a s390x zVM: $ selftests: timers: rtcpie $ /dev/rtc0: No such file or directory not ok 1 selftests: timers: rtcpie # exit=22 We have this test disabled in our test suite with an if check [1], thus we're not seeing this failure recently. With this patch applied we can remove that code block later. [1] https://kernel.ubuntu.com/git/ubuntu/autotest-client-tests.git/tree/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py#n133 [Fix] * 0d3e5a057992bd selftests: timers: rtcpie: skip test if default RTC device does not exist [Test] Run this test with patched source tree on a s390x zVM and it will be skipped correctly: $ selftests: timers: rtcpie $ Default RTC /dev/rtc0 does not exist. Test Skipped! not ok 9 selftests: timers: rtcpie # SKIP [Where problems could occur] If this fix is incorrect we might see it failing again on systems that without /dev/rtc0 (after removing our local hacks in autotest-client-tests) Po-Hsu Lin (1): selftests: timers: rtcpie: skip test if default RTC device does not exist tools/testing/selftests/timers/rtcpie.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)