From patchwork Mon Jul 26 07:56:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1509885 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=KoQnm0lI; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GYC1Y2qhMz9sXS; Mon, 26 Jul 2021 17:56:49 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1m7vTh-0004BL-LL; Mon, 26 Jul 2021 07:56:45 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1m7vTg-0004BF-RB for kernel-team@lists.ubuntu.com; Mon, 26 Jul 2021 07:56:44 +0000 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id A6B7F3F227 for ; Mon, 26 Jul 2021 07:56:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627286204; bh=NpTjI0S0k/64qyt/fV2Cs5d/QMcUBcAFt0cxAR5folU=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=KoQnm0lI9LS+9J9+qtM+hITgfvjix0ICzJPOOCTdRaMJB+bZ/QF8jenozq6hrY6dh 3pegmr+xSiKZThdtXIwBRA0Trb0MQo+KVZrUmuF6I7E9xc/SfvarA+e1rfReBpCifW xWNiR7sdSfl6xqn58pK0MwGNoF1FIMMSXW4ZVDR9i3tJXpN3OmY4rK/ybaylfxBqEL CNVFD3bVS4Aabdypn1WtXj0OmFdeLCaYZburwa06Qg9dJe+0zGLtb+Gi2bfR2j0vVt 4JC15t/SRzQZlw/f6orfG34cpIlxCgcoGXhzVhWN9hyuTe7+6oifqD5fMIkhenFUxQ 3K91LZ/dfSTtQ== Received: by mail-pj1-f69.google.com with SMTP id s1-20020a17090a8801b02901756faa6840so12135972pjn.2 for ; Mon, 26 Jul 2021 00:56:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=NpTjI0S0k/64qyt/fV2Cs5d/QMcUBcAFt0cxAR5folU=; b=NKMD44Mqu4MwoTsRwep5yNF4xZFHD1Yi3jmbJHVYmbj9V22PtFM6GB6m/e8oTu6dky HnYEMFEHTzLuHJHZs5rufx6W8ukJ717mm/MYsPmBPnMf4JhSMcrl/NqGEgRax2U1f1B1 CDZhUp2sn4E1hbw+ccENpK5qG14y3tv065Wa+6ofKxQYCNNuoY/QhQQ+eUTB+5YqRxMc zjZNU6/3Dja2S6CW46tkv3EwA5RxE9+NmOU7BrydXqeKQ9jWPKdGEht3I+/NQLLMEouj N5w6uyEBW1WsapmG7vyavwn7qsSXNQs4qrKIkGbjTSuJt4M45uN7cKcJONXq/RMNh2Hv 9Pwg== X-Gm-Message-State: AOAM531pflrA9cw2vc35ZzsvnryVk19hYhJ7i4tkPIMufSBOo3XdJV+X k1MM8zjLAVMKRxAUwdw2fBWK08yEwPe1DoYBT3Phe5mU4weOZLshMKYvXG6rAQU5Oe760LKH81g CoMwklNDOipOlKWk7qWfBdX7Hp+LnRren6Y5tDC10 X-Received: by 2002:a17:90a:6390:: with SMTP id f16mr22610460pjj.94.1627286203115; Mon, 26 Jul 2021 00:56:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZoVz6WYDWH9HJhQ7R2mWR/n0ebqpqzt/uYoRCQHxuteem/wa79A1PmUo11c+B5E+8scZqUA== X-Received: by 2002:a17:90a:6390:: with SMTP id f16mr22610446pjj.94.1627286202801; Mon, 26 Jul 2021 00:56:42 -0700 (PDT) Received: from localhost.localdomain (2001-b011-200d-34f4-1ab9-7205-2371-16db.dynamic-ip6.hinet.net. [2001:b011:200d:34f4:1ab9:7205:2371:16db]) by smtp.gmail.com with ESMTPSA id p5sm41228994pfn.46.2021.07.26.00.56.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 00:56:42 -0700 (PDT) From: Po-Hsu Lin To: kernel-team@lists.ubuntu.com Subject: [F/H/I/Unstable][F-OEM-5.10/F-OEM-5.13][SRU][PATCH 0/1] selftests: timers: rtcpie: skip test if default RTC device does not exist Date: Mon, 26 Jul 2021 15:56:07 +0800 Message-Id: <20210726075608.43981-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" [Impact] This test will require /dev/rtc0, the default RTC device, or one specified by user to run. Since this default RTC is not guaranteed to exist on all of the devices, so check its existence first, otherwise skip this test with the kselftest skip code 4. Without this patch this test will fail like this on a s390x zVM: $ selftests: timers: rtcpie $ /dev/rtc0: No such file or directory not ok 1 selftests: timers: rtcpie # exit=22 We have this test disabled in our test suite with an if check [1], thus we're not seeing this failure recently. With this patch applied we can remove that code block later. [1] https://kernel.ubuntu.com/git/ubuntu/autotest-client-tests.git/tree/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py#n133 [Fix] * 0d3e5a057992bd selftests: timers: rtcpie: skip test if default RTC device does not exist [Test] Run this test with patched source tree on a s390x zVM and it will be skipped correctly: $ selftests: timers: rtcpie $ Default RTC /dev/rtc0 does not exist. Test Skipped! not ok 9 selftests: timers: rtcpie # SKIP [Where problems could occur] If this fix is incorrect we might see it failing again on systems that without /dev/rtc0 (after removing our local hacks in autotest-client-tests) Po-Hsu Lin (1): selftests: timers: rtcpie: skip test if default RTC device does not exist tools/testing/selftests/timers/rtcpie.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) Acked-by: Tim Gardner