mbox series

[B,SRU,0/2] selftests: Remove broken Power9 paste tests and fix compilation issue

Message ID 20190716110029.1499-1-po-hsu.lin@canonical.com
Headers show
Series selftests: Remove broken Power9 paste tests and fix compilation issue | expand

Message

Po-Hsu Lin July 16, 2019, 11 a.m. UTC 
== SRU Justification ==
With the Power9 copy_unaligned test removed in bug 1813118,
we can now move forward and remove the broken paste_unaligned /
paste_last_unaligned test in selftests/powerpc.

From the commit message:
    Paste on POWER9 only works to accelerators and not on real memory.
    So these tests just generate a SIGILL.

Actual test output:
    test: test_paste_unaligned
    tags: git_version:unknown
    !! child died by signal 4
    failure: test_paste_unaligned
    not ok 1..2 selftests: paste_unaligned [FAIL]
    selftests: paste_last_unaligned
    ========================================
    test: test_paste_last_unaligned
    tags: git_version:unknown
    !! child died by signal 4
    failure: test_paste_last_unaligned
    not ok 1..3 selftests: paste_last_unaligned [FAIL]
    selftests: alignment_handler

(On Power8 these two test will be skipped)

This patchset will also address the compilation intrduced by b2d35fa
(selftests: add headers_install to lib.mk) which landed with Bionic
upstream stable patchset 2019-07-12 (bug 1836426)

== Fix ==
* 525661ef (selftests/powerpc: Remove Power9 paste tests)
* 7e0cf1c9 (selftests/powerpc: Fix Makefiles for headers_install change)

These has been applied in Disco.

As Cosmic will reach EOL soon, and we don't have alignment tests in
Xenial, we only need this for Bionic.

== Test ==
Patch tested on a P9 node "baltar", test build OK and these two tests
were removed as expected.

== Regression Potential ==
Low.
Code change limited to testing tools for Power9 and just removing
broken tests, fix build error.


Michael Ellerman (2):
  selftests/powerpc: Remove Power9 paste tests
  selftests/powerpc: Fix Makefiles for headers_install change

 .../testing/selftests/powerpc/alignment/.gitignore |  2 -
 tools/testing/selftests/powerpc/alignment/Makefile |  4 +-
 .../powerpc/alignment/paste_last_unaligned.c       | 43 ----------------------
 .../selftests/powerpc/alignment/paste_unaligned.c  | 43 ----------------------
 .../testing/selftests/powerpc/benchmarks/Makefile  |  1 +
 .../testing/selftests/powerpc/cache_shape/Makefile |  1 +
 tools/testing/selftests/powerpc/copyloops/Makefile |  1 +
 tools/testing/selftests/powerpc/dscr/Makefile      |  1 +
 tools/testing/selftests/powerpc/math/Makefile      |  1 +
 tools/testing/selftests/powerpc/mm/Makefile        |  1 +
 tools/testing/selftests/powerpc/pmu/Makefile       |  1 +
 tools/testing/selftests/powerpc/pmu/ebb/Makefile   |  1 +
 .../testing/selftests/powerpc/primitives/Makefile  |  1 +
 tools/testing/selftests/powerpc/ptrace/Makefile    |  1 +
 tools/testing/selftests/powerpc/signal/Makefile    |  1 +
 .../testing/selftests/powerpc/stringloops/Makefile |  1 +
 .../selftests/powerpc/switch_endian/Makefile       |  1 +
 tools/testing/selftests/powerpc/syscalls/Makefile  |  1 +
 tools/testing/selftests/powerpc/tm/Makefile        |  1 +
 tools/testing/selftests/powerpc/vphn/Makefile      |  1 +
 20 files changed, 18 insertions(+), 90 deletions(-)
 delete mode 100644 tools/testing/selftests/powerpc/alignment/paste_last_unaligned.c
 delete mode 100644 tools/testing/selftests/powerpc/alignment/paste_unaligned.c

Comments

Connor Kuehl July 17, 2019, 5:12 p.m. UTC | #1 
On 7/16/19 4:00 AM, Po-Hsu Lin wrote:
> == SRU Justification ==
> With the Power9 copy_unaligned test removed in bug 1813118,
> we can now move forward and remove the broken paste_unaligned /
> paste_last_unaligned test in selftests/powerpc.
> 
> From the commit message:
>     Paste on POWER9 only works to accelerators and not on real memory.
>     So these tests just generate a SIGILL.
> 
> Actual test output:
>     test: test_paste_unaligned
>     tags: git_version:unknown
>     !! child died by signal 4
>     failure: test_paste_unaligned
>     not ok 1..2 selftests: paste_unaligned [FAIL]
>     selftests: paste_last_unaligned
>     ========================================
>     test: test_paste_last_unaligned
>     tags: git_version:unknown
>     !! child died by signal 4
>     failure: test_paste_last_unaligned
>     not ok 1..3 selftests: paste_last_unaligned [FAIL]
>     selftests: alignment_handler
> 
> (On Power8 these two test will be skipped)
> 
> This patchset will also address the compilation intrduced by b2d35fa
> (selftests: add headers_install to lib.mk) which landed with Bionic
> upstream stable patchset 2019-07-12 (bug 1836426)
> 
> == Fix ==
> * 525661ef (selftests/powerpc: Remove Power9 paste tests)
> * 7e0cf1c9 (selftests/powerpc: Fix Makefiles for headers_install change)
> 
> These has been applied in Disco.
> 
> As Cosmic will reach EOL soon, and we don't have alignment tests in
> Xenial, we only need this for Bionic.
> 
> == Test ==
> Patch tested on a P9 node "baltar", test build OK and these two tests
> were removed as expected.
> 
> == Regression Potential ==
> Low.
> Code change limited to testing tools for Power9 and just removing
> broken tests, fix build error.
> 
> 
> Michael Ellerman (2):
>   selftests/powerpc: Remove Power9 paste tests
>   selftests/powerpc: Fix Makefiles for headers_install change
> 
>  .../testing/selftests/powerpc/alignment/.gitignore |  2 -
>  tools/testing/selftests/powerpc/alignment/Makefile |  4 +-
>  .../powerpc/alignment/paste_last_unaligned.c       | 43 ----------------------
>  .../selftests/powerpc/alignment/paste_unaligned.c  | 43 ----------------------
>  .../testing/selftests/powerpc/benchmarks/Makefile  |  1 +
>  .../testing/selftests/powerpc/cache_shape/Makefile |  1 +
>  tools/testing/selftests/powerpc/copyloops/Makefile |  1 +
>  tools/testing/selftests/powerpc/dscr/Makefile      |  1 +
>  tools/testing/selftests/powerpc/math/Makefile      |  1 +
>  tools/testing/selftests/powerpc/mm/Makefile        |  1 +
>  tools/testing/selftests/powerpc/pmu/Makefile       |  1 +
>  tools/testing/selftests/powerpc/pmu/ebb/Makefile   |  1 +
>  .../testing/selftests/powerpc/primitives/Makefile  |  1 +
>  tools/testing/selftests/powerpc/ptrace/Makefile    |  1 +
>  tools/testing/selftests/powerpc/signal/Makefile    |  1 +
>  .../testing/selftests/powerpc/stringloops/Makefile |  1 +
>  .../selftests/powerpc/switch_endian/Makefile       |  1 +
>  tools/testing/selftests/powerpc/syscalls/Makefile  |  1 +
>  tools/testing/selftests/powerpc/tm/Makefile        |  1 +
>  tools/testing/selftests/powerpc/vphn/Makefile      |  1 +
>  20 files changed, 18 insertions(+), 90 deletions(-)
>  delete mode 100644 tools/testing/selftests/powerpc/alignment/paste_last_unaligned.c
>  delete mode 100644 tools/testing/selftests/powerpc/alignment/paste_unaligned.c
> 

Acked-by: Connor Kuehl <connor.kuehl@canonical.com>
Stefan Bader July 19, 2019, 9:16 a.m. UTC | #2 
On 16.07.19 13:00, Po-Hsu Lin wrote:
> == SRU Justification ==
> With the Power9 copy_unaligned test removed in bug 1813118,
> we can now move forward and remove the broken paste_unaligned /
> paste_last_unaligned test in selftests/powerpc.
> 
> From the commit message:
>     Paste on POWER9 only works to accelerators and not on real memory.
>     So these tests just generate a SIGILL.
> 
> Actual test output:
>     test: test_paste_unaligned
>     tags: git_version:unknown
>     !! child died by signal 4
>     failure: test_paste_unaligned
>     not ok 1..2 selftests: paste_unaligned [FAIL]
>     selftests: paste_last_unaligned
>     ========================================
>     test: test_paste_last_unaligned
>     tags: git_version:unknown
>     !! child died by signal 4
>     failure: test_paste_last_unaligned
>     not ok 1..3 selftests: paste_last_unaligned [FAIL]
>     selftests: alignment_handler
> 
> (On Power8 these two test will be skipped)
> 
> This patchset will also address the compilation intrduced by b2d35fa
> (selftests: add headers_install to lib.mk) which landed with Bionic
> upstream stable patchset 2019-07-12 (bug 1836426)
> 
> == Fix ==
> * 525661ef (selftests/powerpc: Remove Power9 paste tests)
> * 7e0cf1c9 (selftests/powerpc: Fix Makefiles for headers_install change)
> 
> These has been applied in Disco.
> 
> As Cosmic will reach EOL soon, and we don't have alignment tests in
> Xenial, we only need this for Bionic.
> 
> == Test ==
> Patch tested on a P9 node "baltar", test build OK and these two tests
> were removed as expected.
> 
> == Regression Potential ==
> Low.
> Code change limited to testing tools for Power9 and just removing
> broken tests, fix build error.
> 
> 
> Michael Ellerman (2):
>   selftests/powerpc: Remove Power9 paste tests
>   selftests/powerpc: Fix Makefiles for headers_install change
> 
>  .../testing/selftests/powerpc/alignment/.gitignore |  2 -
>  tools/testing/selftests/powerpc/alignment/Makefile |  4 +-
>  .../powerpc/alignment/paste_last_unaligned.c       | 43 ----------------------
>  .../selftests/powerpc/alignment/paste_unaligned.c  | 43 ----------------------
>  .../testing/selftests/powerpc/benchmarks/Makefile  |  1 +
>  .../testing/selftests/powerpc/cache_shape/Makefile |  1 +
>  tools/testing/selftests/powerpc/copyloops/Makefile |  1 +
>  tools/testing/selftests/powerpc/dscr/Makefile      |  1 +
>  tools/testing/selftests/powerpc/math/Makefile      |  1 +
>  tools/testing/selftests/powerpc/mm/Makefile        |  1 +
>  tools/testing/selftests/powerpc/pmu/Makefile       |  1 +
>  tools/testing/selftests/powerpc/pmu/ebb/Makefile   |  1 +
>  .../testing/selftests/powerpc/primitives/Makefile  |  1 +
>  tools/testing/selftests/powerpc/ptrace/Makefile    |  1 +
>  tools/testing/selftests/powerpc/signal/Makefile    |  1 +
>  .../testing/selftests/powerpc/stringloops/Makefile |  1 +
>  .../selftests/powerpc/switch_endian/Makefile       |  1 +
>  tools/testing/selftests/powerpc/syscalls/Makefile  |  1 +
>  tools/testing/selftests/powerpc/tm/Makefile        |  1 +
>  tools/testing/selftests/powerpc/vphn/Makefile      |  1 +
>  20 files changed, 18 insertions(+), 90 deletions(-)
>  delete mode 100644 tools/testing/selftests/powerpc/alignment/paste_last_unaligned.c
>  delete mode 100644 tools/testing/selftests/powerpc/alignment/paste_unaligned.c
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Khalid Elmously July 23, 2019, 5:36 a.m. UTC | #3 
On 2019-07-16 19:00:27 , Po-Hsu Lin wrote:
> == SRU Justification ==
> With the Power9 copy_unaligned test removed in bug 1813118,
> we can now move forward and remove the broken paste_unaligned /
> paste_last_unaligned test in selftests/powerpc.
> 
> From the commit message:
>     Paste on POWER9 only works to accelerators and not on real memory.
>     So these tests just generate a SIGILL.
> 
> Actual test output:
>     test: test_paste_unaligned
>     tags: git_version:unknown
>     !! child died by signal 4
>     failure: test_paste_unaligned
>     not ok 1..2 selftests: paste_unaligned [FAIL]
>     selftests: paste_last_unaligned
>     ========================================
>     test: test_paste_last_unaligned
>     tags: git_version:unknown
>     !! child died by signal 4
>     failure: test_paste_last_unaligned
>     not ok 1..3 selftests: paste_last_unaligned [FAIL]
>     selftests: alignment_handler
> 
> (On Power8 these two test will be skipped)
> 
> This patchset will also address the compilation intrduced by b2d35fa
> (selftests: add headers_install to lib.mk) which landed with Bionic
> upstream stable patchset 2019-07-12 (bug 1836426)
> 
> == Fix ==
> * 525661ef (selftests/powerpc: Remove Power9 paste tests)
> * 7e0cf1c9 (selftests/powerpc: Fix Makefiles for headers_install change)
> 
> These has been applied in Disco.
> 
> As Cosmic will reach EOL soon, and we don't have alignment tests in
> Xenial, we only need this for Bionic.
> 
> == Test ==
> Patch tested on a P9 node "baltar", test build OK and these two tests
> were removed as expected.
> 
> == Regression Potential ==
> Low.
> Code change limited to testing tools for Power9 and just removing
> broken tests, fix build error.
> 
> 
> Michael Ellerman (2):
>   selftests/powerpc: Remove Power9 paste tests
>   selftests/powerpc: Fix Makefiles for headers_install change
> 
>  .../testing/selftests/powerpc/alignment/.gitignore |  2 -
>  tools/testing/selftests/powerpc/alignment/Makefile |  4 +-
>  .../powerpc/alignment/paste_last_unaligned.c       | 43 ----------------------
>  .../selftests/powerpc/alignment/paste_unaligned.c  | 43 ----------------------
>  .../testing/selftests/powerpc/benchmarks/Makefile  |  1 +
>  .../testing/selftests/powerpc/cache_shape/Makefile |  1 +
>  tools/testing/selftests/powerpc/copyloops/Makefile |  1 +
>  tools/testing/selftests/powerpc/dscr/Makefile      |  1 +
>  tools/testing/selftests/powerpc/math/Makefile      |  1 +
>  tools/testing/selftests/powerpc/mm/Makefile        |  1 +
>  tools/testing/selftests/powerpc/pmu/Makefile       |  1 +
>  tools/testing/selftests/powerpc/pmu/ebb/Makefile   |  1 +
>  .../testing/selftests/powerpc/primitives/Makefile  |  1 +
>  tools/testing/selftests/powerpc/ptrace/Makefile    |  1 +
>  tools/testing/selftests/powerpc/signal/Makefile    |  1 +
>  .../testing/selftests/powerpc/stringloops/Makefile |  1 +
>  .../selftests/powerpc/switch_endian/Makefile       |  1 +
>  tools/testing/selftests/powerpc/syscalls/Makefile  |  1 +
>  tools/testing/selftests/powerpc/tm/Makefile        |  1 +
>  tools/testing/selftests/powerpc/vphn/Makefile      |  1 +
>  20 files changed, 18 insertions(+), 90 deletions(-)
>  delete mode 100644 tools/testing/selftests/powerpc/alignment/paste_last_unaligned.c
>  delete mode 100644 tools/testing/selftests/powerpc/alignment/paste_unaligned.c
> 
> -- 
> 2.7.4
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team