From patchwork Tue Jul 16 11:00:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1132596 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45nyBT6TcMz9sNC; Tue, 16 Jul 2019 21:01:21 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1hnLCw-0002kM-9R; Tue, 16 Jul 2019 11:01:18 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1hnLCu-0002k2-NB for kernel-team@lists.ubuntu.com; Tue, 16 Jul 2019 11:01:16 +0000 Received: from mail-pl1-f200.google.com ([209.85.214.200]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hnLCu-0000L2-7A for kernel-team@lists.ubuntu.com; Tue, 16 Jul 2019 11:01:16 +0000 Received: by mail-pl1-f200.google.com with SMTP id f2so9995459plr.0 for ; Tue, 16 Jul 2019 04:01:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=DfGUGCxGCQKNeQHfi/VHycdx5WQ+HdlhOlOXMOcVqUw=; b=Gnncd4c59VfHhCbyS06Q9jtzZgy1Wx9gTP//Q6FmV8scVnT653a/foBukQXTW6D4bh EgsT1ptdmSWVa0pBM3XI+RZ2AfBL36Vn+EWKPuWBtR1QFQWTAQ+uQ7gbxJT6eGqp4UFi ySq2hmDFsu0Q2Js5ptg2aOLdYAkilxMln8MQWzUhtIcxAkNNYJYGm2sMq3Ne0vr/D9yu 7EzbtOqU1AGl6iMaWmZZ7DdrHzUk8yCP69xIBz3kOEVuqXgFuBDhil0x5YLAQgUmZzKC ueT6UuukeqRzM336zd+JmmMFd/njW/H3g0PrKjyqjb5Ybe6QqWREijS/HxJwUrANblK+ 9skw== X-Gm-Message-State: APjAAAWXT59W/KU3G7EY4pv/yZxQcz1a8ksy5MMus9YCKkVY05WRXMfA 6bBSVq08XFoJBkHyjbluMaI83pQK20syK5poqAYadlVZZdBleHVnWjKbV0A+Y0SdQf2GyqSL88r cKdqt68Tve95Exr2Crs+ZNvi+h2GtNXxJZxch5/g7 X-Received: by 2002:a17:902:ac85:: with SMTP id h5mr34796050plr.198.1563274874673; Tue, 16 Jul 2019 04:01:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqwUH1tmCs1igqKWyl1uKdXcsR3Sh2L9+Q+SPY8sLBxD7419u+ohcm6k0MSjmPqsV48zhvRA0g== X-Received: by 2002:a17:902:ac85:: with SMTP id h5mr34796011plr.198.1563274874402; Tue, 16 Jul 2019 04:01:14 -0700 (PDT) Received: from Leggiero.taipei.internal (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id p187sm29917930pfg.89.2019.07.16.04.01.13 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 16 Jul 2019 04:01:13 -0700 (PDT) From: Po-Hsu Lin To: kernel-team@lists.ubuntu.com Subject: [B][SRU][PATCH 0/2] selftests: Remove broken Power9 paste tests and fix compilation issue Date: Tue, 16 Jul 2019 19:00:27 +0800 Message-Id: <20190716110029.1499-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" == SRU Justification == With the Power9 copy_unaligned test removed in bug 1813118, we can now move forward and remove the broken paste_unaligned / paste_last_unaligned test in selftests/powerpc. From the commit message: Paste on POWER9 only works to accelerators and not on real memory. So these tests just generate a SIGILL. Actual test output: test: test_paste_unaligned tags: git_version:unknown !! child died by signal 4 failure: test_paste_unaligned not ok 1..2 selftests: paste_unaligned [FAIL] selftests: paste_last_unaligned ======================================== test: test_paste_last_unaligned tags: git_version:unknown !! child died by signal 4 failure: test_paste_last_unaligned not ok 1..3 selftests: paste_last_unaligned [FAIL] selftests: alignment_handler (On Power8 these two test will be skipped) This patchset will also address the compilation intrduced by b2d35fa (selftests: add headers_install to lib.mk) which landed with Bionic upstream stable patchset 2019-07-12 (bug 1836426) == Fix == * 525661ef (selftests/powerpc: Remove Power9 paste tests) * 7e0cf1c9 (selftests/powerpc: Fix Makefiles for headers_install change) These has been applied in Disco. As Cosmic will reach EOL soon, and we don't have alignment tests in Xenial, we only need this for Bionic. == Test == Patch tested on a P9 node "baltar", test build OK and these two tests were removed as expected. == Regression Potential == Low. Code change limited to testing tools for Power9 and just removing broken tests, fix build error. Michael Ellerman (2): selftests/powerpc: Remove Power9 paste tests selftests/powerpc: Fix Makefiles for headers_install change .../testing/selftests/powerpc/alignment/.gitignore | 2 - tools/testing/selftests/powerpc/alignment/Makefile | 4 +- .../powerpc/alignment/paste_last_unaligned.c | 43 ---------------------- .../selftests/powerpc/alignment/paste_unaligned.c | 43 ---------------------- .../testing/selftests/powerpc/benchmarks/Makefile | 1 + .../testing/selftests/powerpc/cache_shape/Makefile | 1 + tools/testing/selftests/powerpc/copyloops/Makefile | 1 + tools/testing/selftests/powerpc/dscr/Makefile | 1 + tools/testing/selftests/powerpc/math/Makefile | 1 + tools/testing/selftests/powerpc/mm/Makefile | 1 + tools/testing/selftests/powerpc/pmu/Makefile | 1 + tools/testing/selftests/powerpc/pmu/ebb/Makefile | 1 + .../testing/selftests/powerpc/primitives/Makefile | 1 + tools/testing/selftests/powerpc/ptrace/Makefile | 1 + tools/testing/selftests/powerpc/signal/Makefile | 1 + .../testing/selftests/powerpc/stringloops/Makefile | 1 + .../selftests/powerpc/switch_endian/Makefile | 1 + tools/testing/selftests/powerpc/syscalls/Makefile | 1 + tools/testing/selftests/powerpc/tm/Makefile | 1 + tools/testing/selftests/powerpc/vphn/Makefile | 1 + 20 files changed, 18 insertions(+), 90 deletions(-) delete mode 100644 tools/testing/selftests/powerpc/alignment/paste_last_unaligned.c delete mode 100644 tools/testing/selftests/powerpc/alignment/paste_unaligned.c Acked-by: Connor Kuehl Acked-by: Stefan Bader