| Message ID | 56C9A017.6020809@denx.de |
|---|---|
| State | Not Applicable |
| Delegated to: | York Sun |
| Headers | show |
On Sun, Feb 21, 2016 at 8:31 AM, Stefano Babic <sbabic@denx.de> wrote: > Hi Bhuvanchandra, > > your applied patch: > > commit 5160def267739518950e8e3bb78e0e6c3941cb3e > Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> > Date: Wed Jan 27 10:31:52 2016 +0530 > > dm: lpuart: Drop the legacy code > > braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this > should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for > these boards (setting them, build is fine): > > For example, for ls1021aqds_nor_lpuart: > diff --git a/configs/ls1021aqds_nor_lpuart_defconfig > b/configs/ls1021aqds_nor_lpuart_defconfig > index 1186af2..d8d77c2 100644 > --- a/configs/ls1021aqds_nor_lpuart_defconfig > +++ b/configs/ls1021aqds_nor_lpuart_defconfig > @@ -2,6 +2,8 @@ CONFIG_ARM=y > CONFIG_TARGET_LS1021AQDS=y > CONFIG_SYS_EXTRA_OPTIONS="LPUART" > # CONFIG_CMD_SETEXPR is not set > +CONFIG_DM=y > +CONFIG_DM_SERIAL=y > CONFIG_NETDEVICES=y > CONFIG_E1000=y > CONFIG_FSL_LPUART=y > > Can you provide a formal patch and resubmit ? I have no way to test the > result on the board. Adding Alison, who is the maintainer of this board and could probably help testing the patch.
On Sun, Feb 21, 2016 at 9:00 PM, Fabio Estevam <festevam@gmail.com> wrote: > On Sun, Feb 21, 2016 at 8:31 AM, Stefano Babic <sbabic@denx.de> wrote: >> Hi Bhuvanchandra, >> >> your applied patch: >> >> commit 5160def267739518950e8e3bb78e0e6c3941cb3e >> Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> >> Date: Wed Jan 27 10:31:52 2016 +0530 >> >> dm: lpuart: Drop the legacy code >> >> braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this >> should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for >> these boards (setting them, build is fine): >> >> For example, for ls1021aqds_nor_lpuart: >> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig >> b/configs/ls1021aqds_nor_lpuart_defconfig >> index 1186af2..d8d77c2 100644 >> --- a/configs/ls1021aqds_nor_lpuart_defconfig >> +++ b/configs/ls1021aqds_nor_lpuart_defconfig >> @@ -2,6 +2,8 @@ CONFIG_ARM=y >> CONFIG_TARGET_LS1021AQDS=y >> CONFIG_SYS_EXTRA_OPTIONS="LPUART" >> # CONFIG_CMD_SETEXPR is not set >> +CONFIG_DM=y >> +CONFIG_DM_SERIAL=y >> CONFIG_NETDEVICES=y >> CONFIG_E1000=y >> CONFIG_FSL_LPUART=y >> >> Can you provide a formal patch and resubmit ? I have no way to test the >> result on the board. > > Adding Alison, who is the maintainer of this board and could probably > help testing the patch. There is already a series [1] for the ls1021a-qds. [1] http://patchwork.ozlabs.org/patch/580577/ Regards, Bin
Hi Stefano, Adding Bin Meng. On 02/21/2016 05:01 PM, Stefano Babic wrote: > Hi Bhuvanchandra, > > your applied patch: > > commit 5160def267739518950e8e3bb78e0e6c3941cb3e > Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> > Date: Wed Jan 27 10:31:52 2016 +0530 > > dm: lpuart: Drop the legacy code > > braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this > should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for > these boards (setting them, build is fine): > > For example, for ls1021aqds_nor_lpuart: > diff --git a/configs/ls1021aqds_nor_lpuart_defconfig > b/configs/ls1021aqds_nor_lpuart_defconfig > index 1186af2..d8d77c2 100644 > --- a/configs/ls1021aqds_nor_lpuart_defconfig > +++ b/configs/ls1021aqds_nor_lpuart_defconfig > @@ -2,6 +2,8 @@ CONFIG_ARM=y > CONFIG_TARGET_LS1021AQDS=y > CONFIG_SYS_EXTRA_OPTIONS="LPUART" > # CONFIG_CMD_SETEXPR is not set > +CONFIG_DM=y > +CONFIG_DM_SERIAL=y > CONFIG_NETDEVICES=y > CONFIG_E1000=y > CONFIG_FSL_LPUART=y > > Can you provide a formal patch and resubmit ? I have no way to test the > result on the board. I also don't have this h/w to test at my end, may be Bin can help here. > > Thanks, > Stefano Babic >
Hi, On 22/02/2016 04:19, Bhuvanchandra DV wrote: > Hi Stefano, > > Adding Bin Meng. > > On 02/21/2016 05:01 PM, Stefano Babic wrote: >> Hi Bhuvanchandra, >> >> your applied patch: >> >> commit 5160def267739518950e8e3bb78e0e6c3941cb3e >> Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> >> Date: Wed Jan 27 10:31:52 2016 +0530 >> >> dm: lpuart: Drop the legacy code >> >> braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this >> should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for >> these boards (setting them, build is fine): >> >> For example, for ls1021aqds_nor_lpuart: >> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig >> b/configs/ls1021aqds_nor_lpuart_defconfig >> index 1186af2..d8d77c2 100644 >> --- a/configs/ls1021aqds_nor_lpuart_defconfig >> +++ b/configs/ls1021aqds_nor_lpuart_defconfig >> @@ -2,6 +2,8 @@ CONFIG_ARM=y >> CONFIG_TARGET_LS1021AQDS=y >> CONFIG_SYS_EXTRA_OPTIONS="LPUART" >> # CONFIG_CMD_SETEXPR is not set >> +CONFIG_DM=y >> +CONFIG_DM_SERIAL=y >> CONFIG_NETDEVICES=y >> CONFIG_E1000=y >> CONFIG_FSL_LPUART=y >> >> Can you provide a formal patch and resubmit ? I have no way to test the >> result on the board. > > I also don't have this h/w to test at my end, may be Bin can help here. Fabio has already added Alison who is board maintainer - the one could have the hw for test. Best regards, Stefano
> On Sun, Feb 21, 2016 at 9:00 PM, Fabio Estevam <festevam@gmail.com> > wrote: > > On Sun, Feb 21, 2016 at 8:31 AM, Stefano Babic <sbabic@denx.de> wrote: > >> Hi Bhuvanchandra, > >> > >> your applied patch: > >> > >> commit 5160def267739518950e8e3bb78e0e6c3941cb3e > >> Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> > >> Date: Wed Jan 27 10:31:52 2016 +0530 > >> > >> dm: lpuart: Drop the legacy code > >> > >> braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this > >> should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set > >> for these boards (setting them, build is fine): > >> > >> For example, for ls1021aqds_nor_lpuart: > >> diff --git a/configs/ls1021aqds_nor_lpuart_defconfig > >> b/configs/ls1021aqds_nor_lpuart_defconfig > >> index 1186af2..d8d77c2 100644 > >> --- a/configs/ls1021aqds_nor_lpuart_defconfig > >> +++ b/configs/ls1021aqds_nor_lpuart_defconfig > >> @@ -2,6 +2,8 @@ CONFIG_ARM=y > >> CONFIG_TARGET_LS1021AQDS=y > >> CONFIG_SYS_EXTRA_OPTIONS="LPUART" > >> # CONFIG_CMD_SETEXPR is not set > >> +CONFIG_DM=y > >> +CONFIG_DM_SERIAL=y > >> CONFIG_NETDEVICES=y > >> CONFIG_E1000=y > >> CONFIG_FSL_LPUART=y > >> > >> Can you provide a formal patch and resubmit ? I have no way to test > >> the result on the board. > > > > Adding Alison, who is the maintainer of this board and could probably > > help testing the patch. > > There is already a series [1] for the ls1021a-qds. > > [1] http://patchwork.ozlabs.org/patch/580577/ [Alison Wang] Yes, York has sent a series to fix this problem. I only review and test his series. Best Regards, Alison Wang
diff --git a/configs/ls1021aqds_nor_lpuart_defconfig b/configs/ls1021aqds_nor_lpuart_defconfig index 1186af2..d8d77c2 100644 --- a/configs/ls1021aqds_nor_lpuart_defconfig +++ b/configs/ls1021aqds_nor_lpuart_defconfig @@ -2,6 +2,8 @@ CONFIG_ARM=y CONFIG_TARGET_LS1021AQDS=y CONFIG_SYS_EXTRA_OPTIONS="LPUART" # CONFIG_CMD_SETEXPR is not set +CONFIG_DM=y +CONFIG_DM_SERIAL=y CONFIG_NETDEVICES=y CONFIG_E1000=y CONFIG_FSL_LPUART=y
Hi Bhuvanchandra, your applied patch: commit 5160def267739518950e8e3bb78e0e6c3941cb3e Author: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com> Date: Wed Jan 27 10:31:52 2016 +0530 dm: lpuart: Drop the legacy code braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for these boards (setting them, build is fine): For example, for ls1021aqds_nor_lpuart: Can you provide a formal patch and resubmit ? I have no way to test the result on the board. Thanks, Stefano Babic