| Message ID | 20240416190019.81016-6-raymond.mao@linaro.org |
|---|---|
| State | RFC |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Integrate MbedTLS v3.6 LTS with U-Boot | expand |
On Tue, Apr 16, 2024 at 12:00:01PM -0700, Raymond Mao wrote: > Fix a permission issue when running virt-make-fs > > Signed-off-by: Raymond Mao <raymond.mao@linaro.org> > --- > test/py/tests/test_efi_secboot/conftest.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Can you elaborate please? The point of virt-make-fs was, I could have sworn, is that it doesn't require privileges.
Hi Tom, On Tue, 16 Apr 2024 at 15:19, Tom Rini <trini@konsulko.com> wrote: > On Tue, Apr 16, 2024 at 12:00:01PM -0700, Raymond Mao wrote: > > > Fix a permission issue when running virt-make-fs > > > > Signed-off-by: Raymond Mao <raymond.mao@linaro.org> > > --- > > test/py/tests/test_efi_secboot/conftest.py | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Can you elaborate please? The point of virt-make-fs was, I could have > sworn, is that it doesn't require privileges. > > We can drop this patch from v2. The privileges issue is due to my Ubuntu host setup (missing the permissions to access /boot/vmlinuz-*). Thanks and regards, Raymond
diff --git a/test/py/tests/test_efi_secboot/conftest.py b/test/py/tests/test_efi_secboot/conftest.py index ff7ac7c810..30357913f0 100644 --- a/test/py/tests/test_efi_secboot/conftest.py +++ b/test/py/tests/test_efi_secboot/conftest.py @@ -113,7 +113,7 @@ def efi_boot_env(request, u_boot_config): % (mnt_point, EFITOOLS_PATH), shell=True) - check_call('virt-make-fs --partition=gpt --size=+1M --type=vfat {} {}'.format( + check_call('sudo virt-make-fs --partition=gpt --size=+1M --type=vfat {} {}'.format( mnt_point, image_path), shell=True) check_call('rm -rf {}'.format(mnt_point), shell=True) @@ -232,7 +232,7 @@ def efi_boot_env_intca(request, u_boot_config): check_call('cd %s; cat TestSub.crt TestRoot.crt > TestSubRoot.crt; %ssbsign --key TestCert.key --cert TestCert.crt --addcert TestSubRoot.crt --out helloworld.efi.signed_abc helloworld.efi' % (mnt_point, SBSIGN_PATH), shell=True) - check_call('virt-make-fs --partition=gpt --size=+1M --type=vfat {} {}'.format(mnt_point, image_path), shell=True) + check_call('sudo virt-make-fs --partition=gpt --size=+1M --type=vfat {} {}'.format(mnt_point, image_path), shell=True) check_call('rm -rf {}'.format(mnt_point), shell=True) except CalledProcessError as e:
Fix a permission issue when running virt-make-fs Signed-off-by: Raymond Mao <raymond.mao@linaro.org> --- test/py/tests/test_efi_secboot/conftest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)