| Message ID | 20240321144541.15314-3-othacehe@gnu.org |
|---|---|
| State | Accepted |
| Commit | 6d5425d6e1df7f4192cd7f9f3fba458d994d099d |
| Delegated to: | Fabio Estevam |
| Headers | show |
| Series | imx93-phyboard-segin: Add USB support. | expand |
On 3/21/24 3:45 PM, Mathieu Othacehe wrote: > Add USB support by enabling `usb` command and required USB drivers. > > Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> > --- > configs/imx93-phyboard-segin_defconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/configs/imx93-phyboard-segin_defconfig b/configs/imx93-phyboard-segin_defconfig > index 24f9bd553aa..0345e7deeab 100644 > --- a/configs/imx93-phyboard-segin_defconfig > +++ b/configs/imx93-phyboard-segin_defconfig > @@ -67,6 +67,7 @@ CONFIG_CMD_GPIO=y > CONFIG_CMD_I2C=y > CONFIG_CMD_MMC=y > CONFIG_CMD_POWEROFF=y > +CONFIG_CMD_USB=y > CONFIG_CMD_SNTP=y > CONFIG_CMD_CACHE=y > CONFIG_CMD_EFIDEBUG=y > @@ -132,6 +133,13 @@ CONFIG_SPL_SYSRESET=y > CONFIG_SYSRESET_WATCHDOG=y > CONFIG_DM_THERMAL=y > CONFIG_IMX_TMU=y > +CONFIG_USB=y > +CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_GADGET=y > +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" $ git grep -i usb.*phytec configs configs/phycore_pcl063_defconfig:CONFIG_USB_GADGET_MANUFACTURER="Phytec" configs/phycore_pcl063_ull_defconfig:CONFIG_USB_GADGET_MANUFACTURER="Phytec" It would be good to be consistent. Also, what is the vendor/product number those two boards use ? Also, it would be good to fix the extra leading zero in those board boards vendor number, this, in both configs: CONFIG_USB_GADGET_VENDOR_NUM=0x01b67
On Thu, Mar 21, 2024 at 4:17 PM Marek Vasut <marex@denx.de> wrote: > $ git grep -i usb.*phytec configs > configs/phycore_pcl063_defconfig:CONFIG_USB_GADGET_MANUFACTURER="Phytec" > configs/phycore_pcl063_ull_defconfig:CONFIG_USB_GADGET_MANUFACTURER="Phytec" > > It would be good to be consistent. > > Also, what is the vendor/product number those two boards use ? They both use: CONFIG_USB_GADGET_VENDOR_NUM=0x01b67 CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff configs/phycore-imx8mp_defconfig has: CONFIG_USB_GADGET_MANUFACTURER="FSL" CONFIG_USB_GADGET_VENDOR_NUM=0x0525 CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 I agree we should make this consistent. To not block this series, I applied it, but it would be great if Phytec could submit a separate series making it consistent across their boards. Thanks
On 3/24/24 7:00 PM, Fabio Estevam wrote: > On Thu, Mar 21, 2024 at 4:17 PM Marek Vasut <marex@denx.de> wrote: > >> $ git grep -i usb.*phytec configs >> configs/phycore_pcl063_defconfig:CONFIG_USB_GADGET_MANUFACTURER="Phytec" >> configs/phycore_pcl063_ull_defconfig:CONFIG_USB_GADGET_MANUFACTURER="Phytec" >> >> It would be good to be consistent. >> >> Also, what is the vendor/product number those two boards use ? > > They both use: > > CONFIG_USB_GADGET_VENDOR_NUM=0x01b67 USB VID is 16bit number, the nubmer above is 20bit , drop the leading zero while at it.
Hi Fabio, hi Marek, On Sun, 2024-03-24 at 15:00 -0300, Fabio Estevam wrote: > On Thu, Mar 21, 2024 at 4:17 PM Marek Vasut <marex@denx.de> wrote: > > > $ git grep -i usb.*phytec configs > > configs/phycore_pcl063_defconfig:CONFIG_USB_GADGET_MANUFACTURER="Phytec" > > configs/phycore_pcl063_ull_defconfig:CONFIG_USB_GADGET_MANUFACTURER="Phytec" > > > > It would be good to be consistent. > > > > Also, what is the vendor/product number those two boards use ? > > They both use: > > CONFIG_USB_GADGET_VENDOR_NUM=0x01b67 > CONFIG_USB_GADGET_PRODUCT_NUM=0x4fff > > configs/phycore-imx8mp_defconfig has: > > CONFIG_USB_GADGET_MANUFACTURER="FSL" > CONFIG_USB_GADGET_VENDOR_NUM=0x0525 > CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5 > > I agree we should make this consistent. > > To not block this series, I applied it, but it would be great if > > Phytec could submit > a separate series making it consistent across their boards. We'll take care of that. Thank you for the feedback. Yannic > > Thanks
diff --git a/configs/imx93-phyboard-segin_defconfig b/configs/imx93-phyboard-segin_defconfig index 24f9bd553aa..0345e7deeab 100644 --- a/configs/imx93-phyboard-segin_defconfig +++ b/configs/imx93-phyboard-segin_defconfig @@ -67,6 +67,7 @@ CONFIG_CMD_GPIO=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y CONFIG_CMD_POWEROFF=y +CONFIG_CMD_USB=y CONFIG_CMD_SNTP=y CONFIG_CMD_CACHE=y CONFIG_CMD_EFIDEBUG=y @@ -132,6 +133,13 @@ CONFIG_SPL_SYSRESET=y CONFIG_SYSRESET_WATCHDOG=y CONFIG_DM_THERMAL=y CONFIG_IMX_TMU=y +CONFIG_USB=y +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_GADGET=y +CONFIG_USB_GADGET_MANUFACTURER="PHYTEC" +CONFIG_USB_GADGET_VENDOR_NUM=0x1fc9 +CONFIG_USB_GADGET_PRODUCT_NUM=0x0152 +CONFIG_CI_UDC=y CONFIG_ULP_WATCHDOG=y CONFIG_LZO=y CONFIG_BZIP2=y
Add USB support by enabling `usb` command and required USB drivers. Signed-off-by: Mathieu Othacehe <othacehe@gnu.org> --- configs/imx93-phyboard-segin_defconfig | 8 ++++++++ 1 file changed, 8 insertions(+)