diff mbox series

[v3,1/3] arm: dts: imx93-phyboard-segin: Add USB support

Message ID 20240321144541.15314-2-othacehe@gnu.org
State Accepted
Commit 1be8b6a24d356fa80210f78d8ad39aaafbfd55ca
Delegated to: Fabio Estevam
Headers show
Series imx93-phyboard-segin: Add USB support. | expand

Commit Message

Mathieu Othacehe March 21, 2024, 2:45 p.m. UTC 
Enable both usbotg1 and usbotg2 ports. Disable over-current as OC pins are
not connected to the SoC.

This is temporary, until USB support is added to imx93-phyboard-segin.dts
in Linux.

Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>
---
 arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Fabio Estevam March 21, 2024, 2:47 p.m. UTC | #1 
Hi Mathieu,

On Thu, Mar 21, 2024 at 11:46 AM Mathieu Othacehe <othacehe@gnu.org> wrote:
>
> Enable both usbotg1 and usbotg2 ports. Disable over-current as OC pins are
> not connected to the SoC.
>
> This is temporary, until USB support is added to imx93-phyboard-segin.dts
> in Linux.
>
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>

Thanks, this looks better:

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Marek Vasut March 21, 2024, 4:13 p.m. UTC | #2 
On 3/21/24 3:45 PM, Mathieu Othacehe wrote:
> Enable both usbotg1 and usbotg2 ports. Disable over-current as OC pins are
> not connected to the SoC.
> 
> This

"This addition to ...-u-boot.dtsi is temporary, ..." would be clearer.

> is temporary, until USB support is added to imx93-phyboard-segin.dts
> in Linux.
> 
> Signed-off-by: Mathieu Othacehe <othacehe@gnu.org>

Reviewed-by: Marek Vasut <marex@denx.de>
Fabio Estevam March 24, 2024, 5:55 p.m. UTC | #3 
On Thu, Mar 21, 2024 at 4:17 PM Marek Vasut <marex@denx.de> wrote:
>
> On 3/21/24 3:45 PM, Mathieu Othacehe wrote:
> > Enable both usbotg1 and usbotg2 ports. Disable over-current as OC pins are
> > not connected to the SoC.
> >
> > This
>
> "This addition to ...-u-boot.dtsi is temporary, ..." would be clearer.

I fixed as Marek's suggestion and applied it to u-boot-imx/next, thanks.
diff mbox series

Patch

diff --git a/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi b/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi
index 8bf28c2de87..6897c91f4d9 100644
--- a/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi
+++ b/arch/arm/dts/imx93-phyboard-segin-u-boot.dtsi
@@ -121,6 +121,21 @@ 
 	bootph-some-ram;
 };
 
+/*
+ * Remove once USB support is added to imx93-phyboard-segin.dts upstream.
+ */
+&usbotg1 {
+	disable-over-current;
+	dr_mode = "otg";
+	status = "okay";
+};
+
+&usbotg2 {
+	disable-over-current;
+	dr_mode = "host";
+	status = "okay";
+};
+
 &usdhc1 {
 	bootph-pre-ram;
 	bootph-some-ram;