diff mbox series

[v3,06/12] expo: Correct background colour

Message ID 20231001191444.v3.6.I0229a119165879ecce6bafc8568708326bf5ba78@changeid
State Accepted
Delegated to: Simon Glass
Headers show
Series Resolve issues with booting distros on x86 | expand

Commit Message

Simon Glass Oct. 2, 2023, 1:14 a.m. UTC 
Use the correct background colour when using white-on-black.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 boot/expo.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Bin Meng Nov. 5, 2023, 2:06 p.m. UTC | #1 
On Mon, Oct 2, 2023 at 9:30 AM Simon Glass <sjg@chromium.org> wrote:
>
> Use the correct background colour when using white-on-black.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v1)
>
>  boot/expo.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Simon Glass Nov. 15, 2023, 1:17 p.m. UTC | #2 
On Mon, Oct 2, 2023 at 9:30 AM Simon Glass <sjg@chromium.org> wrote:
>
> Use the correct background colour when using white-on-black.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> (no changes since v1)
>
>  boot/expo.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

Applied to u-boot-dm, thanks!
diff mbox series

Patch

diff --git a/boot/expo.c b/boot/expo.c
index 139d684f8e6e..cadb6a0ad6e3 100644
--- a/boot/expo.c
+++ b/boot/expo.c
@@ -190,10 +190,12 @@  int expo_render(struct expo *exp)
 	struct udevice *dev = exp->display;
 	struct video_priv *vid_priv = dev_get_uclass_priv(dev);
 	struct scene *scn = NULL;
+	enum colour_idx back;
 	u32 colour;
 	int ret;
 
-	colour = video_index_to_colour(vid_priv, VID_WHITE);
+	back = CONFIG_IS_ENABLED(SYS_WHITE_ON_BLACK) ? VID_BLACK : VID_WHITE;
+	colour = video_index_to_colour(vid_priv, back);
 	ret = video_fill(dev, colour);
 	if (ret)
 		return log_msg_ret("fill", ret);