diff mbox series

[v4,04/15] drivers: video: Makefile: Rule to compile necessary video driver files.

Message ID 20230329120119.72886-5-n-jain1@ti.com
State Superseded
Delegated to: Anatolij Gustschin
Headers show
Series Add splash screen support at u-boot SPL | expand

Commit Message

Nikhil Jain March 29, 2023, 12:01 p.m. UTC
To enable video driver at SPL, need to compile video-uclass,
vidconsole-uclass, backlight-uclass, panel-uclass, simple-panel, add
rules to compile them at SPL only. To support splash_display at SPL,
need to compile video-bmp, add rule to compile at SPL stage only.

Signed-off-by: Nikhil M Jain <n-jain1@ti.com>
---
V4:
- No change

V3:
- Rule to compile backlight, console and panel files
- Not added Reiewed-by tag due to changes

V2:
- No change

 drivers/video/Makefile | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Simon Glass March 30, 2023, 8:14 p.m. UTC | #1
Hi Nikhil,

On Thu, 30 Mar 2023 at 01:01, Nikhil M Jain <n-jain1@ti.com> wrote:
>
> To enable video driver at SPL, need to compile video-uclass,
> vidconsole-uclass, backlight-uclass, panel-uclass, simple-panel, add
> rules to compile them at SPL only. To support splash_display at SPL,
> need to compile video-bmp, add rule to compile at SPL stage only.
>
> Signed-off-by: Nikhil M Jain <n-jain1@ti.com>
> ---
> V4:
> - No change
>
> V3:
> - Rule to compile backlight, console and panel files
> - Not added Reiewed-by tag due to changes
>
> V2:
> - No change
>
>  drivers/video/Makefile | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
> index cdb7d9a54d..2374b240c2 100644
> --- a/drivers/video/Makefile
> +++ b/drivers/video/Makefile
> @@ -68,3 +68,12 @@ obj-$(CONFIG_VIDEO_ZYNQMP_DPSUB) += zynqmp_dpsub.o
>
>  obj-y += bridge/
>  obj-y += sunxi/
> +
> +ifdef CONFIG_SPL_BUILD
> +obj-$(CONFIG_SPL_BACKLIGHT) += backlight-uclass.o
> +obj-$(CONFIG_SPL_PANEL) += panel-uclass.o
> +obj-$(CONFIG_SPL_SIMPLE_PANEL) += simple_panel.o
> +obj-$(CONFIG_SPL_CONSOLE_NORMAL) += console_normal.o
> +obj-$(CONFIG_SPL_VIDEO) += video-uclass.o vidconsole-uclass.o
> +obj-$(CONFIG_SPL_VIDEO) += video_bmp.o

Can you use

obj-$(CONFIG_$(SPL_TPL_)VIDEO) += video_bmp.o

instead?

If I ever get back to the split config thing we'll need that.

> +endif
> --
> 2.34.1
>

Regards,
Simon
Nikhil Jain March 31, 2023, 5 a.m. UTC | #2
Hi Simon

On 31/03/23 01:44, Simon Glass wrote:
> Hi Nikhil,
> 
> On Thu, 30 Mar 2023 at 01:01, Nikhil M Jain <n-jain1@ti.com> wrote:
>>
>> To enable video driver at SPL, need to compile video-uclass,
>> vidconsole-uclass, backlight-uclass, panel-uclass, simple-panel, add
>> rules to compile them at SPL only. To support splash_display at SPL,
>> need to compile video-bmp, add rule to compile at SPL stage only.
>>
>> Signed-off-by: Nikhil M Jain <n-jain1@ti.com>
>> ---
>> V4:
>> - No change
>>
>> V3:
>> - Rule to compile backlight, console and panel files
>> - Not added Reiewed-by tag due to changes
>>
>> V2:
>> - No change
>>
>>   drivers/video/Makefile | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
>> index cdb7d9a54d..2374b240c2 100644
>> --- a/drivers/video/Makefile
>> +++ b/drivers/video/Makefile
>> @@ -68,3 +68,12 @@ obj-$(CONFIG_VIDEO_ZYNQMP_DPSUB) += zynqmp_dpsub.o
>>
>>   obj-y += bridge/
>>   obj-y += sunxi/
>> +
>> +ifdef CONFIG_SPL_BUILD
>> +obj-$(CONFIG_SPL_BACKLIGHT) += backlight-uclass.o
>> +obj-$(CONFIG_SPL_PANEL) += panel-uclass.o
>> +obj-$(CONFIG_SPL_SIMPLE_PANEL) += simple_panel.o
>> +obj-$(CONFIG_SPL_CONSOLE_NORMAL) += console_normal.o
>> +obj-$(CONFIG_SPL_VIDEO) += video-uclass.o vidconsole-uclass.o
>> +obj-$(CONFIG_SPL_VIDEO) += video_bmp.o
> 
> Can you use
> 
> obj-$(CONFIG_$(SPL_TPL_)VIDEO) += video_bmp.o
> 
> instead?
> 
> If I ever get back to the split config thing we'll need that.
> 
I can use obj-$(CONFIG_$(SPL_TPL_)VIDEO) += video_bmp.o.

>> +endif
>> --
>> 2.34.1
>>
> 
> Regards,
> Simon

Thanks,
Nikhil
diff mbox series

Patch

diff --git a/drivers/video/Makefile b/drivers/video/Makefile
index cdb7d9a54d..2374b240c2 100644
--- a/drivers/video/Makefile
+++ b/drivers/video/Makefile
@@ -68,3 +68,12 @@  obj-$(CONFIG_VIDEO_ZYNQMP_DPSUB) += zynqmp_dpsub.o
 
 obj-y += bridge/
 obj-y += sunxi/
+
+ifdef CONFIG_SPL_BUILD
+obj-$(CONFIG_SPL_BACKLIGHT) += backlight-uclass.o
+obj-$(CONFIG_SPL_PANEL) += panel-uclass.o
+obj-$(CONFIG_SPL_SIMPLE_PANEL) += simple_panel.o
+obj-$(CONFIG_SPL_CONSOLE_NORMAL) += console_normal.o
+obj-$(CONFIG_SPL_VIDEO) += video-uclass.o vidconsole-uclass.o
+obj-$(CONFIG_SPL_VIDEO) += video_bmp.o
+endif