| Message ID | 20230329120119.72886-4-n-jain1@ti.com |
|---|---|
| State | Superseded |
| Delegated to: | Anatolij Gustschin |
| Headers | show |
| Series | Add splash screen support at u-boot SPL | expand |
Hi Nikhil, Thanks for the patch. On 29/03/23 17:31, Nikhil M Jain wrote: > CONFIG_$(SPL_)VIDEO checks for CONFIG_SPL_VIDEO at SPL and CONFIG_VIDEO > at u-boot proper and compiles video driver at respective stage. > > Signed-off-by: Nikhil M Jain <n-jain1@ti.com> > --- > V4: > - No change > > V3 (patch introduced): > - Add rule to compile video driver at SPL > > drivers/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/Makefile b/drivers/Makefile > index 15d19d0c8a..6fd4d80206 100644 > --- a/drivers/Makefile > +++ b/drivers/Makefile > @@ -38,6 +38,7 @@ obj-$(CONFIG_$(SPL_TPL_)TPM) += tpm/ > obj-$(CONFIG_XEN) += xen/ > obj-$(CONFIG_$(SPL_)FPGA) += fpga/ > obj-y += bus/ > +obj-$(CONFIG_$(SPL_)VIDEO) += video/imho it should be obj-y +=video here (see below) > ifndef CONFIG_TPL_BUILD > ifndef CONFIG_VPL_BUILD > @@ -96,7 +97,6 @@ obj-y += rtc/ > obj-y += scsi/ > obj-y += sound/ > obj-y += spmi/ > -obj-y += video/ Looks to me we are breaking backward compatibility here. For e.g. I think configs/pinebook_defconfig only enables CONFIG_VIDEO_BRIDGE now it has to enable CONFIG_VIDEO explicitly too ? Regards Devarsh
diff --git a/drivers/Makefile b/drivers/Makefile index 15d19d0c8a..6fd4d80206 100644 --- a/drivers/Makefile +++ b/drivers/Makefile @@ -38,6 +38,7 @@ obj-$(CONFIG_$(SPL_TPL_)TPM) += tpm/ obj-$(CONFIG_XEN) += xen/ obj-$(CONFIG_$(SPL_)FPGA) += fpga/ obj-y += bus/ +obj-$(CONFIG_$(SPL_)VIDEO) += video/ ifndef CONFIG_TPL_BUILD ifndef CONFIG_VPL_BUILD @@ -96,7 +97,6 @@ obj-y += rtc/ obj-y += scsi/ obj-y += sound/ obj-y += spmi/ -obj-y += video/ obj-y += watchdog/ obj-$(CONFIG_QE) += qe/ obj-$(CONFIG_U_QE) += qe/
CONFIG_$(SPL_)VIDEO checks for CONFIG_SPL_VIDEO at SPL and CONFIG_VIDEO at u-boot proper and compiles video driver at respective stage. Signed-off-by: Nikhil M Jain <n-jain1@ti.com> --- V4: - No change V3 (patch introduced): - Add rule to compile video driver at SPL drivers/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)