Message ID | 20230306145354.7439-4-marex@denx.de |
---|---|
State | Accepted |
Commit | 2e0bade78542998134378ae33c50b054532b70a1 |
Delegated to: | Stefano Babic |
Headers | show |
Series | [v4,01/14] clk: imx8mp: Add EQoS MAC clock | expand |
> The dm_gpio_free() is never called, because for stm32, the phy_reset_gpio > pointer is never valid. This is because only tegra186 ever claims the > phy_reset_gpio, all other platforms use the PHY framework to reset the > PHY instead. Drop the dm_gpio_free() and dm_gpio_is_valid(). > Reviewed-by: Ramon Fried <rfried.dev@gmail.com> > Signed-off-by: Marek Vasut <marex@denx.de> Applied to u-boot-imx, next, thanks ! Best regards, Stefano Babic
diff --git a/drivers/net/dwc_eth_qos.c b/drivers/net/dwc_eth_qos.c index 00690b28ca6..b97b3ea2db6 100644 --- a/drivers/net/dwc_eth_qos.c +++ b/drivers/net/dwc_eth_qos.c @@ -1493,7 +1493,7 @@ static int eqos_remove_resources_tegra186(struct udevice *dev) static int eqos_remove_resources_stm32(struct udevice *dev) { - struct eqos_priv *eqos = dev_get_priv(dev); + struct eqos_priv * __maybe_unused eqos = dev_get_priv(dev); debug("%s(dev=%p):\n", __func__, dev); @@ -1505,9 +1505,6 @@ static int eqos_remove_resources_stm32(struct udevice *dev) clk_free(&eqos->clk_ck); #endif - if (dm_gpio_is_valid(&eqos->phy_reset_gpio)) - dm_gpio_free(dev, &eqos->phy_reset_gpio); - debug("%s: OK\n", __func__); return 0; }