| Message ID | 20230212231638.1134219-12-sjg@chromium.org |
|---|---|
| State | RFC |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | RFC: Migrate to split config | expand |
On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > This converts 1 usage of this option to the non-SPL form, since there is > no SPL_PHY_CADENCE_SIERRA defined in Kconfig > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > (no changes since v1) > > drivers/phy/cadence/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/cadence/Makefile b/drivers/phy/cadence/Makefile > index af63b32d9f5..c247feb8262 100644 > --- a/drivers/phy/cadence/Makefile > +++ b/drivers/phy/cadence/Makefile > @@ -1,2 +1,2 @@ > -obj-$(CONFIG_$(SPL_)PHY_CADENCE_SIERRA) += phy-cadence-sierra.o > +obj-$(CONFIG_PHY_CADENCE_SIERRA) += phy-cadence-sierra.o > obj-$(CONFIG_$(SPL_)PHY_CADENCE_TORRENT) += phy-cadence-torrent.o This, and then PHY_CADENCE_TORRENT take this the wrong direction, both symbols should be false for non-PPL builds.
Hi Tom, On Tue, 14 Feb 2023 at 09:31, Tom Rini <trini@konsulko.com> wrote: > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > > This converts 1 usage of this option to the non-SPL form, since there is > > no SPL_PHY_CADENCE_SIERRA defined in Kconfig > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > (no changes since v1) > > > > drivers/phy/cadence/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/phy/cadence/Makefile b/drivers/phy/cadence/Makefile > > index af63b32d9f5..c247feb8262 100644 > > --- a/drivers/phy/cadence/Makefile > > +++ b/drivers/phy/cadence/Makefile > > @@ -1,2 +1,2 @@ > > -obj-$(CONFIG_$(SPL_)PHY_CADENCE_SIERRA) += phy-cadence-sierra.o > > +obj-$(CONFIG_PHY_CADENCE_SIERRA) += phy-cadence-sierra.o > > obj-$(CONFIG_$(SPL_)PHY_CADENCE_TORRENT) += phy-cadence-torrent.o > > This, and then PHY_CADENCE_TORRENT take this the wrong direction, both > symbols should be false for non-PPL builds. This one is odd, since the board defines SPL_PHY, presumably for a reason. It could always undefine that if needed. I'll add some more notes in v5. Regards, SImon
On Tue, Feb 21, 2023 at 12:35:41PM -0700, Simon Glass wrote: > Hi Tom, > > On Tue, 14 Feb 2023 at 09:31, Tom Rini <trini@konsulko.com> wrote: > > > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > > > This converts 1 usage of this option to the non-SPL form, since there is > > > no SPL_PHY_CADENCE_SIERRA defined in Kconfig > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > --- > > > > > > (no changes since v1) > > > > > > drivers/phy/cadence/Makefile | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/phy/cadence/Makefile b/drivers/phy/cadence/Makefile > > > index af63b32d9f5..c247feb8262 100644 > > > --- a/drivers/phy/cadence/Makefile > > > +++ b/drivers/phy/cadence/Makefile > > > @@ -1,2 +1,2 @@ > > > -obj-$(CONFIG_$(SPL_)PHY_CADENCE_SIERRA) += phy-cadence-sierra.o > > > +obj-$(CONFIG_PHY_CADENCE_SIERRA) += phy-cadence-sierra.o > > > obj-$(CONFIG_$(SPL_)PHY_CADENCE_TORRENT) += phy-cadence-torrent.o > > > > This, and then PHY_CADENCE_TORRENT take this the wrong direction, both > > symbols should be false for non-PPL builds. > > This one is odd, since the board defines SPL_PHY, presumably for a > reason. It could always undefine that if needed. > > I'll add some more notes in v5. The platforms in question are fairly complex and I want to say it needs a PHY for USB in SPL, but not a PHY for networking, in SPL.
Hi Tom, On Tue, 21 Feb 2023 at 16:02, Tom Rini <trini@konsulko.com> wrote: > > On Tue, Feb 21, 2023 at 12:35:41PM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Tue, 14 Feb 2023 at 09:31, Tom Rini <trini@konsulko.com> wrote: > > > > > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > > > > This converts 1 usage of this option to the non-SPL form, since there is > > > > no SPL_PHY_CADENCE_SIERRA defined in Kconfig > > > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > > --- > > > > > > > > (no changes since v1) > > > > > > > > drivers/phy/cadence/Makefile | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/phy/cadence/Makefile b/drivers/phy/cadence/Makefile > > > > index af63b32d9f5..c247feb8262 100644 > > > > --- a/drivers/phy/cadence/Makefile > > > > +++ b/drivers/phy/cadence/Makefile > > > > @@ -1,2 +1,2 @@ > > > > -obj-$(CONFIG_$(SPL_)PHY_CADENCE_SIERRA) += phy-cadence-sierra.o > > > > +obj-$(CONFIG_PHY_CADENCE_SIERRA) += phy-cadence-sierra.o > > > > obj-$(CONFIG_$(SPL_)PHY_CADENCE_TORRENT) += phy-cadence-torrent.o > > > > > > This, and then PHY_CADENCE_TORRENT take this the wrong direction, both > > > symbols should be false for non-PPL builds. > > > > This one is odd, since the board defines SPL_PHY, presumably for a > > reason. It could always undefine that if needed. > > > > I'll add some more notes in v5. > > The platforms in question are fairly complex and I want to say it needs > a PHY for USB in SPL, but not a PHY for networking, in SPL. Ah that makes more sense. OK, will take yet another look. Regards, Simon
Hi Tom, On Tue, 21 Feb 2023 at 16:09, Simon Glass <sjg@chromium.org> wrote: > > Hi Tom, > > On Tue, 21 Feb 2023 at 16:02, Tom Rini <trini@konsulko.com> wrote: > > > > On Tue, Feb 21, 2023 at 12:35:41PM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 14 Feb 2023 at 09:31, Tom Rini <trini@konsulko.com> wrote: > > > > > > > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > > > > > This converts 1 usage of this option to the non-SPL form, since there is > > > > > no SPL_PHY_CADENCE_SIERRA defined in Kconfig > > > > > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > > > --- > > > > > > > > > > (no changes since v1) > > > > > > > > > > drivers/phy/cadence/Makefile | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/phy/cadence/Makefile b/drivers/phy/cadence/Makefile > > > > > index af63b32d9f5..c247feb8262 100644 > > > > > --- a/drivers/phy/cadence/Makefile > > > > > +++ b/drivers/phy/cadence/Makefile > > > > > @@ -1,2 +1,2 @@ > > > > > -obj-$(CONFIG_$(SPL_)PHY_CADENCE_SIERRA) += phy-cadence-sierra.o > > > > > +obj-$(CONFIG_PHY_CADENCE_SIERRA) += phy-cadence-sierra.o > > > > > obj-$(CONFIG_$(SPL_)PHY_CADENCE_TORRENT) += phy-cadence-torrent.o > > > > > > > > This, and then PHY_CADENCE_TORRENT take this the wrong direction, both > > > > symbols should be false for non-PPL builds. > > > > > > This one is odd, since the board defines SPL_PHY, presumably for a > > > reason. It could always undefine that if needed. > > > > > > I'll add some more notes in v5. > > > > The platforms in question are fairly complex and I want to say it needs > > a PHY for USB in SPL, but not a PHY for networking, in SPL. > > Ah that makes more sense. OK, will take yet another look. I'll just drop this patch. Regards, Simon
diff --git a/drivers/phy/cadence/Makefile b/drivers/phy/cadence/Makefile index af63b32d9f5..c247feb8262 100644 --- a/drivers/phy/cadence/Makefile +++ b/drivers/phy/cadence/Makefile @@ -1,2 +1,2 @@ -obj-$(CONFIG_$(SPL_)PHY_CADENCE_SIERRA) += phy-cadence-sierra.o +obj-$(CONFIG_PHY_CADENCE_SIERRA) += phy-cadence-sierra.o obj-$(CONFIG_$(SPL_)PHY_CADENCE_TORRENT) += phy-cadence-torrent.o
This converts 1 usage of this option to the non-SPL form, since there is no SPL_PHY_CADENCE_SIERRA defined in Kconfig Signed-off-by: Simon Glass <sjg@chromium.org> --- (no changes since v1) drivers/phy/cadence/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)