Message ID | 20230125184016.174122-2-heinrich.schuchardt@canonical.com |
---|---|
State | Accepted |
Commit | fe61da8c75d061f48237ef4d7618812739ccf789 |
Delegated to: | Marek Vasut |
Headers | show |
Series | usb: USB hubs require host mode | expand |
On 1/25/23 19:40, Heinrich Schuchardt wrote: > USB hubs run in host mode not in gadget mode. Hence, compiling usb_hub.c > should not be selected by CONFIG_USB_GADGET. > > Suggested-by: Marek Vasut <marex@denx.de> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by: Marek Vasut <marex@denx.de>
diff --git a/common/Makefile b/common/Makefile index 252e9656df..a50302d8b5 100644 --- a/common/Makefile +++ b/common/Makefile @@ -24,7 +24,7 @@ obj-$(CONFIG_CMD_MII) += miiphyutil.o obj-$(CONFIG_PHYLIB) += miiphyutil.o obj-$(CONFIG_USB_HOST) += usb.o usb_hub.o -obj-$(CONFIG_USB_GADGET) += usb.o usb_hub.o +obj-$(CONFIG_USB_GADGET) += usb.o obj-$(CONFIG_USB_STORAGE) += usb_storage.o obj-$(CONFIG_USB_ONBOARD_HUB) += usb_onboard_hub.o
USB hubs run in host mode not in gadget mode. Hence, compiling usb_hub.c should not be selected by CONFIG_USB_GADGET. Suggested-by: Marek Vasut <marex@denx.de> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> --- v2: new patch --- common/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)