| Message ID | 20230125184016.174122-3-heinrich.schuchardt@canonical.com |
|---|---|
| State | Accepted |
| Commit | 4042ce73c8bee9077d80a42b27aa21f98636b780 |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | usb: USB hubs require host mode | expand |
On 1/25/23 19:40, Heinrich Schuchardt wrote: > This configuration setting is only relevant if the board supports USB. > It should not be in the main menu but in the USB menu. > > The setting is only relevant in USB host mode. > > Fixes: 5454dea3137d ("usb: hub: allow to increase HUB_DEBOUNCE_TIMEOUT") > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> Reviewed-by: Marek Vasut <marex@denx.de>
Hi, On 1/25/23 19:40, Heinrich Schuchardt wrote: > This configuration setting is only relevant if the board supports USB. > It should not be in the main menu but in the USB menu. > > The setting is only relevant in USB host mode. > > Fixes: 5454dea3137d ("usb: hub: allow to increase HUB_DEBOUNCE_TIMEOUT") > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- > v2: > let CONFIG_USB_HUB_DEBOUNCE_TIMEOUT depend on CONFIG_USB_HOST > --- > common/Kconfig | 12 ------------ > drivers/usb/Kconfig | 11 +++++++++++ > 2 files changed, 11 insertions(+), 12 deletions(-) > > diff --git a/common/Kconfig b/common/Kconfig > index e3a5e1be1e..0afc01b759 100644 > --- a/common/Kconfig > +++ b/common/Kconfig > @@ -1106,15 +1106,3 @@ config FDT_SIMPLEFB > > config IO_TRACE > bool > - > -config USB_HUB_DEBOUNCE_TIMEOUT > - int "Timeout in milliseconds for USB HUB connection" > - depends on USB > - default 1000 > - help > - Value in milliseconds of the USB connection timeout, the max delay to > - wait the hub port status to be connected steadily after being powered > - off and powered on in the usb hub driver. > - This define allows to increase the HUB_DEBOUNCE_TIMEOUT default > - value = 1s because some usb device needs around 1.5s to be initialized > - and a 2s value should solve detection issue on problematic USB keys. > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > index ebe6bf9498..94fb32d107 100644 > --- a/drivers/usb/Kconfig > +++ b/drivers/usb/Kconfig > @@ -115,6 +115,17 @@ config USB_ONBOARD_HUB > power regulator. An example for such a hub is the Microchip > USB2514B. > > +config USB_HUB_DEBOUNCE_TIMEOUT > + int "Timeout in milliseconds for USB HUB connection" > + default 1000 > + help > + Value in milliseconds of the USB connection timeout, the max delay to > + wait the hub port status to be connected steadily after being powered > + off and powered on in the usb hub driver. > + This define allows to increase the HUB_DEBOUNCE_TIMEOUT default > + value = 1s because some usb device needs around 1.5s to be initialized > + and a 2s value should solve detection issue on problematic USB keys. > + > if USB_KEYBOARD > > config USB_KEYBOARD_FN_KEYS Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
On 2/23/23 11:10, Patrick DELAUNAY wrote: > Hi, > > On 1/25/23 19:40, Heinrich Schuchardt wrote: >> This configuration setting is only relevant if the board supports USB. >> It should not be in the main menu but in the USB menu. >> >> The setting is only relevant in USB host mode. >> >> Fixes: 5454dea3137d ("usb: hub: allow to increase HUB_DEBOUNCE_TIMEOUT") >> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> >> --- >> v2: >> let CONFIG_USB_HUB_DEBOUNCE_TIMEOUT depend on CONFIG_USB_HOST >> --- >> common/Kconfig | 12 ------------ >> drivers/usb/Kconfig | 11 +++++++++++ >> 2 files changed, 11 insertions(+), 12 deletions(-) >> >> diff --git a/common/Kconfig b/common/Kconfig >> index e3a5e1be1e..0afc01b759 100644 >> --- a/common/Kconfig >> +++ b/common/Kconfig >> @@ -1106,15 +1106,3 @@ config FDT_SIMPLEFB >> config IO_TRACE >> bool >> - >> -config USB_HUB_DEBOUNCE_TIMEOUT >> - int "Timeout in milliseconds for USB HUB connection" >> - depends on USB >> - default 1000 >> - help >> - Value in milliseconds of the USB connection timeout, the max >> delay to >> - wait the hub port status to be connected steadily after being >> powered >> - off and powered on in the usb hub driver. >> - This define allows to increase the HUB_DEBOUNCE_TIMEOUT default >> - value = 1s because some usb device needs around 1.5s to be >> initialized >> - and a 2s value should solve detection issue on problematic USB >> keys. >> diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig >> index ebe6bf9498..94fb32d107 100644 >> --- a/drivers/usb/Kconfig >> +++ b/drivers/usb/Kconfig >> @@ -115,6 +115,17 @@ config USB_ONBOARD_HUB >> power regulator. An example for such a hub is the Microchip >> USB2514B. >> +config USB_HUB_DEBOUNCE_TIMEOUT >> + int "Timeout in milliseconds for USB HUB connection" >> + default 1000 >> + help >> + Value in milliseconds of the USB connection timeout, the max >> delay to >> + wait the hub port status to be connected steadily after being >> powered >> + off and powered on in the usb hub driver. >> + This define allows to increase the HUB_DEBOUNCE_TIMEOUT default >> + value = 1s because some usb device needs around 1.5s to be >> initialized >> + and a 2s value should solve detection issue on problematic USB >> keys. >> + >> if USB_KEYBOARD >> config USB_KEYBOARD_FN_KEYS > > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Applied both to usb/master, thanks for the reminder, sorry for the delay.
diff --git a/common/Kconfig b/common/Kconfig index e3a5e1be1e..0afc01b759 100644 --- a/common/Kconfig +++ b/common/Kconfig @@ -1106,15 +1106,3 @@ config FDT_SIMPLEFB config IO_TRACE bool - -config USB_HUB_DEBOUNCE_TIMEOUT - int "Timeout in milliseconds for USB HUB connection" - depends on USB - default 1000 - help - Value in milliseconds of the USB connection timeout, the max delay to - wait the hub port status to be connected steadily after being powered - off and powered on in the usb hub driver. - This define allows to increase the HUB_DEBOUNCE_TIMEOUT default - value = 1s because some usb device needs around 1.5s to be initialized - and a 2s value should solve detection issue on problematic USB keys. diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index ebe6bf9498..94fb32d107 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -115,6 +115,17 @@ config USB_ONBOARD_HUB power regulator. An example for such a hub is the Microchip USB2514B. +config USB_HUB_DEBOUNCE_TIMEOUT + int "Timeout in milliseconds for USB HUB connection" + default 1000 + help + Value in milliseconds of the USB connection timeout, the max delay to + wait the hub port status to be connected steadily after being powered + off and powered on in the usb hub driver. + This define allows to increase the HUB_DEBOUNCE_TIMEOUT default + value = 1s because some usb device needs around 1.5s to be initialized + and a 2s value should solve detection issue on problematic USB keys. + if USB_KEYBOARD config USB_KEYBOARD_FN_KEYS
This configuration setting is only relevant if the board supports USB. It should not be in the main menu but in the USB menu. The setting is only relevant in USB host mode. Fixes: 5454dea3137d ("usb: hub: allow to increase HUB_DEBOUNCE_TIMEOUT") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> --- v2: let CONFIG_USB_HUB_DEBOUNCE_TIMEOUT depend on CONFIG_USB_HOST --- common/Kconfig | 12 ------------ drivers/usb/Kconfig | 11 +++++++++++ 2 files changed, 11 insertions(+), 12 deletions(-)