| Message ID | 20220218122844.2493-1-lukma@denx.de |
|---|---|
| State | Accepted |
| Commit | 497f57cfc259d5fba4d1e5098c8fb90d43f14e96 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [1/3] arm: mmc: Add "ti, am335-sdhci" compatible for TI's omap_hsmmc driver | expand |
On 2/18/22 21:28, Lukasz Majewski wrote: > In the Linux kernel (v5.16) for this SoC there are two separate drivers > - namely sdhci-omap.c and omap_hsmmc.c which have separate set of > compatibles. > > The U-Boot's drivers/mmc/omap_hsmmc.c driver supports both eMMC and > SD devices - hence the compatible for SDHCI can be added. > > After this change the am335x DTS description can be easier ported > from Linux kernel. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Best Regards, Jaehoon Chung > --- > > drivers/mmc/omap_hsmmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c > index 820065800f..b2f4a4e721 100644 > --- a/drivers/mmc/omap_hsmmc.c > +++ b/drivers/mmc/omap_hsmmc.c > @@ -2019,6 +2019,7 @@ static const struct udevice_id omap_hsmmc_ids[] = { > { .compatible = "ti,omap3-hsmmc" }, > { .compatible = "ti,omap4-hsmmc" }, > { .compatible = "ti,am33xx-hsmmc" }, > + { .compatible = "ti,am335-sdhci" }, > { .compatible = "ti,dra7-hsmmc", .data = (ulong)&dra7_mmc_of_data }, > { } > };
Hi Tom, > In the Linux kernel (v5.16) for this SoC there are two separate > drivers > - namely sdhci-omap.c and omap_hsmmc.c which have separate set of > compatibles. > > The U-Boot's drivers/mmc/omap_hsmmc.c driver supports both eMMC and > SD devices - hence the compatible for SDHCI can be added. > > After this change the am335x DTS description can be easier ported > from Linux kernel. > Gentle ping on this patch series. > Signed-off-by: Lukasz Majewski <lukma@denx.de> > --- > > drivers/mmc/omap_hsmmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c > index 820065800f..b2f4a4e721 100644 > --- a/drivers/mmc/omap_hsmmc.c > +++ b/drivers/mmc/omap_hsmmc.c > @@ -2019,6 +2019,7 @@ static const struct udevice_id omap_hsmmc_ids[] > = { { .compatible = "ti,omap3-hsmmc" }, > { .compatible = "ti,omap4-hsmmc" }, > { .compatible = "ti,am33xx-hsmmc" }, > + { .compatible = "ti,am335-sdhci" }, > { .compatible = "ti,dra7-hsmmc", .data = > (ulong)&dra7_mmc_of_data }, { } > }; Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Fri, Feb 18, 2022 at 01:28:41PM +0100, Lukasz Majewski wrote: > In the Linux kernel (v5.16) for this SoC there are two separate drivers > - namely sdhci-omap.c and omap_hsmmc.c which have separate set of > compatibles. > > The U-Boot's drivers/mmc/omap_hsmmc.c driver supports both eMMC and > SD devices - hence the compatible for SDHCI can be added. > > After this change the am335x DTS description can be easier ported > from Linux kernel. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com> Applied to u-boot/next, thanks!
diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c index 820065800f..b2f4a4e721 100644 --- a/drivers/mmc/omap_hsmmc.c +++ b/drivers/mmc/omap_hsmmc.c @@ -2019,6 +2019,7 @@ static const struct udevice_id omap_hsmmc_ids[] = { { .compatible = "ti,omap3-hsmmc" }, { .compatible = "ti,omap4-hsmmc" }, { .compatible = "ti,am33xx-hsmmc" }, + { .compatible = "ti,am335-sdhci" }, { .compatible = "ti,dra7-hsmmc", .data = (ulong)&dra7_mmc_of_data }, { } };
In the Linux kernel (v5.16) for this SoC there are two separate drivers - namely sdhci-omap.c and omap_hsmmc.c which have separate set of compatibles. The U-Boot's drivers/mmc/omap_hsmmc.c driver supports both eMMC and SD devices - hence the compatible for SDHCI can be added. After this change the am335x DTS description can be easier ported from Linux kernel. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- drivers/mmc/omap_hsmmc.c | 1 + 1 file changed, 1 insertion(+)