diff mbox series

[v2,03/38] mkimage: Show the external-offset error

Message ID 20220110031413.1970836-4-sjg@chromium.org
State Accepted
Commit 206117afd137c88f0b0974088a9008bdf123eeb8
Delegated to: Simon Glass
Headers show
Series binman: Add support for bintools and missing tools | expand

Commit Message

Simon Glass Jan. 10, 2022, 3:13 a.m. UTC 
This is a debug message at present, which is not very helpful. Print out
the error so that action can be taken.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 tools/fit_image.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Simon Glass Jan. 26, 2022, 3:37 p.m. UTC | #1 
This is a debug message at present, which is not very helpful. Print out
the error so that action can be taken.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 tools/fit_image.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Applied to u-boot-dm, thanks!
diff mbox series

Patch

diff --git a/tools/fit_image.c b/tools/fit_image.c
index f4f372ba62f..d5cab96a9b4 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -524,8 +524,9 @@  static int fit_extract_data(struct image_tool_params *params, const char *fname)
 	/* Check if an offset for the external data was set. */
 	if (params->external_offset > 0) {
 		if (params->external_offset < new_size) {
-			debug("External offset %x overlaps FIT length %x\n",
-			      params->external_offset, new_size);
+			fprintf(stderr,
+				"External offset %x overlaps FIT length %x\n",
+				params->external_offset, new_size);
 			ret = -EINVAL;
 			goto err;
 		}