From patchwork Mon Jan 10 03:13:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1577707 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=DAaNx7/0; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4JXJqx1G5Cz9s9c for ; Mon, 10 Jan 2022 14:15:57 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D095C830EB; Mon, 10 Jan 2022 04:15:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="DAaNx7/0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 882528197D; Mon, 10 Jan 2022 04:15:17 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6A3CD81951 for ; Mon, 10 Jan 2022 04:15:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-io1-xd31.google.com with SMTP id y11so15727549iod.6 for ; Sun, 09 Jan 2022 19:15:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TjxNdAFSIysy8e4HuxY0nQYbakjw3QiMC5CnJFFCDzU=; b=DAaNx7/08SNeWhzqTFTW7C/zcPbe9o7hmpLLQnH1GhtEGbTfNinplBSGdshTwQ4C+E QyvzpJfktj2jKN6+uXQPYJVv55SPRUA3ydFXwokYyh9Yiqs0EE97hPPHY1HwzuMTZ4Sr t5Wdq1oY6IkgbMygfAu6Y94oT84SidhN7YwyI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TjxNdAFSIysy8e4HuxY0nQYbakjw3QiMC5CnJFFCDzU=; b=dDQVlxQ84xMyGFa1aGgzfAGu+vqmbYEdAMD/Ll+HlnTscp2lUjydBPIbhlqMj0Tenp JaUP5MJ1sViOVJo9Gy9LTEuDtms327Qu9q5Brq72kwSHEyPdMX9UYFe0Oo2Tee9Ew3lE yfBZxSVLYQyydJS1w24dAFOsuEva8vJe9cREVJEa8TI+cIlgfAtE3aGYUQ+XCqc3LdGB KD20WLcI14InJTOSpAfWYmBVURYztbqrTctldd3zAirV/70Tna7ItsPYoygyBu15uueU s54oPcckAsVcICL/bG4ZhLI6Su/z3cHBTgzJxU3Ljypf2KbXDT72DpygH3mFzewaTX+f V8Uw== X-Gm-Message-State: AOAM530jnNwkpdr01t9pH3mfIvujzCT5Osu5QNZLeh3FYFvjOw1JG/Tl 6oO1CTGoENTI/g8qhBYDGvXgBbcBq14xQg== X-Google-Smtp-Source: ABdhPJyyULNPzx8MpHlDTWU4eap0ZHQJtbTjZy7/qUmlWG5vs7gZSBJvLBNtd0Aiu4YZ0iQj8oAAVA== X-Received: by 2002:a05:6602:1487:: with SMTP id a7mr5200449iow.95.1641784509063; Sun, 09 Jan 2022 19:15:09 -0800 (PST) Received: from sjg1.roam.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id d16sm3542182ioy.29.2022.01.09.19.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Jan 2022 19:15:08 -0800 (PST) From: Simon Glass To: U-Boot Mailing List Cc: Simon Glass , Joe Hershberger , Marek Vasut , Stefano Babic Subject: [PATCH v2 03/38] mkimage: Show the external-offset error Date: Sun, 9 Jan 2022 20:13:38 -0700 Message-Id: <20220110031413.1970836-4-sjg@chromium.org> X-Mailer: git-send-email 2.34.1.575.g55b058a8bb-goog In-Reply-To: <20220110031413.1970836-1-sjg@chromium.org> References: <20220110031413.1970836-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean This is a debug message at present, which is not very helpful. Print out the error so that action can be taken. Signed-off-by: Simon Glass Signed-off-by: Simon Glass --- (no changes since v1) tools/fit_image.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/fit_image.c b/tools/fit_image.c index f4f372ba62f..d5cab96a9b4 100644 --- a/tools/fit_image.c +++ b/tools/fit_image.c @@ -524,8 +524,9 @@ static int fit_extract_data(struct image_tool_params *params, const char *fname) /* Check if an offset for the external data was set. */ if (params->external_offset > 0) { if (params->external_offset < new_size) { - debug("External offset %x overlaps FIT length %x\n", - params->external_offset, new_size); + fprintf(stderr, + "External offset %x overlaps FIT length %x\n", + params->external_offset, new_size); ret = -EINVAL; goto err; }