diff mbox series

[v2,2/4] xea: defconfig: Update defconfig to support mtd partitions r/w by name

Message ID 20211227104641.428-2-lukma@denx.de
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show
Series [v2,1/4] xea: dts: Update the SPI-NOR flash memory partitions description | expand

Commit Message

Lukasz Majewski Dec. 27, 2021, 10:46 a.m. UTC 
After this change it would be possible to use 'mtd' command to get access
to XEA's SPI-NOR partitions by name (e.g. SPL), not by offsets.

To enable this feature the CONFIG_SPI_FLASH_MTD needs to be defined in the
Kconfig, not in xea.h.

=> mtd list
=> mtd read spl-boot-data1 ${loadaddr} 0x0 4
=> md.l ${loadaddr} 1

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---

(no changes since v1)

 configs/imx28_xea_defconfig | 4 ++--
 include/configs/xea.h       | 4 ----
 2 files changed, 2 insertions(+), 6 deletions(-)

Comments

Stefano Babic Feb. 19, 2022, 1:07 p.m. UTC | #1 
> After this change it would be possible to use 'mtd' command to get access
> to XEA's SPI-NOR partitions by name (e.g. SPL), not by offsets.
> To enable this feature the CONFIG_SPI_FLASH_MTD needs to be defined in the
> Kconfig, not in xea.h.
> => mtd list
> => mtd read spl-boot-data1 ${loadaddr} 0x0 4
> => md.l ${loadaddr} 1
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/configs/imx28_xea_defconfig b/configs/imx28_xea_defconfig
index 63ab8349cd..5566945183 100644
--- a/configs/imx28_xea_defconfig
+++ b/configs/imx28_xea_defconfig
@@ -60,8 +60,6 @@  CONFIG_CMD_REGULATOR=y
 CONFIG_CMD_EXT4=y
 CONFIG_CMD_FS_GENERIC=y
 CONFIG_CMD_MTDPARTS=y
-CONFIG_MTDIDS_DEFAULT="nor0=spi3.0"
-CONFIG_MTDPARTS_DEFAULT="spi3.0:64k(SPL),448k(uboot),128k(envs),384k(unused1),4096k(kernel),8192k(swupdate),-(unused2)"
 CONFIG_DOS_PARTITION=y
 CONFIG_OF_CONTROL=y
 CONFIG_SPL_OF_CONTROL=y
@@ -87,6 +85,7 @@  CONFIG_MXS_GPIO=y
 CONFIG_SUPPORT_EMMC_BOOT=y
 CONFIG_MMC_MXS=y
 CONFIG_MTD=y
+CONFIG_DM_MTD=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SF_DEFAULT_BUS=3
 CONFIG_SF_DEFAULT_MODE=0x0
@@ -96,6 +95,7 @@  CONFIG_SPI_FLASH_ISSI=y
 CONFIG_SPI_FLASH_SPANSION=y
 CONFIG_SPI_FLASH_STMICRO=y
 # CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
+CONFIG_SPI_FLASH_MTD=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_ADDR_ENABLE=y
 CONFIG_PHY_ADDR=1
diff --git a/include/configs/xea.h b/include/configs/xea.h
index 5081cc8691..c3f25b5aa1 100644
--- a/include/configs/xea.h
+++ b/include/configs/xea.h
@@ -29,10 +29,6 @@ 
 #define CONFIG_SYS_MMCSD_RAW_MODE_ARGS_SECTORS	(SZ_32K / 0x200)
 #define CONFIG_SYS_MMCSD_RAW_MODE_KERNEL_SECTOR	(SZ_1M / 0x200)
 
-#ifndef CONFIG_SPL_BUILD
-#define CONFIG_SPI_FLASH_MTD
-#endif
-
 /* Memory configuration */
 #define PHYS_SDRAM_1			0x40000000	/* Base address */
 #define PHYS_SDRAM_1_SIZE		0x10000000	/* Max 256 MB RAM */