diff mbox series

[v2,1/4] xea: dts: Update the SPI-NOR flash memory partitions description

Message ID 20211227104641.428-1-lukma@denx.de
State Accepted
Commit 1e7212ee9f0f856214f014364a308dca1fb420b3
Delegated to: Stefano Babic
Headers show
Series [v2,1/4] xea: dts: Update the SPI-NOR flash memory partitions description | expand

Commit Message

Lukasz Majewski Dec. 27, 2021, 10:46 a.m. UTC
Now the dts information corresponds to the one available in the kernel.
With this patch applied the 'mtd list' shows proper names and
offsets for MTD partitions.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---

(no changes since v1)

 arch/arm/dts/imx28-xea.dts | 55 +++++++++++++++++++++++---------------
 1 file changed, 34 insertions(+), 21 deletions(-)

Comments

Tom Rini Dec. 27, 2021, 12:43 p.m. UTC | #1
On Mon, Dec 27, 2021 at 11:46:38AM +0100, Lukasz Majewski wrote:

> Now the dts information corresponds to the one available in the kernel.
> With this patch applied the 'mtd list' shows proper names and
> offsets for MTD partitions.
> 
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

And this has been submitted upstream, yes?
Lukasz Majewski Dec. 27, 2021, 1:20 p.m. UTC | #2
Hi Tom,

> On Mon, Dec 27, 2021 at 11:46:38AM +0100, Lukasz Majewski wrote:
> 
> > Now the dts information corresponds to the one available in the
> > kernel. With this patch applied the 'mtd list' shows proper names
> > and offsets for MTD partitions.
> > 
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>  
> 
> And this has been submitted upstream, yes?
> 

The code has been modified to support the 'mtd' command and setting
partition info from DTS.

Now it is possible to remove MTDIDS and MTDPARTS Kconfig variables.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Tom Rini Dec. 27, 2021, 1:21 p.m. UTC | #3
On Mon, Dec 27, 2021 at 02:20:04PM +0100, Lukasz Majewski wrote:
> Hi Tom,
> 
> > On Mon, Dec 27, 2021 at 11:46:38AM +0100, Lukasz Majewski wrote:
> > 
> > > Now the dts information corresponds to the one available in the
> > > kernel. With this patch applied the 'mtd list' shows proper names
> > > and offsets for MTD partitions.
> > > 
> > > Signed-off-by: Lukasz Majewski <lukma@denx.de>  
> > 
> > And this has been submitted upstream, yes?
> > 
> 
> The code has been modified to support the 'mtd' command and setting
> partition info from DTS.
> 
> Now it is possible to remove MTDIDS and MTDPARTS Kconfig variables.

Right.  And have you updated / are you updating the upstream dts file?
Lukasz Majewski Dec. 27, 2021, 2:59 p.m. UTC | #4
Hi Tom,

> On Mon, Dec 27, 2021 at 02:20:04PM +0100, Lukasz Majewski wrote:
> > Hi Tom,
> >   
> > > On Mon, Dec 27, 2021 at 11:46:38AM +0100, Lukasz Majewski wrote:
> > >   
> > > > Now the dts information corresponds to the one available in the
> > > > kernel. With this patch applied the 'mtd list' shows proper
> > > > names and offsets for MTD partitions.
> > > > 
> > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>    
> > > 
> > > And this has been submitted upstream, yes?
> > >   
> > 
> > The code has been modified to support the 'mtd' command and setting
> > partition info from DTS.
> > 
> > Now it is possible to remove MTDIDS and MTDPARTS Kconfig variables.
> >  
> 
> Right.  And have you updated / are you updating the upstream dts file?
> 

Yes, I do update the u-boot DTS upstream file.

(And this corresponds to the SPI-NOR layout that we do have in the
kernel upstream DTS code).


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
Tom Rini Dec. 27, 2021, 3 p.m. UTC | #5
On Mon, Dec 27, 2021 at 03:59:28PM +0100, Lukasz Majewski wrote:
> Hi Tom,
> 
> > On Mon, Dec 27, 2021 at 02:20:04PM +0100, Lukasz Majewski wrote:
> > > Hi Tom,
> > >   
> > > > On Mon, Dec 27, 2021 at 11:46:38AM +0100, Lukasz Majewski wrote:
> > > >   
> > > > > Now the dts information corresponds to the one available in the
> > > > > kernel. With this patch applied the 'mtd list' shows proper
> > > > > names and offsets for MTD partitions.
> > > > > 
> > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de>    
> > > > 
> > > > And this has been submitted upstream, yes?
> > > >   
> > > 
> > > The code has been modified to support the 'mtd' command and setting
> > > partition info from DTS.
> > > 
> > > Now it is possible to remove MTDIDS and MTDPARTS Kconfig variables.
> > >  
> > 
> > Right.  And have you updated / are you updating the upstream dts file?
> > 
> 
> Yes, I do update the u-boot DTS upstream file.
> 
> (And this corresponds to the SPI-NOR layout that we do have in the
> kernel upstream DTS code).

OK, thanks.  In the future please note what kernel release you're
re-syncing this from.
Stefano Babic Feb. 5, 2022, 4:44 p.m. UTC | #6
> Now the dts information corresponds to the one available in the kernel.
> With this patch applied the 'mtd list' shows proper names and
> offsets for MTD partitions.
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/arch/arm/dts/imx28-xea.dts b/arch/arm/dts/imx28-xea.dts
index de049042f8..34af6cf67f 100644
--- a/arch/arm/dts/imx28-xea.dts
+++ b/arch/arm/dts/imx28-xea.dts
@@ -86,27 +86,40 @@ 
 		spi-max-frequency = <40000000>;
 		reg = <0>;
 
-		partition@0 {
-			label = "SPL (spi)";
-			reg = <0x0 0x10000>;
-			read-only;
-		};
-		partition@1 {
-			label = "u-boot (spi)";
-			reg = <0x10000 0x70000>;
-			read-only;
-		};
-		partition@2 {
-			label = "uboot-env (spi)";
-			reg = <0x80000 0x20000>;
-		};
-		partition@3 {
-			label = "kernel (spi)";
-			reg = <0x100000 0x400000>;
-		};
-		partition@4 {
-			label = "swupdate (spi)";
-			reg = <0x50000 0x800000>;
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			partition@0 {
+				    label = "SPL";
+				    reg = <0x0 0x10000>;
+				    read-only;
+			};
+			partition@10000 {
+				    label = "u-boot";
+				    reg = <0x10000 0x70000>;
+				    read-only;
+			};
+			partition@80000 {
+				    label = "uboot-env1";
+				    reg = <0x80000 0x10000>;
+			};
+			partition@90000 {
+				    label = "uboot-env2";
+				    reg = <0x90000 0x10000>;
+			};
+			partition@A0000 {
+				    label = "rescue";
+				    reg = <0xA0000 0xF40000>;
+			};
+			partition@FE0000 {
+				    label = "spl-boot-data1";
+				    reg = <0xFE0000 0x10000>;
+			};
+			partition@FF0000 {
+				    label = "spl-boot-data2";
+				    reg = <0xFF0000 0x10000>;
+			};
 		};
 	};
 };