| Message ID | 20210929055046.4326-2-bmeng.cn@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Ramon Fried |
| Headers | show |
| Series | [1/3] net: dsa: Use true instead of 1 in the set_promisc() call | expand |
On Wed, Sep 29, 2021 at 01:50:45PM +0800, Bin Meng wrote: > priv->promisc is used as the parameter of the set_promisc() call > which accepts a bool type instead of char. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > drivers/net/fec_mxc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h > index 62b55ef395..133f535917 100644 > --- a/drivers/net/fec_mxc.h > +++ b/drivers/net/fec_mxc.h > @@ -272,7 +272,7 @@ struct fec_priv { > struct clk clk_ref; > struct clk clk_ptp; > u32 clk_rate; > - char promisc; > + bool promisc; > }; > > /** > -- > 2.25.1 > Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
On Wed, Sep 29, 2021 at 4:32 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote: > > On Wed, Sep 29, 2021 at 01:50:45PM +0800, Bin Meng wrote: > > priv->promisc is used as the parameter of the set_promisc() call > > which accepts a bool type instead of char. > > > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > > --- > > > > drivers/net/fec_mxc.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h > > index 62b55ef395..133f535917 100644 > > --- a/drivers/net/fec_mxc.h > > +++ b/drivers/net/fec_mxc.h > > @@ -272,7 +272,7 @@ struct fec_priv { > > struct clk clk_ref; > > struct clk clk_ptp; > > u32 clk_rate; > > - char promisc; > > + bool promisc; > > }; > > > > /** > > -- > > 2.25.1 > > > > Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
diff --git a/drivers/net/fec_mxc.h b/drivers/net/fec_mxc.h index 62b55ef395..133f535917 100644 --- a/drivers/net/fec_mxc.h +++ b/drivers/net/fec_mxc.h @@ -272,7 +272,7 @@ struct fec_priv { struct clk clk_ref; struct clk clk_ptp; u32 clk_rate; - char promisc; + bool promisc; }; /**
priv->promisc is used as the parameter of the set_promisc() call which accepts a bool type instead of char. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- drivers/net/fec_mxc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)