diff mbox series

[u-boot,30/39] ARM: imx6m: fix imx_eqos_txclk_set_rate() type mismatch for LTO

Message ID 20210307042538.21229-31-marek.behun@nic.cz
State Superseded
Delegated to: Tom Rini
Headers show
Series U-Boot LTO (Sandbox + Some ARM boards) | expand

Commit Message

Marek Behún March 7, 2021, 4:25 a.m. UTC 
When building imx8mp_evk_defconfig with LTO, the compiler complains
about type mismatch of function imx_eqos_txclk_set_rate() in file
  drivers/net/dwc_eth_qos.c:845:12
which contains a weak definition of this function, vs file
  arch/arm/mach-imx/imx8m/clock_imx8mm.c
which contains an implementation.

Change the type of this function in the implementation to fix this.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
---
 arch/arm/mach-imx/imx8m/clock_imx8mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sean Anderson March 7, 2021, 5:33 a.m. UTC | #1 
> Re: [PATCH u-boot 30/39] ARM: imx6m: fix imx_eqos_txclk_set_rate() type mismatch for LTO

imx8m?

On 3/6/21 11:25 PM, Marek Behún wrote:
> When building imx8mp_evk_defconfig with LTO, the compiler complains
> about type mismatch of function imx_eqos_txclk_set_rate() in file
>    drivers/net/dwc_eth_qos.c:845:12
> which contains a weak definition of this function, vs file
>    arch/arm/mach-imx/imx8m/clock_imx8mm.c
> which contains an implementation.
> 
> Change the type of this function in the implementation to fix this.
> 
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
>   arch/arm/mach-imx/imx8m/clock_imx8mm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/imx8m/clock_imx8mm.c b/arch/arm/mach-imx/imx8m/clock_imx8mm.c
> index 4024dafca1..554ff0eaca 100644
> --- a/arch/arm/mach-imx/imx8m/clock_imx8mm.c
> +++ b/arch/arm/mach-imx/imx8m/clock_imx8mm.c
> @@ -838,7 +838,7 @@ int set_clk_eqos(enum enet_freq type)
>   	return 0;
>   }
>   
> -int imx_eqos_txclk_set_rate(u32 rate)
> +int imx_eqos_txclk_set_rate(ulong rate)
>   {
>   	u32 val;
>   	u32 eqos_post_div;
>
Marek Behún March 7, 2021, 12:13 p.m. UTC | #2 
THX
Bin Meng March 10, 2021, 5:27 a.m. UTC | #3 
On Sun, Mar 7, 2021 at 12:26 PM Marek Behún <marek.behun@nic.cz> wrote:
>
> When building imx8mp_evk_defconfig with LTO, the compiler complains
> about type mismatch of function imx_eqos_txclk_set_rate() in file
>   drivers/net/dwc_eth_qos.c:845:12
> which contains a weak definition of this function, vs file
>   arch/arm/mach-imx/imx8m/clock_imx8mm.c
> which contains an implementation.
>
> Change the type of this function in the implementation to fix this.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
>  arch/arm/mach-imx/imx8m/clock_imx8mm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff mbox series

Patch

diff --git a/arch/arm/mach-imx/imx8m/clock_imx8mm.c b/arch/arm/mach-imx/imx8m/clock_imx8mm.c
index 4024dafca1..554ff0eaca 100644
--- a/arch/arm/mach-imx/imx8m/clock_imx8mm.c
+++ b/arch/arm/mach-imx/imx8m/clock_imx8mm.c
@@ -838,7 +838,7 @@  int set_clk_eqos(enum enet_freq type)
 	return 0;
 }
 
-int imx_eqos_txclk_set_rate(u32 rate)
+int imx_eqos_txclk_set_rate(ulong rate)
 {
 	u32 val;
 	u32 eqos_post_div;