diff mbox series

[PATCHv2,1/9] board: lx2160a: Add header file cpu_func.h

Message ID 20200324081209.48449-2-Zhiqiang.Hou@nxp.com
State Changes Requested
Delegated to: Priyanka Jain
Headers show
Series fsl: layerscape: Initialize the GIC redistributor | expand

Commit Message

Z.Q. Hou March 24, 2020, 8:12 a.m. UTC 
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

The declaration of the function cpu_numcores() has been moved to
cpu_func.h, so add including of the header file to avoid build
error.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
V2:
 - No change.

 board/freescale/lx2160a/lx2160a.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Wasim Khan April 21, 2020, 5:40 a.m. UTC | #1 
> -----Original Message-----
> From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Zhiqiang Hou
> Sent: Tuesday, March 24, 2020 1:42 PM
> To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com>; Biwen Li
> <biwen.li@nxp.com>
> Cc: Z.q. Hou <zhiqiang.hou@nxp.com>
> Subject: [PATCHv2 1/9] board: lx2160a: Add header file cpu_func.h
> 
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> 
> The declaration of the function cpu_numcores() has been moved to cpu_func.h,
> so add including of the header file to avoid build error.
> 
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
> V2:
>  - No change.
> 
>  board/freescale/lx2160a/lx2160a.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/board/freescale/lx2160a/lx2160a.c
> b/board/freescale/lx2160a/lx2160a.c
> index 134ae22f85..595c774b42 100644
> --- a/board/freescale/lx2160a/lx2160a.c
> +++ b/board/freescale/lx2160a/lx2160a.c
> @@ -5,6 +5,7 @@
> 
>  #include <common.h>
>  #include <clock_legacy.h>
> +#include <cpu_func.h>

cpu_func.h is already included in board/freescale/lx2160a/lx2160a.c. 
You can remove this patch.

>  #include <dm.h>
>  #include <dm/platform_data/serial_pl01x.h>  #include <i2c.h>
> --
> 2.17.1
Z.Q. Hou April 25, 2020, 8:18 a.m. UTC | #2 
Hi Wasim,

Thanks a lot for your comments!

> -----Original Message-----
> From: Wasim Khan <wasim.khan@nxp.com>
> Sent: 2020年4月21日 13:41
> To: Z.q. Hou <zhiqiang.hou@nxp.com>; u-boot@lists.denx.de; Priyanka Jain
> <priyanka.jain@nxp.com>; Biwen Li <biwen.li@nxp.com>
> Cc: Z.q. Hou <zhiqiang.hou@nxp.com>
> Subject: RE: [PATCHv2 1/9] board: lx2160a: Add header file cpu_func.h
> 
> 
> 
> > -----Original Message-----
> > From: U-Boot <u-boot-bounces@lists.denx.de> On Behalf Of Zhiqiang Hou
> > Sent: Tuesday, March 24, 2020 1:42 PM
> > To: u-boot@lists.denx.de; Priyanka Jain <priyanka.jain@nxp.com>; Biwen
> > Li <biwen.li@nxp.com>
> > Cc: Z.q. Hou <zhiqiang.hou@nxp.com>
> > Subject: [PATCHv2 1/9] board: lx2160a: Add header file cpu_func.h
> >
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > The declaration of the function cpu_numcores() has been moved to
> > cpu_func.h, so add including of the header file to avoid build error.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> > V2:
> >  - No change.
> >
> >  board/freescale/lx2160a/lx2160a.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/board/freescale/lx2160a/lx2160a.c
> > b/board/freescale/lx2160a/lx2160a.c
> > index 134ae22f85..595c774b42 100644
> > --- a/board/freescale/lx2160a/lx2160a.c
> > +++ b/board/freescale/lx2160a/lx2160a.c
> > @@ -5,6 +5,7 @@
> >
> >  #include <common.h>
> >  #include <clock_legacy.h>
> > +#include <cpu_func.h>
> 
> cpu_func.h is already included in board/freescale/lx2160a/lx2160a.c.
> You can remove this patch.

Priyanka, please drop this patch if it had been there.

Thanks,
Zhiqiang

> 
> >  #include <dm.h>
> >  #include <dm/platform_data/serial_pl01x.h>  #include <i2c.h>
> > --
> > 2.17.1
diff mbox series

Patch

diff --git a/board/freescale/lx2160a/lx2160a.c b/board/freescale/lx2160a/lx2160a.c
index 134ae22f85..595c774b42 100644
--- a/board/freescale/lx2160a/lx2160a.c
+++ b/board/freescale/lx2160a/lx2160a.c
@@ -5,6 +5,7 @@ 
 
 #include <common.h>
 #include <clock_legacy.h>
+#include <cpu_func.h>
 #include <dm.h>
 #include <dm/platform_data/serial_pl01x.h>
 #include <i2c.h>