| Message ID | 20191125014412.5291-1-yamada.masahiro@socionext.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | [U-Boot] binman: README: fix default filename of u-boot-with-ucode-ptr | expand |
On Mon, Nov 25, 2019 at 9:45 AM Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > The suffix should be ".bin" instead of ".dtb" . > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > tools/binman/README.entries | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Sun, 24 Nov 2019 at 18:48, Bin Meng <bmeng.cn@gmail.com> wrote: > > On Mon, Nov 25, 2019 at 9:45 AM Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: > > > > The suffix should be ".bin" instead of ".dtb" . > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > tools/binman/README.entries | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Simon Glass <sjg@chromium.org>
Hi, On Wed, 4 Dec 2019 at 21:28, Simon Glass <sjg@chromium.org> wrote: > > On Sun, 24 Nov 2019 at 18:48, Bin Meng <bmeng.cn@gmail.com> wrote: > > > > On Mon, Nov 25, 2019 at 9:45 AM Masahiro Yamada > > <yamada.masahiro@socionext.com> wrote: > > > > > > The suffix should be ".bin" instead of ".dtb" . > > > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > > --- > > > > > > tools/binman/README.entries | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > Reviewed-by: Simon Glass <sjg@chromium.org> Actually I take that back...this should be modified in the source .py file, from which this README is generated. Regards, Simon
diff --git a/tools/binman/README.entries b/tools/binman/README.entries index 10994335217c..26050da7702f 100644 --- a/tools/binman/README.entries +++ b/tools/binman/README.entries @@ -971,7 +971,7 @@ Entry: u-boot-with-ucode-ptr: U-Boot with embedded microcode pointer -------------------------------------------------------------------- Properties / Entry arguments: - - filename: Filename of u-boot-nodtb.dtb (default 'u-boot-nodtb.dtb') + - filename: Filename of u-boot-nodtb.bin (default 'u-boot-nodtb.bin') - optional-ucode: boolean property to make microcode optional. If the u-boot.bin image does not include microcode, no error will be generated.
The suffix should be ".bin" instead of ".dtb" . Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- tools/binman/README.entries | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)