| Message ID | 20190725203428.7071-1-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,1/1] Dockerfile: add python3-sphinx | expand |
On Fri, Jul 26, 2019 at 4:34 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > python3-sphinx is needed to build the htmldocs target. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > This patch relates to > https://gitlab.denx.de/u-boot/gitlab-ci-runner > --- > Dockerfile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Dockerfile b/Dockerfile > index 73c1b8b..e8468ce 100644 > --- a/Dockerfile > +++ b/Dockerfile > @@ -66,6 +66,7 @@ RUN apt-get update && apt-get install -y \ > python-pip \ > python-pytest \ > python-virtualenv \ > + python3-sphinx \ Given other packages are using python2, should we use python-sphinx too? > rpm2cpio \ > sloccount \ > sparse \ > -- Regards, Bin
On Sat, Jul 27, 2019 at 09:08:26PM +0800, Bin Meng wrote: > On Fri, Jul 26, 2019 at 4:34 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > > > python3-sphinx is needed to build the htmldocs target. > > > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > --- > > This patch relates to > > https://gitlab.denx.de/u-boot/gitlab-ci-runner > > --- > > Dockerfile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Dockerfile b/Dockerfile > > index 73c1b8b..e8468ce 100644 > > --- a/Dockerfile > > +++ b/Dockerfile > > @@ -66,6 +66,7 @@ RUN apt-get update && apt-get install -y \ > > python-pip \ > > python-pytest \ > > python-virtualenv \ > > + python3-sphinx \ > > Given other packages are using python2, should we use python-sphinx too? We should be forward-looking towards using python3 for everything as we _really_ do need to do that, so I'm fine with this being python3. A good follow-up test would be to see what happens if we push as much as possible to being python3.
On Sat, Jul 27, 2019 at 9:33 PM Tom Rini <trini@konsulko.com> wrote: > > On Sat, Jul 27, 2019 at 09:08:26PM +0800, Bin Meng wrote: > > On Fri, Jul 26, 2019 at 4:34 AM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > > > > > > python3-sphinx is needed to build the htmldocs target. > > > > > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > > --- > > > This patch relates to > > > https://gitlab.denx.de/u-boot/gitlab-ci-runner > > > --- > > > Dockerfile | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Dockerfile b/Dockerfile > > > index 73c1b8b..e8468ce 100644 > > > --- a/Dockerfile > > > +++ b/Dockerfile > > > @@ -66,6 +66,7 @@ RUN apt-get update && apt-get install -y \ > > > python-pip \ > > > python-pytest \ > > > python-virtualenv \ > > > + python3-sphinx \ > > > > Given other packages are using python2, should we use python-sphinx too? > > We should be forward-looking towards using python3 for everything as we > _really_ do need to do that, so I'm fine with this being python3. > > A good follow-up test would be to see what happens if we push as much as > possible to being python3. OK, makes sense. Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Thu, Jul 25, 2019 at 10:34:28PM +0200, Heinrich Schuchardt wrote: > python3-sphinx is needed to build the htmldocs target. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot-gitlab-ci-runner/master, thanks!
diff --git a/Dockerfile b/Dockerfile index 73c1b8b..e8468ce 100644 --- a/Dockerfile +++ b/Dockerfile @@ -66,6 +66,7 @@ RUN apt-get update && apt-get install -y \ python-pip \ python-pytest \ python-virtualenv \ + python3-sphinx \ rpm2cpio \ sloccount \ sparse \
python3-sphinx is needed to build the htmldocs target. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- This patch relates to https://gitlab.denx.de/u-boot/gitlab-ci-runner --- Dockerfile | 1 + 1 file changed, 1 insertion(+) -- 2.20.1