| Message ID | 20190712112059.25558-4-erosca@de.adit-jv.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Fixes and improvements in BCB and Android docs | expand |
On Fri, Jul 12, 2019 at 2:21 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote: > > Fix warning V1037 reported by PVS-Studio Static Analyzer: > Two or more case-branches perform the same actions. Check lines: 49, 53 > > Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields") > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> > --- > cmd/bcb.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/cmd/bcb.c b/cmd/bcb.c > index 2bd5a744deb5..3b1c7434e287 100644 > --- a/cmd/bcb.c > +++ b/cmd/bcb.c > @@ -46,9 +46,6 @@ static int bcb_is_misused(int argc, char *const argv[]) > > switch (cmd) { > case BCB_CMD_LOAD: > - if (argc != 3) > - goto err; > - break; > case BCB_CMD_FIELD_SET: > if (argc != 3) > goto err; > -- > 2.22.0 > Reviewed-by: Igor Opaniuk <igor.opaniuk@gmail.com>
Superseded by https://patchwork.ozlabs.org/patch/1131357/
("[v2,3/5] cmd: bcb: Fix duplicated handling in two case-branches")
diff --git a/cmd/bcb.c b/cmd/bcb.c index 2bd5a744deb5..3b1c7434e287 100644 --- a/cmd/bcb.c +++ b/cmd/bcb.c @@ -46,9 +46,6 @@ static int bcb_is_misused(int argc, char *const argv[]) switch (cmd) { case BCB_CMD_LOAD: - if (argc != 3) - goto err; - break; case BCB_CMD_FIELD_SET: if (argc != 3) goto err;
Fix warning V1037 reported by PVS-Studio Static Analyzer: Two or more case-branches perform the same actions. Check lines: 49, 53 Fixes: db7b7a05b267 ("cmd: Add 'bcb' command to read/modify/write BCB fields") Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> --- cmd/bcb.c | 3 --- 1 file changed, 3 deletions(-)