| Message ID | 20190712112059.25558-3-erosca@de.adit-jv.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Fixes and improvements in BCB and Android docs | expand |
On Fri, Jul 12, 2019 at 2:21 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote: > > Commit 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB > overview") left some obsolete references of Android documents/paths. > > This has been pointed out by Sam (thanks!) in: > https://patchwork.ozlabs.org/patch/1104245/#2208134 > > Fixes: 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB overview") > Reported-by: Sam Protsenko <semen.protsenko@linaro.org> > Suggested-by: Sam Protsenko <semen.protsenko@linaro.org> > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> > --- > cmd/Kconfig | 2 +- > doc/android/fastboot.txt | 2 +- > test/py/tests/test_avb.py | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 3afb760a816f..3cf8233df62e 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -707,7 +707,7 @@ config CMD_FASTBOOT > Android devices. Fastboot requires either the network stack > enabled or support for acting as a USB device. > > - See doc/README.android-fastboot for more information. > + See doc/android/fastboot.txt for more information. > > config CMD_FDC > bool "fdcboot - Boot from floppy device" > diff --git a/doc/android/fastboot.txt b/doc/android/fastboot.txt > index 431191c473f2..dcf824713f94 100644 > --- a/doc/android/fastboot.txt > +++ b/doc/android/fastboot.txt > @@ -6,7 +6,7 @@ Overview > ======== > > The protocol that is used over USB and UDP is described in the > -``README.android-fastboot-protocol`` file in the same directory. > +``fastboot-protocol.txt`` file in the same directory. > > The current implementation supports the following standard commands: > > diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_avb.py > index 2bb75ed6e2a2..813242343555 100644 > --- a/test/py/tests/test_avb.py > +++ b/test/py/tests/test_avb.py > @@ -8,7 +8,7 @@ > This tests Android Verified Boot 2.0 support in U-boot: > > For additional details about how to build proper vbmeta partition > -check doc/README.avb2 > +check doc/android/avb2.txt > > For configuration verification: > - Corrupt boot partition and check for failure > -- > 2.22.0 > Reviewed-by: Igor Opaniuk <igor.opaniuk@gmail.com>
On Fri, Jul 12, 2019 at 2:25 PM Igor Opaniuk <igor.opaniuk@gmail.com> wrote: > > On Fri, Jul 12, 2019 at 2:21 PM Eugeniu Rosca <erosca@de.adit-jv.com> wrote: > > > > Commit 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB > > overview") left some obsolete references of Android documents/paths. > > > > This has been pointed out by Sam (thanks!) in: > > https://patchwork.ozlabs.org/patch/1104245/#2208134 > > > > Fixes: 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB overview") > > Reported-by: Sam Protsenko <semen.protsenko@linaro.org> > > Suggested-by: Sam Protsenko <semen.protsenko@linaro.org> > > Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> > > --- > > cmd/Kconfig | 2 +- > > doc/android/fastboot.txt | 2 +- > > test/py/tests/test_avb.py | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/cmd/Kconfig b/cmd/Kconfig > > index 3afb760a816f..3cf8233df62e 100644 > > --- a/cmd/Kconfig > > +++ b/cmd/Kconfig > > @@ -707,7 +707,7 @@ config CMD_FASTBOOT > > Android devices. Fastboot requires either the network stack > > enabled or support for acting as a USB device. > > > > - See doc/README.android-fastboot for more information. > > + See doc/android/fastboot.txt for more information. > > > > config CMD_FDC > > bool "fdcboot - Boot from floppy device" > > diff --git a/doc/android/fastboot.txt b/doc/android/fastboot.txt > > index 431191c473f2..dcf824713f94 100644 > > --- a/doc/android/fastboot.txt > > +++ b/doc/android/fastboot.txt > > @@ -6,7 +6,7 @@ Overview > > ======== > > > > The protocol that is used over USB and UDP is described in the > > -``README.android-fastboot-protocol`` file in the same directory. > > +``fastboot-protocol.txt`` file in the same directory. > > > > The current implementation supports the following standard commands: > > > > diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_avb.py > > index 2bb75ed6e2a2..813242343555 100644 > > --- a/test/py/tests/test_avb.py > > +++ b/test/py/tests/test_avb.py > > @@ -8,7 +8,7 @@ > > This tests Android Verified Boot 2.0 support in U-boot: > > > > For additional details about how to build proper vbmeta partition > > -check doc/README.avb2 > > +check doc/android/avb2.txt > > > > For configuration verification: > > - Corrupt boot partition and check for failure > > -- > > 2.22.0 > > > > Reviewed-by: Igor Opaniuk <igor.opaniuk@gmail.com> > Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > -- > Best regards - Freundliche Grüsse - Meilleures salutations > > Igor Opaniuk > > mailto: igor.opaniuk@gmail.com > skype: igor.opanyuk > +380 (93) 836 40 67 > http://ua.linkedin.com/in/iopaniuk
Hi Sam,
On Fri, Jul 12, 2019 at 04:25:11PM +0300, Sam Protsenko wrote:
> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Please, discard the v1 [*] and consider v2 [**] instead.
There should be a clear protocol to communicate that to the maintainers,
such that we avoid seeing the v1 applied to master. I placed a comment
on the v1 [*] patchwork front-page. I hope that's enough.
[*] https://patchwork.ozlabs.org/cover/1131295/
[**] https://patchwork.ozlabs.org/cover/1131356/
Superseded by https://patchwork.ozlabs.org/patch/1131354/
("[v2,2/5] treewide: Fix stale references of Android docs")
diff --git a/cmd/Kconfig b/cmd/Kconfig index 3afb760a816f..3cf8233df62e 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -707,7 +707,7 @@ config CMD_FASTBOOT Android devices. Fastboot requires either the network stack enabled or support for acting as a USB device. - See doc/README.android-fastboot for more information. + See doc/android/fastboot.txt for more information. config CMD_FDC bool "fdcboot - Boot from floppy device" diff --git a/doc/android/fastboot.txt b/doc/android/fastboot.txt index 431191c473f2..dcf824713f94 100644 --- a/doc/android/fastboot.txt +++ b/doc/android/fastboot.txt @@ -6,7 +6,7 @@ Overview ======== The protocol that is used over USB and UDP is described in the -``README.android-fastboot-protocol`` file in the same directory. +``fastboot-protocol.txt`` file in the same directory. The current implementation supports the following standard commands: diff --git a/test/py/tests/test_avb.py b/test/py/tests/test_avb.py index 2bb75ed6e2a2..813242343555 100644 --- a/test/py/tests/test_avb.py +++ b/test/py/tests/test_avb.py @@ -8,7 +8,7 @@ This tests Android Verified Boot 2.0 support in U-boot: For additional details about how to build proper vbmeta partition -check doc/README.avb2 +check doc/android/avb2.txt For configuration verification: - Corrupt boot partition and check for failure
Commit 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB overview") left some obsolete references of Android documents/paths. This has been pointed out by Sam (thanks!) in: https://patchwork.ozlabs.org/patch/1104245/#2208134 Fixes: 9bdf0e8fef86 ("doc: relocate/rename Android README and add BCB overview") Reported-by: Sam Protsenko <semen.protsenko@linaro.org> Suggested-by: Sam Protsenko <semen.protsenko@linaro.org> Signed-off-by: Eugeniu Rosca <erosca@de.adit-jv.com> --- cmd/Kconfig | 2 +- doc/android/fastboot.txt | 2 +- test/py/tests/test_avb.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)