diff mbox series

[U-Boot,6/7] gpio: do not include <asm/arch/gpio.h> on ARCH_LX2160A

Message ID 20190523092207.41906-6-chuanhua.han@nxp.com
State Superseded
Delegated to: Prabhakar Kushwaha
Headers show
Series [U-Boot,1/7] armv8: lx2160a: The lx2160a platform supports the I2C driver model. | expand

Commit Message

Chuanhua Han May 23, 2019, 9:22 a.m. UTC
As no gpio.h is defined for this architecture, to avoid
compilation failure, do not include <asm/arch/gpio.h> for
arch ls2160a.

Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
---
 arch/arm/include/asm/gpio.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Heiko Schocher May 24, 2019, 5:01 a.m. UTC | #1
Hello Chuanhua Han,

Am 23.05.2019 um 11:22 schrieb Chuanhua Han:
> As no gpio.h is defined for this architecture, to avoid
> compilation failure, do not include <asm/arch/gpio.h> for
> arch ls2160a.
> 
> Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> ---
>   arch/arm/include/asm/gpio.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

Hmm... I wonder, why this does not popup with current source?

bye,
Heiko
Chuanhua Han May 30, 2019, 3:39 a.m. UTC | #2
> -----Original Message-----
> From: Heiko Schocher <hs@denx.de>
> Sent: 2019年5月24日 13:01
> To: Chuanhua Han <chuanhua.han@nxp.com>
> Cc: albert.u.boot@aribaud.net; Priyanka Jain <priyanka.jain@nxp.com>; Udit
> Agarwal <udit.agarwal@nxp.com>; u-boot@lists.denx.de
> Subject: [EXT] Re: [PATCH 6/7] gpio: do not include <asm/arch/gpio.h> on
> ARCH_LX2160A
> 
> Caution: EXT Email
> 
> Hello Chuanhua Han,
> 
> Am 23.05.2019 um 11:22 schrieb Chuanhua Han:
> > As no gpio.h is defined for this architecture, to avoid compilation
> > failure, do not include <asm/arch/gpio.h> for arch ls2160a.
> >
> > Signed-off-by: Chuanhua Han <chuanhua.han@nxp.com>
> > ---
> >   arch/arm/include/asm/gpio.h | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Heiko Schocher <hs@denx.de>
> 
> Hmm... I wonder, why this does not popup with current source?
Ls2160a platform does not include  <asm/arch/gpio.h>
> 
> bye,
> Heiko
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de
diff mbox series

Patch

diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h
index 370031f2ac..f78b976e10 100644
--- a/arch/arm/include/asm/gpio.h
+++ b/arch/arm/include/asm/gpio.h
@@ -1,6 +1,7 @@ 
 #if !defined(CONFIG_ARCH_UNIPHIER) && !defined(CONFIG_ARCH_STI) && \
 	!defined(CONFIG_ARCH_K3) && !defined(CONFIG_ARCH_BCM6858) && \
-	!defined(CONFIG_ARCH_BCM63158) && !defined(CONFIG_ARCH_ROCKCHIP)
+	!defined(CONFIG_ARCH_BCM63158) && !defined(CONFIG_ARCH_ROCKCHIP) && \
+	!defined(CONFIG_ARCH_LX2160A)
 #include <asm/arch/gpio.h>
 #endif
 #include <asm-generic/gpio.h>