diff mbox series

[U-Boot,19/45] cros: Adjust board_get_cros_ec_dev() to return a udevice

Message ID 20181001182249.129565-20-sjg@chromium.org
State Accepted
Commit 42116f644b33d4c9e7b495ec87612aa922452453
Delegated to: Simon Glass
Headers show
Series Various fixes and improvements | expand

Commit Message

Simon Glass Oct. 1, 2018, 6:22 p.m. UTC 
Rather than returning what is effectively an internal data structure,
return the cros EC device itself.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 common/cros_ec.c  | 4 ++--
 include/cros_ec.h | 4 +---
 2 files changed, 3 insertions(+), 5 deletions(-)

Comments

Simon Glass Oct. 9, 2018, 11:55 p.m. UTC | #1 
Rather than returning what is effectively an internal data structure,
return the cros EC device itself.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 common/cros_ec.c  | 4 ++--
 include/cros_ec.h | 4 +---
 2 files changed, 3 insertions(+), 5 deletions(-)

Applied to u-boot-dm
diff mbox series

Patch

diff --git a/common/cros_ec.c b/common/cros_ec.c
index 1a0caf80dde..4ca15e19d5f 100644
--- a/common/cros_ec.c
+++ b/common/cros_ec.c
@@ -13,7 +13,7 @@ 
 #include <dm.h>
 #include <errno.h>
 
-struct cros_ec_dev *board_get_cros_ec_dev(void)
+struct udevice *board_get_cros_ec_dev(void)
 {
 	struct udevice *dev;
 	int ret;
@@ -23,7 +23,7 @@  struct cros_ec_dev *board_get_cros_ec_dev(void)
 		debug("%s: Error %d\n", __func__, ret);
 		return NULL;
 	}
-	return dev_get_uclass_priv(dev);
+	return dev;
 }
 
 int cros_ec_get_error(void)
diff --git a/include/cros_ec.h b/include/cros_ec.h
index afd99aae946..5576bcf32ee 100644
--- a/include/cros_ec.h
+++ b/include/cros_ec.h
@@ -208,11 +208,9 @@  int cros_ec_flash_update_rw(struct udevice *dev, const uint8_t  *image,
 /**
  * Return a pointer to the board's CROS-EC device
  *
- * This should be implemented by board files.
- *
  * @return pointer to CROS-EC device, or NULL if none is available
  */
-struct cros_ec_dev *board_get_cros_ec_dev(void);
+struct udevice *board_get_cros_ec_dev(void);
 
 struct dm_cros_ec_ops {
 	int (*check_version)(struct udevice *dev);