| Message ID | 20181001182249.129565-41-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 595aac98246bb26d128389e25b147ae9643afb26 |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | Various fixes and improvements | expand |
On Tue, Oct 2, 2018 at 2:48 AM Simon Glass <sjg@chromium.org> wrote: > > Add some logging on failure. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > drivers/pci/pci_rom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
On Tue, Oct 2, 2018 at 2:48 AM Simon Glass <sjg@chromium.org> wrote: > > Add some logging on failure. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > drivers/pci/pci_rom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot-dm
diff --git a/drivers/pci/pci_rom.c b/drivers/pci/pci_rom.c index 29113f79586..eaacd4066e8 100644 --- a/drivers/pci/pci_rom.c +++ b/drivers/pci/pci_rom.c @@ -247,7 +247,7 @@ int dm_pci_run_vga_bios(struct udevice *dev, int (*int15_handler)(void), } if (!board_should_load_oprom(dev)) - return -ENXIO; + return log_msg_ret("Should not load OPROM", -ENXIO); ret = pci_rom_probe(dev, &rom); if (ret) @@ -328,7 +328,7 @@ int vbe_setup_video_priv(struct vesa_mode_info *vesa, struct video_uc_platdata *plat) { if (!vesa->x_resolution) - return -ENXIO; + return log_msg_ret("No x resolution", -ENXIO); uc_priv->xsize = vesa->x_resolution; uc_priv->ysize = vesa->y_resolution; switch (vesa->bits_per_pixel) {
Add some logging on failure. Signed-off-by: Simon Glass <sjg@chromium.org> --- drivers/pci/pci_rom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)