| Message ID | 20180903083341.19286-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [U-Boot,v1] sandbox: Build with -fPIC | expand |
Hi Andy, On Mon, Sep 3, 2018 at 4:33 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Sandbox is not a real bootloader and it does require > a position independent code to be supported. > > Thus, build it with -fPIC explicitly. > > Fixes: 16940f720f9b ("Makefile: Don't generate position independent code") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Reported-by: Simon Glass <sjg@chromium.org> > --- > arch/sandbox/config.mk | 1 + > 1 file changed, 1 insertion(+) This patch does not apply on top of u-boot/master. Can you please rebase? Manually applied the changes, and tested Sandbox on my Ubuntu 16.04 machine, although it does not expose the issue that Simon was seeing on 18.04. FWIW Tested-by: Bin Meng <bmeng.cn@gmail.com> Regards, Bin
diff --git a/arch/sandbox/config.mk b/arch/sandbox/config.mk index 5e7077bfe7..4599839791 100644 --- a/arch/sandbox/config.mk +++ b/arch/sandbox/config.mk @@ -3,6 +3,7 @@ PLATFORM_CPPFLAGS += -D__SANDBOX__ -U_FORTIFY_SOURCE PLATFORM_CPPFLAGS += -DCONFIG_ARCH_MAP_SYSMEM +PLATFORM_CPPFLAGS += -fPIC PLATFORM_LIBS += -lrt LDFLAGS_FINAL += --gc-sections
Sandbox is not a real bootloader and it does require a position independent code to be supported. Thus, build it with -fPIC explicitly. Fixes: 16940f720f9b ("Makefile: Don't generate position independent code") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reported-by: Simon Glass <sjg@chromium.org> --- arch/sandbox/config.mk | 1 + 1 file changed, 1 insertion(+)