diff mbox series

[U-Boot,02/41] imx: add Kconfig entry for i.MX8

Message ID 20180528122526.20597-3-peng.fan@nxp.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series imx: add i.MX8QXP support | expand

Commit Message

Peng Fan May 28, 2018, 12:24 p.m. UTC 
Add Kconfig entry for i.MX8 and i.MX8QXP
Select HAVE_SC_FIRMWARE for i.MX8QXP

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm/Kconfig               |  8 ++++++++
 arch/arm/mach-imx/Makefile     |  1 +
 arch/arm/mach-imx/imx8/Kconfig | 13 +++++++++++++
 3 files changed, 22 insertions(+)
 create mode 100644 arch/arm/mach-imx/imx8/Kconfig

Comments

Stefano Babic June 27, 2018, 8:19 a.m. UTC | #1 
On 28/05/2018 14:24, Peng Fan wrote:
> Add Kconfig entry for i.MX8 and i.MX8QXP
> Select HAVE_SC_FIRMWARE for i.MX8QXP
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm/Kconfig               |  8 ++++++++
>  arch/arm/mach-imx/Makefile     |  1 +
>  arch/arm/mach-imx/imx8/Kconfig | 13 +++++++++++++
>  3 files changed, 22 insertions(+)
>  create mode 100644 arch/arm/mach-imx/imx8/Kconfig
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 3e05f79f63..0406c1dada 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -635,6 +635,12 @@ config ARCH_MESON
>  	  targeted at media players and tablet computers. We currently
>  	  support the S905 (GXBaby) 64-bit SoC.
>  
> +config ARCH_IMX8
> +	bool "NXP i.MX8 platform"
> +	select ARM64
> +	select DM
> +	select OF_CONTROL
> +
>  config ARCH_MX8M
>  	bool "NXP i.MX8M platform"
>  	select ARM64
> @@ -1325,6 +1331,8 @@ source "arch/arm/mach-imx/mx7/Kconfig"
>  
>  source "arch/arm/mach-imx/mx7ulp/Kconfig"
>  
> +source "arch/arm/mach-imx/imx8/Kconfig"
> +
>  source "arch/arm/mach-imx/mx8m/Kconfig"
>  
>  source "arch/arm/mach-imx/mxs/Kconfig"
> diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
> index 733c308670..375789efb2 100644
> --- a/arch/arm/mach-imx/Makefile
> +++ b/arch/arm/mach-imx/Makefile
> @@ -141,3 +141,4 @@ obj-$(CONFIG_MX6) += mx6/
>  obj-$(CONFIG_MX7) += mx7/
>  obj-$(CONFIG_ARCH_MX7ULP) += mx7ulp/
>  obj-$(CONFIG_MX8M) += mx8m/
> +obj-$(CONFIG_ARCH_IMX8) += imx8/
> diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
> new file mode 100644
> index 0000000000..58cb19946f
> --- /dev/null
> +++ b/arch/arm/mach-imx/imx8/Kconfig
> @@ -0,0 +1,13 @@
> +if ARCH_IMX8
> +
> +config IMX8
> +	bool
> +	default y
> +
> +config IMX8QXP
> +	bool
> +
> +config SYS_SOC
> +	default "imx8"
> +
> +endif
> 

Just to be sure. We introduce several switches:

	ARCH_IMX8 ==> architecture
	IMX8 	==> set for all SOC variants
	IMX8QXP ==> specific variant

then we will have, as usual, a TARGET_ for the board. This reflects the
MX6, yes (but why do you introduce a "I" in the name ? Shouldn't we use
MX8 instead of IMX8 ?).

Best regards,
Stefano Babic
Peng Fan July 7, 2018, 12:46 p.m. UTC | #2 
Hi Stefano,

> -----Original Message-----
> From: Stefano Babic [mailto:sbabic@denx.de]
> Sent: 2018年6月27日 16:20
> To: Peng Fan <peng.fan@nxp.com>; sbabic@denx.de; Fabio Estevam
> <fabio.estevam@nxp.com>
> Cc: u-boot@lists.denx.de
> Subject: Re: [PATCH 02/41] imx: add Kconfig entry for i.MX8
> 
> On 28/05/2018 14:24, Peng Fan wrote:
> > Add Kconfig entry for i.MX8 and i.MX8QXP Select HAVE_SC_FIRMWARE for
> > i.MX8QXP
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >  arch/arm/Kconfig               |  8 ++++++++
> >  arch/arm/mach-imx/Makefile     |  1 +
> >  arch/arm/mach-imx/imx8/Kconfig | 13 +++++++++++++
> >  3 files changed, 22 insertions(+)
> >  create mode 100644 arch/arm/mach-imx/imx8/Kconfig
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index
> > 3e05f79f63..0406c1dada 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -635,6 +635,12 @@ config ARCH_MESON
> >  	  targeted at media players and tablet computers. We currently
> >  	  support the S905 (GXBaby) 64-bit SoC.
> >
> > +config ARCH_IMX8
> > +	bool "NXP i.MX8 platform"
> > +	select ARM64
> > +	select DM
> > +	select OF_CONTROL
> > +
> >  config ARCH_MX8M
> >  	bool "NXP i.MX8M platform"
> >  	select ARM64
> > @@ -1325,6 +1331,8 @@ source "arch/arm/mach-imx/mx7/Kconfig"
> >
> >  source "arch/arm/mach-imx/mx7ulp/Kconfig"
> >
> > +source "arch/arm/mach-imx/imx8/Kconfig"
> > +
> >  source "arch/arm/mach-imx/mx8m/Kconfig"
> >
> >  source "arch/arm/mach-imx/mxs/Kconfig"
> > diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
> > index 733c308670..375789efb2 100644
> > --- a/arch/arm/mach-imx/Makefile
> > +++ b/arch/arm/mach-imx/Makefile
> > @@ -141,3 +141,4 @@ obj-$(CONFIG_MX6) += mx6/
> >  obj-$(CONFIG_MX7) += mx7/
> >  obj-$(CONFIG_ARCH_MX7ULP) += mx7ulp/
> >  obj-$(CONFIG_MX8M) += mx8m/
> > +obj-$(CONFIG_ARCH_IMX8) += imx8/
> > diff --git a/arch/arm/mach-imx/imx8/Kconfig
> > b/arch/arm/mach-imx/imx8/Kconfig new file mode 100644 index
> > 0000000000..58cb19946f
> > --- /dev/null
> > +++ b/arch/arm/mach-imx/imx8/Kconfig
> > @@ -0,0 +1,13 @@
> > +if ARCH_IMX8
> > +
> > +config IMX8
> > +	bool
> > +	default y
> > +
> > +config IMX8QXP
> > +	bool
> > +
> > +config SYS_SOC
> > +	default "imx8"
> > +
> > +endif
> >
> 
> Just to be sure. We introduce several switches:
> 
> 	ARCH_IMX8 ==> architecture
> 	IMX8 	==> set for all SOC variants
> 	IMX8QXP ==> specific variant
> 
> then we will have, as usual, a TARGET_ for the board. This reflects the MX6, yes
> (but why do you introduce a "I" in the name ? Shouldn't we use
> MX8 instead of IMX8 ?).

We are asked to use IMX8 to better reflect i.MX8 from marketing team.
So we switch to use IMX8 for i.MX8 Family.

Thanks,
Peng.

> 
> Best regards,
> Stefano Babic
> 
> --
> ================================================================
> =====
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> ================================================================
> =====
diff mbox series

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 3e05f79f63..0406c1dada 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -635,6 +635,12 @@  config ARCH_MESON
 	  targeted at media players and tablet computers. We currently
 	  support the S905 (GXBaby) 64-bit SoC.
 
+config ARCH_IMX8
+	bool "NXP i.MX8 platform"
+	select ARM64
+	select DM
+	select OF_CONTROL
+
 config ARCH_MX8M
 	bool "NXP i.MX8M platform"
 	select ARM64
@@ -1325,6 +1331,8 @@  source "arch/arm/mach-imx/mx7/Kconfig"
 
 source "arch/arm/mach-imx/mx7ulp/Kconfig"
 
+source "arch/arm/mach-imx/imx8/Kconfig"
+
 source "arch/arm/mach-imx/mx8m/Kconfig"
 
 source "arch/arm/mach-imx/mxs/Kconfig"
diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile
index 733c308670..375789efb2 100644
--- a/arch/arm/mach-imx/Makefile
+++ b/arch/arm/mach-imx/Makefile
@@ -141,3 +141,4 @@  obj-$(CONFIG_MX6) += mx6/
 obj-$(CONFIG_MX7) += mx7/
 obj-$(CONFIG_ARCH_MX7ULP) += mx7ulp/
 obj-$(CONFIG_MX8M) += mx8m/
+obj-$(CONFIG_ARCH_IMX8) += imx8/
diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig
new file mode 100644
index 0000000000..58cb19946f
--- /dev/null
+++ b/arch/arm/mach-imx/imx8/Kconfig
@@ -0,0 +1,13 @@ 
+if ARCH_IMX8
+
+config IMX8
+	bool
+	default y
+
+config IMX8QXP
+	bool
+
+config SYS_SOC
+	default "imx8"
+
+endif