diff mbox series

[U-Boot,27/41] net: fec: do not access reserved register for i.MX8

Message ID 20180528122526.20597-28-peng.fan@nxp.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series imx: add i.MX8QXP support | expand

Commit Message

Peng Fan May 28, 2018, 12:25 p.m. UTC 
The MIB RAM and FIFO receive start register does not exist on
i.MX8. Accessing these register will cause SERROR.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
---
 drivers/net/fec_mxc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joe Hershberger June 12, 2018, 6:26 p.m. UTC | #1 
On Mon, May 28, 2018 at 7:25 AM, Peng Fan <peng.fan@nxp.com> wrote:
> The MIB RAM and FIFO receive start register does not exist on
> i.MX8. Accessing these register will cause SERROR.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Joe Hershberger <joe.hershberger@ni.com>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Anatolij Gustschin Oct. 18, 2018, 1:38 p.m. UTC | #2 
Hi Peng,

On Mon, 28 May 2018 20:25:12 +0800
Peng Fan peng.fan@nxp.com wrote:

> The MIB RAM and FIFO receive start register does not exist on
> i.MX8. Accessing these register will cause SERROR.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> Cc: Joe Hershberger <joe.hershberger@ni.com>
> ---
>  drivers/net/fec_mxc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This should be merged for v2018.11, so

applied to u-boot-staging/agust@denx.de, thanks!

--
Anatolij
diff mbox series

Patch

diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
index 694a0b2f7e..b512a71c0c 100644
--- a/drivers/net/fec_mxc.c
+++ b/drivers/net/fec_mxc.c
@@ -564,7 +564,7 @@  static int fec_init(struct eth_device *dev, bd_t *bd)
 	writel(0x00000000, &fec->eth->gaddr2);
 
 	/* Do not access reserved register */
-	if (!is_mx6ul() && !is_mx6ull() && !is_mx8m()) {
+	if (!is_mx6ul() && !is_mx6ull() && !is_mx8m() && !is_imx8()) {
 		/* clear MIB RAM */
 		for (i = mib_ptr; i <= mib_ptr + 0xfc; i += 4)
 			writel(0, i);