| Message ID | 20180515095728.16572-8-miquel.raynal@bootlin.com |
|---|---|
| State | Accepted |
| Commit | 96cc4e31fb8450c8ee3cee7bd5f8580a0c9a2224 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Introduce TPMv2.0 support | expand |
On Tue, May 15, 2018 at 11:57:03AM +0200, Miquel Raynal wrote: > Fix following checkpatch.pl issue in TPM-related code: > > WARNING: Missing a blank line after declarations > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Tom Rini <trini@konsulko.com>
On 15 May 2018 at 19:57, Miquel Raynal <miquel.raynal@bootlin.com> wrote: > Fix following checkpatch.pl issue in TPM-related code: > > WARNING: Missing a blank line after declarations > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > lib/tpm.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Simon Glass <sjg@chromium.org>
On Tue, May 15, 2018 at 11:57:03AM +0200, Miquel Raynal wrote: > Fix following checkpatch.pl issue in TPM-related code: > > WARNING: Missing a blank line after declarations > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > Reviewed-by: Tom Rini <trini@konsulko.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/lib/tpm.c b/lib/tpm.c index cc76a46e78..e8ebbbe6cd 100644 --- a/lib/tpm.c +++ b/lib/tpm.c @@ -205,6 +205,7 @@ int unpack_byte_string(const u8 *str, size_t size, const char *format, ...) static u32 tpm_command_size(const void *command) { const size_t command_size_offset = 2; + return get_unaligned_be32(command + command_size_offset); } @@ -217,6 +218,7 @@ static u32 tpm_command_size(const void *command) static u32 tpm_return_code(const void *response) { const size_t return_code_offset = 6; + return get_unaligned_be32(response + return_code_offset); } @@ -844,6 +846,7 @@ u32 tpm_terminate_auth_session(u32 auth_handle) u32 tpm_end_oiap(void) { u32 err = TPM_SUCCESS; + if (oiap_session.valid) err = tpm_terminate_auth_session(oiap_session.handle); return err;
Fix following checkpatch.pl issue in TPM-related code: WARNING: Missing a blank line after declarations Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- lib/tpm.c | 3 +++ 1 file changed, 3 insertions(+)