diff mbox series

[U-Boot,v4,11/32] tpm: add missing parameter in private data structure description

Message ID 20180515095728.16572-12-miquel.raynal@bootlin.com
State Accepted
Commit 3219cf693a1674650eba2a57d4bf8c87d9f21752
Delegated to: Tom Rini
Headers show
Series Introduce TPMv2.0 support | expand

Commit Message

Miquel Raynal May 15, 2018, 9:57 a.m. UTC
Both parameters 'duration_ms' and 'retry_time_ms' of the tpm_chip_priv
structure are documented is the comment above the declaration but 'buf'
was forgotten. Add the missing description.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 include/tpm-common.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Tom Rini May 15, 2018, 3:58 p.m. UTC | #1
On Tue, May 15, 2018 at 11:57:07AM +0200, Miquel Raynal wrote:

> Both parameters 'duration_ms' and 'retry_time_ms' of the tpm_chip_priv
> structure are documented is the comment above the declaration but 'buf'
> was forgotten. Add the missing description.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Simon Glass May 15, 2018, 4:04 p.m. UTC | #2
On 15 May 2018 at 19:57, Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Both parameters 'duration_ms' and 'retry_time_ms' of the tpm_chip_priv
> structure are documented is the comment above the declaration but 'buf'
> was forgotten. Add the missing description.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  include/tpm-common.h | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini May 26, 2018, 3:54 p.m. UTC | #3
On Tue, May 15, 2018 at 11:57:07AM +0200, Miquel Raynal wrote:

> Both parameters 'duration_ms' and 'retry_time_ms' of the tpm_chip_priv
> structure are documented is the comment above the declaration but 'buf'
> was forgotten. Add the missing description.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/tpm-common.h b/include/tpm-common.h
index ecc7bc067a..6b15466781 100644
--- a/include/tpm-common.h
+++ b/include/tpm-common.h
@@ -36,6 +36,7 @@  enum tpm_duration {
  *
  * @duration_ms:	Length of each duration type in milliseconds
  * @retry_time_ms:	Time to wait before retrying receive
+ * @buf:		Buffer used during the exchanges with the chip
  */
 struct tpm_chip_priv {
 	uint duration_ms[TPM_DURATION_COUNT];